Repository navigation
Conversation
…no clipped flow block
This was referenced Oct 9, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final exact-HEAD QA checkpoint — 2026-10-09
56de3e2e0e82f01f04c49ca270d37f752e99f86f; no unresolved CI failure on final commit. Earlier failure runs were legacy brittle-XAML-text/style assertions, replaced with stronger code-behind and inherited-style checks; no production behavior changed to bypass tests.Code/CI acceptance checkpoint (2026-10-09)
56de3e2e0e82f01f04c49ca270d37f752e99f86f, stacked on P7.6C P7.6C #446: auditable bounded per-RCB continuity evidence in Copy Diagnostic #485 HEAD8d764128ccf764b20d27d178dfec64ec71581b81.BasedOninheritance from shared styles; no workflow or domain behavior loosened. Keep history of initial failed CI runs for audit.Field screenshot problem / root cause
User screenshots on native Windows Studio show low-contrast dark heading/helper text against dark background, an oversized fixed-height Add IED card whose technical Flow footer is cut off, and confusing technical copy. The Add IED input already has a functioning saved-IP dropdown; adding duplicate recent-history state would be naive.
Solution — strictly presentation-only
Styles/IedTaskDialogStyles.xamlwith high-contrast light canvas, ink and secondary typography, accessible minimum contrast, consistent surfaces, action/card sizing; global ARSAS theme untouched.SclSignalSelectionModeWindow.xaml: clean header, one IED identity chip rather than duplicated name, monitoring-primary actions and engineering-secondary actions, short natural-language labels and tooltips for detailed control-plane behavior. Preserves all five existing click handlers, static DataSet enablement and report-backed state, Open SCL workspace vs exact IED card scope.IpConnectWizardWindow.xaml: auto-sized natural layout instead ofHeight=470and 1-star row, scroll fallback and max height for DPI/small monitors, focused IP + MMS port form, compact discovery banner, real validation status, consistent footer keyboard defaults. Existing recent-IP ComboBox source and C# validation untouched; no second history list, no network access before user clicks.SclSignalSelectionModeWindow.xaml.cs: only concise descriptive copy and status summary; no method or session changes.Multi-thread safety / authority
Stacked DRAFT on #485 exact
8d764128ccf764b20d27d178dfec64ec71581b81, which includes ongoing P7.6C diagnostic integrity. UX branch touches only the two dialog views, one dialog copy C#, isolated style dictionary and a new offline test; does not edit engine, monitoring runtime, RCB/SCD/Discovery, control workflows, COMTRADE backend, or shared App.xaml. Avoid merging UX first into unrelated mainline branch; coordinate integration after P7 stack acceptance. Maintain DRAFT until exact-head CI, Windows artifact and screenshot review.Acceptance