Skip to content

UX: legible, compact IED Actions and Add IEC 61850 IED dialogs - #486

Draft
masarray wants to merge 7 commits into
feat/446-p7-6c-per-rcb-continuity-snapshotfrom
ux/446-p7-dialog-clarity-contrast-layout
Draft

masarray wants to merge 7 commits into
feat/446-p7-6c-per-rcb-continuity-snapshotfrom
ux/446-p7-dialog-clarity-contrast-layout

Conversation

@masarray

@masarray masarray commented Oct 8, 2026 •

Copy link
Copy Markdown
Owner

Final exact-HEAD QA checkpoint — 2026-10-09

  • 9/9 GitHub Actions workflows SUCCESS on exact HEAD 56de3e2e0e82f01f04c49ca270d37f752e99f86f; no unresolved CI failure on final commit. Earlier failure runs were legacy brittle-XAML-text/style assertions, replaced with stronger code-behind and inherited-style checks; no production behavior changed to bypass tests.
  • Merge Execution Guard: 1,404 passed, 0 failed, 0 skipped, inclusive of 4 new high-contrast/natural-height/binding and retained action-flow regression tests.
  • Main Windows x64 native build, tests, publish and smoke: SUCCESS; portable single EXE artifact.
  • Smart Discovery Windows x64 build: SUCCESS; field-capture ZIP artifact.
  • CodeCommitted / CIPassed / ArtifactAvailable = YES. VisualVerified/high-DPI field screenshot = pending, MergeReady/Merged/Released = NO. Maintains exact P7.6C stack and engine pin; no protocol behavior changes.

Code/CI acceptance checkpoint (2026-10-09)

  • Final code HEAD: 56de3e2e0e82f01f04c49ca270d37f752e99f86f, stacked on P7.6C P7.6C #446: auditable bounded per-RCB continuity evidence in Copy Diagnostic #485 HEAD 8d764128ccf764b20d27d178dfec64ec71581b81.
  • Merge Execution Guard: 1,404/1,404 passed, 0 failed, 0 skipped; WPF XAML compiled. The 4 new dialog regression checks pass, including primary/secondary color contrast, preserved IP/port validation, saved endpoint binding and SCL task ownership.
  • Smart Discovery Windows field-capture build: SUCCESS; download UX Windows x64 artifact.
  • First two branch iterations uncovered legacy test assertions coupled to literal XAML text and style names. Updated legacy test to verify actual code-behind context and BasedOn inheritance from shared styles; no workflow or domain behavior loosened. Keep history of initial failed CI runs for audit.
  • Native Build ARSAS run still publishing self-contained portable EXE; final 9/9 status pending until GitHub finishes. Native field screenshot/high DPI QA pending; no merge or public release.

Field screenshot problem / root cause

User screenshots on native Windows Studio show low-contrast dark heading/helper text against dark background, an oversized fixed-height Add IED card whose technical Flow footer is cut off, and confusing technical copy. The Add IED input already has a functioning saved-IP dropdown; adding duplicate recent-history state would be naive.

Solution — strictly presentation-only

  • Shared locally scoped Styles/IedTaskDialogStyles.xaml with high-contrast light canvas, ink and secondary typography, accessible minimum contrast, consistent surfaces, action/card sizing; global ARSAS theme untouched.
  • SclSignalSelectionModeWindow.xaml: clean header, one IED identity chip rather than duplicated name, monitoring-primary actions and engineering-secondary actions, short natural-language labels and tooltips for detailed control-plane behavior. Preserves all five existing click handlers, static DataSet enablement and report-backed state, Open SCL workspace vs exact IED card scope.
  • IpConnectWizardWindow.xaml: auto-sized natural layout instead of Height=470 and 1-star row, scroll fallback and max height for DPI/small monitors, focused IP + MMS port form, compact discovery banner, real validation status, consistent footer keyboard defaults. Existing recent-IP ComboBox source and C# validation untouched; no second history list, no network access before user clicks.
  • SclSignalSelectionModeWindow.xaml.cs: only concise descriptive copy and status summary; no method or session changes.
  • Synthetic/XAML regression tests verify explicit action wiring and saved endpoint binding, no clipped sizing, help copy reduction, light-theme token integrity, and WCAG 4.5+ secondary/7+ primary contrast.

Multi-thread safety / authority

Stacked DRAFT on #485 exact 8d764128ccf764b20d27d178dfec64ec71581b81, which includes ongoing P7.6C diagnostic integrity. UX branch touches only the two dialog views, one dialog copy C#, isolated style dictionary and a new offline test; does not edit engine, monitoring runtime, RCB/SCD/Discovery, control workflows, COMTRADE backend, or shared App.xaml. Avoid merging UX first into unrelated mainline branch; coordinate integration after P7 stack acceptance. Maintain DRAFT until exact-head CI, Windows artifact and screenshot review.

Acceptance

  • Both dialogs readable on app light/dark/Windows theme configurations without low-contrast text.
  • No fixed-height clipping and no technical wall of text; remains keyboard-accessible and bounded under high DPI.
  • Same actual IED names, saved-IP source, valid IP+port checks, static DataSet availability/click behavior, offline/engineering separation.
  • CI + native Windows portable build verified on exact branch head; visual check still required on target Windows DPI.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant