Repository navigation
ci(native): build and test the native Swift packages on macOS #7984
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| // Copyright (c) Meta Platforms, Inc. and affiliates. | ||
|
|
||
| /** | ||
| * @file Routing contract for the native Swift coverage in the broad CI lane. | ||
| * | ||
| * The Swift packages of @astryxdesign/native build only on macOS. They join | ||
| * the `test` owner (AST-030 FR11), but a macOS runner is requested only when | ||
| * a Linux job finds a Swift change under packages/native, so no other pull | ||
| * request waits for one. | ||
| */ | ||
|
|
||
| import fs from 'node:fs'; | ||
| import path from 'node:path'; | ||
|
|
||
| import {describe, expect, it} from 'vitest'; | ||
| import yaml from 'yaml'; | ||
|
|
||
| const root = path.resolve(import.meta.dirname, '../..'); | ||
| const ci = yaml.parse( | ||
| fs.readFileSync(path.join(root, '.github/workflows/ci.yml'), 'utf8'), | ||
| ); | ||
| const scope = ci.jobs['native-swift-scope']; | ||
| const swift = ci.jobs['test-native-swift']; | ||
| const step = (job, name) => | ||
| job.steps.find(candidate => candidate.name === name); | ||
|
|
||
| describe('native Swift routing', () => { | ||
| it('is joined by test', () => { | ||
| expect(ci.jobs.test.needs).toContain('test-native-swift'); | ||
| expect( | ||
| step(ci.jobs.test, 'Require expected test-owner outcomes').env, | ||
| ).toMatchObject({ | ||
| TEST_NATIVE_SWIFT_RESULT: '${{ needs.test-native-swift.result }}', | ||
| }); | ||
| }); | ||
|
|
||
| it('decides scope on Linux and asks for macOS only when Swift changed', () => { | ||
| expect(scope['runs-on']).toBe('ubuntu-slim'); | ||
| expect(swift.needs).toEqual(['check-scope', 'native-swift-scope']); | ||
| expect(swift['runs-on']).toBe( | ||
| "${{ needs.native-swift-scope.outputs.applies == 'true' && 'macos-15' || 'ubuntu-slim' }}", | ||
| ); | ||
| for (const candidate of swift.steps) { | ||
| if (candidate.uses || candidate.name?.startsWith('Build and test')) { | ||
| expect(candidate.if, candidate.name ?? candidate.uses).toBe( | ||
| "needs.native-swift-scope.outputs.applies == 'true'", | ||
| ); | ||
| } | ||
| } | ||
| }); | ||
|
|
||
| it('fails closed when the scope cannot be decided', () => { | ||
| expect(step(scope, 'Require successful scope classification').if).toBe( | ||
| "needs.check-scope.result != 'success'", | ||
| ); | ||
| expect(step(swift, 'Require a decided Swift scope').if).toBe( | ||
| "needs.native-swift-scope.result != 'success'", | ||
| ); | ||
| const decide = step(scope, 'Decide whether native Swift changed').run; | ||
| expect(decide).toContain( | ||
| 'git show "$BASE_SHA:.github/scripts/pr-scope-touches.sh"', | ||
| ); | ||
| // Only "out of scope" (exit 1) skips; unknown (2) runs the Swift work. | ||
| expect(decide).toContain('if [ "$scope" = 1 ]; then'); | ||
| }); | ||
|
|
||
| it('skips the Swift work on docsite-only and tooling-only changes', () => { | ||
| const decide = step(scope, 'Decide whether native Swift changed'); | ||
| expect(decide.env).toMatchObject({ | ||
| DOCSITE_ONLY: '${{ needs.check-scope.outputs.docsite_only }}', | ||
| TOOLING_ONLY: '${{ needs.check-scope.outputs.tooling_only }}', | ||
| }); | ||
| expect(decide.run).toContain( | ||
| 'if [ "$DOCSITE_ONLY" = true ] || [ "$TOOLING_ONLY" = true ]; then', | ||
| ); | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pins the comparison, but not the default
scope=2(ci.yml:769) or the pattern (ci.yml:775): changing the default toscope=1, or the pattern to one that cannot match a Swift path, leaves the whole.github/scriptssuite green while native Swift changes would skip the build. Asserting both, or running the step against a few fixture paths (Swift source,Package.swift, a newswift-ios-<n>/package, a moved-out.swift), would make the fail-closed promise mutation-sensitive.