[imdreamrunner]

One commit on main (3615956e2). This pull request now ships the touch flow the Lab prototype MobilePowerSearch ships today, including its refined touch filter flow: stacked steps, trailing remove actions, Clear all behind a confirmation that keeps read-only filters, an empty state with one centered Add filter, an unfocused Add filter search, fixed sheet chrome, and muted editor sections. The record it implements is component:PowerSearch DEC-3 as revised for that flow (FR10–FR21, FR15a, AR4–AR6, PR5). This pull request carries that record text and lifts its implementation-gap notes, except the date rows. The confirmation and the search-drag handling are Core's shared internal touch-sheet modules on main, which the Tokenizer's sheet also uses; this pull request imports them and adds no copy.

User need

On a compact touch screen, the PowerSearch field fights the software keyboard. When the tokenizer takes focus, the keyboard covers the half of the screen where the field menu and the editor popover open. The editor's Selector and Tokenizer then open more anchored layers inside a small popover, and each new token makes the field taller under the thumb. Builders who ship PowerSearch on phones have no supported touch surface. Today each product keeps the popover on touch or builds the flow itself.

Problem and solution fit

• experimental.presentation on PowerSearch takes 'popover', 'bottom-sheet' or 'adaptive':
  • 'popover' is the default: the tokenizer field and the editor popover, unchanged.
  • 'bottom-sheet' shows the touch surface on every device.
  • 'adaptive' shows the sheet on compact coarse-pointer screens and the popover otherwise. It resolves through the shared useAdaptivePresentation policy, so a PowerSearch and a Tokenizer on one page switch together. On the server and while hydrating, it is the popover.
• Trigger (PowerSearch.tsx): the field's box with display-only tokens and one button, which is the only tab stop. Its name is the label plus the visible content (WCAG 2.5.3). Disabled uses aria-disabled and stays focusable.
• Flow (PowerSearchBottomSheet.tsx, loaded on demand). The steps stack: each opens above the one that led to it, which stays open beneath, and a dismissal (Escape, scrim, swipe) closes only the top sheet and reveals the step beneath. No sheet has a Back action.
  • Filters: one row per filter. A row opens the value step on its filter, and a trailing "Remove {field} filter" button removes it in one tap; a one-tap (empty-valued) filter's row removes it. A fixed header holds Add filter (an icon button) and a fixed footer holds Clear all and Done, with only the rows scrolling between them. With no filter, the body is one empty state ("No filters applied") whose centered primary Add filter is the only action.
  • Clear all opens a confirmation ("Clear all filters?", "Clear filters" / "Keep filters"). Confirming removes the editable filters, keeps read-only ones (onChange(kept, 'remove', firstRemovedIndex)), leaves Filters open with focus on Add filter, and announces "All filters removed" there, or "Editable filters removed" while a read-only filter remains, joined with a changed result count. This matches the popover's Clear all on main (FR23, DEC-4). The handler closes the confirmation with flushSync, then moves focus and announces, as the Tokenizer's sheet does; Keep filters returns focus to Clear all.
  • Add filter: grouped field rows under "General" and each group's name, or the content search with inline suggestions. Its search takes no focus on open. A vertical touch drag on the rows moves focus off a focused search, so the keyboard leaves. ArrowDown and ArrowUp move between the content search and its suggestions through Core's shared list focus (useInternalListFocus), without wrapping. A field whose only operator takes no value adds at once and shows a plus, not a chevron. When Add filter is the entry point, its fixed footer holds Done.
  • Value step: an info sheet that stages operator, then value, and confirms from its footer (Cancel, and Add filter or Apply). It has no Remove. A lone editor sits on the sheet surface; with the Operator group above it, each section is a muted container. Choice rows have no dividers. The radio rows' one tab stop and arrow, Home and End moves come from Core's shared list focus (useInternalListFocus), and a row that takes focus from those keys is checked.
  • Focus after a step closes: the step sheets return focus, when their exit ends, to the control the step change named (FR16), falling back to the field's trigger when nothing was named. A closing sheet that holds focus keeps it until its exit ends, so this is what lands focus on Add filter after a creation commit in a real browser. A real-Chromium phone run checked Cancel from editing (the row), a row's remove action (the next row's remove action) and a creation commit (Filters' Add filter).
  • Commit from a direct entry: when Add filter was the entry point, Filters is not open beneath, so a commit opens it in the same update that closes the steps (FR15a). From Add filter, one sheet closes as one opens: BottomSheet's replace (component:BottomSheet FR10). From the value step, two sheets close: the stack's ordinary closes and open (FR5–FR9). Focus lands on Add filter and is still there after every motion has settled (FR16); a test asserts it after the sheets settle.
  • string_list and entity_list values edit through the public Tokenizer with experimental={{presentation: 'bottom-sheet'}}, whose sheet opens above the value step, saves with Save, and asks before it discards changes.
• Kept Core-only pieces: the value step edits a nested value with the popover's built-in NestedEditor; formatTokenValueText is the single source of a token's value text (the popover token, its FR24 name, and the sheet's Filters rows all read it), so the Filters rows read as the token does; catalog keys are under @astryx.powersearch.sheet.*; the adaptive swap and hasAutoFocus handling; every visible field lists, including a nested-only one.
• Touch targets: the header's Add filter and each row's remove button keep their drawn medium size. Under a coarse pointer, an invisible hit layer grows them to 44 px, using the coarse-only ::after pattern Core's clear button uses.

Current specification

• component:PowerSearch DEC-3, FR10–FR21, FR15a, AR4–AR6, PR5, as on main for the Lab flow. This pull request lifts the record's implementation-gap notes that the port makes true and records Core's element counts in DEC-3.
• component:PowerSearch FR23 and DEC-4 (on main): the popover's Clear all keeps read-only filters. The sheet's Clear all has the same semantics and the same catalog key.
• spec:AST-017 FR21 and FR27: the experimental boundary, the [experimental] changeset, and no new theming target.
• component:Selector FR4: the shared adaptive resolution.
• component:Tokenizer DEC-3: the list-value sheet.
• component:BottomSheet FR5–FR9 (the stack) and family:overlay-dismissal. The deprecated BottomSheetSwitcher is not used.

Public delta and caller burden

/** @experimental */
experimental?: {presentation?: 'popover' | 'bottom-sheet' | 'adaptive'};

• No new exports. No stable prop, default or type changes. packages/core/api-report.md gains exactly that one prop experimental? line.
• A caller that omits experimental gets the same render path, DOM and callbacks as main. The evidence is below.
• In the sheet presentation, menuWidth and tokenOverflowBehavior have no surface. Each warns once in development.
• @astryx.powersearch.sheet.* catalog keys are added. The sheet's Clear all reuses main's @astryx.powersearch.allFiltersRemoved and @astryx.powersearch.editableFiltersRemoved. No new theming target; the touch hit layer adds two private custom properties, documented in PowerSearch.doc.mjs.
• fieldInputFamily.test.tsx lists PowerSearch as pending family:input-fields FR10: its sheet trigger composes the Field box, and its stable ref and root styling props stay where they are until their own decision.

// No opt-in: unchanged
<PowerSearch config={config} filters={filters} onChange={setFilters} />

// Opt in: the sheet flow on compact touch screens, the field and popover elsewhere
<PowerSearch config={config} filters={filters} onChange={setFilters}
  experimental={{presentation: 'adaptive'}} />

Design and alternatives

DEC-3 records the chosen model and the rejected alternatives: steps that replace one another with Back actions, Remove in the value step's footer, and focusing Add filter's search on open.

What changed from this pull request's earlier flow, item by item against the Lab flow:

1. Steps stack and a dismissal reveals the step beneath (was: replace in place).
2. No Back on Add filter.
3. A trailing remove button per row, and tap-to-remove for empty filters (was: Remove in the value step's footer).
4. Rows carry the remove button, not a chevron.
5. empty-only fields add directly from their row, with a plus.
6. Clear all asks first, keeps read-only filters, keeps Filters open and announces there (was: removed everything and closed).
7. The empty state is an EmptyState with a centered primary Add filter, and the header action hides.
8. The content search is unfocused on arrival, with drag-to-dismiss of a focused search.
9. Fixed header and footer around a scroll viewport.
10. Muted containers only with more than one section.
11. Not done: dates. The value step keeps main's date editors in their sheet presentation, which read and write the UTC day, and tokens and rows show the token's date. The record keeps an implementation-gap note on FR11, FR12 and FR17 until the date-zone fixes land.
12. The value step is purpose="info" (was form).

Where Core differs from Lab on purpose: the empty-result title wording stays in Core's catalog ("No filters match your search"); a nested-only field lists; the icon actions meet 44 px through a hit layer. Lab's Clear all says "Editable filters removed" every time; Core says it only while a read-only filter remains.

Tokenizer: the two list-value editors render the public Tokenizer with its experimental.presentation, now on main; nothing internal to the Tokenizer is imported.

Evidence

Desktop does not regress. The popover presentation, adaptive on a mouse or a wide screen, and an absent experimental all behave as on main:

• Parity harness (not committed): it renders the popover presentation on main (3615956e2, this head's base) and on this head and records every DOM snapshot, the active element, and the onChange/onFocus/onBlur log at each step. It covers 9 prop sets, each with no filters and with 15 filters spanning every value type (including a stale and a read-only filter), plus scripted typeahead, pick, Escape, the token edit popover, remove, Backspace, Clear all, blur, content-search free text and the nested editor. The variants are experimental absent, {presentation: 'popover'}, and {presentation: 'adaptive'} with matchMedia matching nothing. Each is compared with main's render without experimental.
  • Result, on this head: 96 of 96 snapshots identical (branch vs main (absent) diffs: []), and the spoken announcements are the same messages in the same order for every variant. main's self-variance between two runs is empty.
  • The run covers the presentation swap. Its focus hand-off lives in the roots' callback refs (each presentation keys its root, so a swap remounts it), not in Effects: the detaching root notes held focus, the attaching root gives it to its primary control, and the sheet root's attach hides an editor popover left open and preloads the flow's chunk. The popover's editing state returns to idle in the render that sees the swap.
• Existing popover tests pass and none is changed or removed. PowerSearch.test.tsx gains one popover test (hasAutoFocus stays on the combobox across re-renders). PowerSearchEditPopover.test.tsx, PowerSearchValueEditor.test.tsx, PowerSearchFilterEditor.test.tsx, and the Tokenizer and BottomSheet suites are not edited.
• Real Chromium, fine pointer: the Experimental adaptive story at 1280×800 and at 390×844 without touch renders the tokenizer combobox and no sheet trigger. A token click opens the editor popover. 166 elements at rest and 334 with the editor open, the same as before this change.

Touch flow: real Chromium, static Storybook builds of main (Lab) and this head (Core), a 390×844 iPhone touch profile. Each pair shows the same state, Lab on the left and Core on the right:

State	Top dialog	Open dialogs	Lab vs Core
Field at rest with three filters	none	0	Same tokens and trigger; date text differs (item 11)
Filters	Filters	1	Same: Add filter icon button, rows with trailing remove, Clear all and Done at full width
Add filter from Filters	Add filter	2 (Filters inert)	Same: unfocused search, "General" and group headings, chevrons, a plus on the one-tap field
Value step, one operator	"Priority is"	3	Same: the choice rows on the sheet surface, Cancel and Add filter
Value step, several operators	Status	3	Same: Operator radios and the choice rows each in a muted section
Clear all confirmation	"Clear all filters?"	2	Same: destructive "Clear filters" above "Keep filters"
Filters with no filter	Filters	1	Same: "No filters applied" with one centered primary Add filter
Add filter entered directly	Add filter	1	Same: Done in the fixed footer, no Back
Content search, query with no match	Add filter	1	Same: the free-text suggestion lists
Field search, query with no match	Add filter	2	Same compact empty state; Core keeps its catalog title "No filters match your search"

• Lower sheets of the stack are inert and aria-hidden. Under the confirmation, Filters is blocked by the open modal.
• The remaining visible differences are the date text (item 11) and story data: Core's story config has no field groups and other field names.

Element counts (DEC-3, document.body.querySelectorAll('*'), coarse pointer, read when settled, on this head): 123 at rest, 313 Filters, 314 with Add filter above it, 332 with a choice-row value step above both, 349 with a list-value step, 420 with the Tokenizer's sheet above that, 373 with an edit step above Filters, 333 with the Clear all confirmation. Fine pointer: 166 at rest, 334 with the editor popover open. The record states them.

Bundle: PowerSearch.js loads PowerSearchBottomSheet.js only through import(), so a field that does not opt in does not carry the flow (PR5).

• Lazy graph imports Core directly (scripts/core-single-bundle.test.mjs). The value step reuses the popover's editors (FR17). The sheet gets PowerSearchValueEditor, NestedEditor and buildRelativeDateOptions from PowerSearch.tsx, whose graph already loads them for the popover, so the editors and the components they reach stay out of the lazily imported graph. The modules the sheet itself reaches import Core modules directly: TextInput, Field, RadioList, RadioListItem and useInputStatusIcon change only their import paths.
• Touch-only cost (architecture:component-style-authoring INV6), flagged and justified. Importing PowerSearch costs about 10 KB minified (about 3 KB gzip) more than on main. That is over the 2 KB gzip budget. Per module, minified: PowerSearch.tsx +3.2 KB, the shared English catalog +2.4 KB, PowerSearchValueEditor.tsx +1.5 KB with its catalog +0.7 KB, formatTokenValue.ts +1.5 KB with its catalog +0.3 KB, focus-ring styles +0.5 KB.
  • The trigger and its styles must render synchronously: they are the server markup for bottom-sheet and the first client render on a compact touch screen for adaptive. Loading them on demand would show no field until the chunk arrives. The swap hand-off and the adaptive latch belong with them.
  • The English catalog is one shared module that every component's fallback reads; the sheet's strings are entries in it.
  • PowerSearchValueEditor and formatTokenValue are the popover's own modules, which the value step and the Filters rows reuse so one value reads and edits the same way in both presentations (FR11, FR12, FR17). Their sheet branches cannot move into the chunk without forking the editor.
  • Nothing here is a touch primitive the shared internal touch modules provide: the sheet's drag and confirmation modules are those shared modules, and they load only with the flow.

Writing rubric results

Run over this pull request's change to docs/specs/components/PowerSearch/PowerSearch.spec.md. The record text is main's. On top of it:

• The implementation-gap notes are lifted from every sheet row except the date parts of FR11, FR12 and FR17, which now say what Core does instead.

• The verification row no longer points at the Lab suite.

• DEC-3 records Core's element counts in place of its implementation gap.

• PowerSearchBottomSheet.test.tsx and PowerSearch.ssr.test.tsx join verified_by, with frontmatter links for claims that source comments used to cite.

• R1 narration: none. The record describes the shipped behavior in the present tense.

• R2 research in the record: none. Measurements and runs stay in this description.

• R3 evidence naming a change: none.

• R4 rejected alternatives: unchanged one-line entries in DEC-3.

• R5 pull request or issue references: none.

• R6 ruled questions still listing options: none.

Scope

• One capability is added.
• Unrelated fixes, cleanup, and policy changes were removed or split.
• Consumer docs (PowerSearch.doc.mjs: the prop with stability: 'experimental', an example, and the zh and dense variants), four stories, focused tests and the [experimental] changeset ship with the feature.
• Public text and artifacts contain no internal Meta context.

Testing

• vitest, scoped:
  • packages/core/src/PowerSearch, internal, RadioList, TextInput, Field, hooks, Tokenizer, BottomSheet, Dialog, Tooltip, Token, the derived-var registry test and Lab's MobilePowerSearch: 110 files, 2,880 tests passed on main 4e495ec5e; on 3615956e2 (this head's base), the PowerSearch, Button, BottomSheet, Tokenizer, internal and Lab MobilePowerSearch suites: 38 files, 1,383 tests passed, and Core typecheck passes. PowerSearchBottomSheet.test.tsx has 172 tests.
  • scripts/core-single-bundle.test.mjs: 3 of 3 pass against a fresh Core build.
• Core pnpm build and pnpm typecheck: exit 0.
• ASTRYX_STRICT_LINT=1 eslint over every changed file: 0 errors. prettier --check over every changed file: clean.
• pnpm check:repo (includes check:knowledge, check:changesets, check:i18n-runtime, check:i18n-catalog, check:sync): exit 0. node scripts/sync-exports.js --check: up to date.
• pnpm check:knowledge: aligned.
• git diff --check: clean.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
astryx	Ready	Preview	Nov 3, 2026 1:27pm UTC

[astracat-bot]

AI review status for this pull request.

Review status	Updated
🟢 Reviewed (for maintainers only)	Nov 3, 2026, 1:36 PM UTC

[astracat-bot]

This adds an opt-in touch flow for PowerSearch, but it cannot be approved yet: the head writes DEC-3 and FR10–FR21 into the current component:PowerSearch record, and an engineering owner still has to decide those requirements, including FR17/FR21's reliance on the Tokenizer sheet requirements from #7977 that are not on main yet. The approval on #8000 covers that pull request's head, not this one; an engineering owner records the decision here by commenting /approve-spec 11fb87a50dafe3d00fb7f54d4151c577eaa3ace9 on this pull request, and the author may do so as an engineering owner. Whatever that decision is, these fixes are needed:

• Put data-testid on the sheet trigger (today it moves from the combobox input to a div), and drop the family:input-fields membership and FR10 citation, since that family's record excludes PowerSearch.
• Show date-only values without a time of day in the Filters rows (the forced story shows Mar 9, 2024, 7:00 PM).
• Align FR16 (focus after a value suggestion commits) and FR20 (the relative-date row labels) with the code, and declare the stable result-count fix in its own [fix] Changeset.
• Split the 4,800-line change, for example by dropping the carried spec commit once #8000 lands and moving the stable fix out, or explain why it cannot be split.

[Automated review]

[astracat-bot]

In the popover presentation data-testid reaches the combobox input (through Tokenizer); here it lands on the control-box div, so a test id changes element when an adaptive field switches. Putting it on the trigger <button> keeps it on the field's primary control in both presentations.

[astracat-bot]

formatFilterValue formats every date_absolute with hour and minute, so a date-only filter (isDateOnly: true) reads Mar 9, 2024, 7:00 PM in this row while its token says Mar 9, 2024. Could the row format date-only values without the time?

[astracat-bot]

With a controlled parent this moves focus to the new filter's row after a value suggestion commits, while FR16 says a creation commit focuses Add filter. Either the code or FR16 should change so they agree.

[astracat-bot]

family:input-fields lists PowerSearch as excluded ("higher-level compositions that consume member behavior"), and its FR10 sends data-* to the primary semantic control, which this record's prop-target paragraph does not follow. Drop the membership and the FR10 citation, or amend that family first.

[astracat-bot]

The StrictMode-safe result count changes the stable presentation too; spec:AST-017 FR22 keeps that out of an [experimental] entry, so it needs its own [fix] Changeset.

[astracat-bot]

This adds an opt-in touch flow for PowerSearch, but it cannot be approved yet: the head writes DEC-3, FR10–FR21, AR4–AR6, PR5 and AV5–AV6 into the current component:PowerSearch record, and an engineering owner has to decide those requirements, including FR17/FR21's reliance on the Tokenizer sheet requirements from #7977 that are not on main yet. An engineering owner records that decision by commenting /approve-spec followed by this head's full commit SHA on this pull request, and the author may do so as an engineering owner. Whatever that decision is, these still need changes:

• Make a date-only filter show the same day on the trigger and in the Filters row; today the token formats in the device's time zone and the row in timezoneID.
• Announce the sheets' empty-result messages as AR6 says, or drop that clause from AR6.
• Split the 5,181-line change, for example by dropping the carried record change once #8000 lands and moving the stable result-count fix out, or explain why it cannot be split.

[Automated review]

[astracat-bot]

The row formats a date-only value in timezoneID, but the trigger's token (PowerSearch.tsx:430) formats the same instant with no time zone, so it follows the device. With timezoneID America/Los_Angeles on a Tokyo device, the forced story's token says Mar 10, 2024 while this row says Mar 9, 2024. Formatting both the same way (here, or in the token as its own [fix]) keeps one filter on one day, and the boundary test could assert the token too.

[astracat-bot]

Nothing announces the empty-result messages: "No filters match your search" and "No results found" render as plain Text with no live region (PowerSearchBottomSheet.tsx:1320–1334). Either deliver them through the flow's polite region or drop this clause from AR6.

[github-actions]

PR Analysis Report

🔎 Preview · 777edfe

Storybook · Sandbox · built from this PR's head

Modified components

Component	Size	LoC	Visual · A11y · RTL
PowerSearch · Storybook	🔴 191.7 kB (+6.1 kB) · 21.6 kB CSS (+965 B)	6,789 (+2,811)	— · — · —
lab/MobilePowerSearch	216.5 kB (+1.3 kB) · 1.2 kB CSS (0)	—	— · — · —
richtext/RichTextEditor	278.3 kB (+403 B) · 2.6 kB CSS (0)	—	— · — · —

33 more components

Component	Size	LoC	Visual · A11y · RTL
lab/EmojiPicker	70.8 kB (+399 B) · 722 B CSS (0)	—	— · — · —
lab/ListInput	81.7 kB (+393 B) · 1.6 kB CSS (0)	—	— · — · —
lab/Comments	233.4 kB (+391 B) · 2.5 kB CSS (0)	—	— · — · —
richtext/RichTextEditorToolbar	223.2 kB (+391 B) · 454 B CSS (0)	—	— · — · —
lab/CommentComposer	103.2 kB (+386 B) · 1.9 kB CSS (0)	—	— · — · —
lab/TransferList	74.7 kB (+386 B) · 1.7 kB CSS (0)	—	— · — · —
lab/MobileTokenizer	102.0 kB (+385 B) · 880 B CSS (0)	—	— · — · —
lab/TransferListSelector	81.1 kB (+378 B) · 1.9 kB CSS (0)	—	— · — · —
lab/CommentThread	228.1 kB (+372 B) · 2.4 kB CSS (0)	—	— · — · —
DateTimeInput	159.9 kB (+118 B) · 17.1 kB CSS (0)	—	— · — · —
DateInput	103.8 kB (+112 B) · 15.3 kB CSS (0)	—	— · — · —
Selector	77.7 kB (+41 B) · 15.7 kB CSS (0)	—	— · — · —
CheckboxList	43.5 kB (+39 B) · 8.6 kB CSS (0)	—	— · — · —
NumberInput	55.2 kB (+39 B) · 11.2 kB CSS (0)	—	— · — · —
ComplexSelector	55.8 kB (+33 B) · 11.1 kB CSS (0)	—	— · — · —
MultiSelector	73.3 kB (+31 B) · 15.2 kB CSS (0)	—	— · — · —
InputGroup	42.1 kB (+28 B) · 8.4 kB CSS (0)	—	— · — · —
DateRangeInput	70.1 kB (+15 B) · 11.9 kB CSS (0)	—	— · — · —
TimeInput	90.5 kB (+13 B) · 14.3 kB CSS (0)	—	— · — · —
FileInput	53.9 kB (+12 B) · 10.7 kB CSS (0)	—	— · — · —
Pagination	86.6 kB (+1 B) · 16.0 kB CSS (0)	—	— · — · —
FieldLabel	36.1 kB (0) · 5.9 kB CSS (0)	—	— · — · —
Tokenizer	70.8 kB (0) · 17.1 kB CSS (0)	—	— · — · —
Typeahead	63.1 kB (0) · 11.8 kB CSS (0)	—	— · — · —
lab/ChatReactionBar	65.5 kB (−1 B) · 1.1 kB CSS (0)	—	— · — · —
Markdown	145.4 kB (−2 B) · 18.3 kB CSS (0)	—	— · — · —
lab/ChatEmojiPicker	65.0 kB (−6 B) · 773 B CSS (0)	—	— · — · —
RadioListItem	51.4 kB (−10 B) · 10.1 kB CSS (0)	—	— · — · —
TextInput · Storybook	53.0 kB (−11 B) · 11.0 kB CSS (0)	420 (+1)	— · — · —
Slider	89.1 kB (−19 B) · 9.4 kB CSS (0)	—	— · — · —
TextArea	47.2 kB (−22 B) · 9.9 kB CSS (0)	—	— · — · —
Field	39.9 kB (−1.6 kB) · 7.4 kB CSS (−955 B)	—	— · — · —
RadioList	41.4 kB (−1.6 kB) · 7.4 kB CSS (−959 B)	—	— · — · —

Package size: @astryxdesign/core 6.18 MB packed (+70.2 kB); no new dependencies.

API changes: core +1 · ~0 · −0

Committed API report behind this build: core 50 rows; run pnpm api:report.

1 API change (advisory)

	Package	Where	Signature	Usage
+	core	. · Components · component PowerSearch	prop experimental?: { presentation?: 'popover' | 'bottom-sheet' | 'adaptive' } @experimental	<PowerSearch experimental="popover" />

Wide change (shared styles: packages/core/src/theme/derivedVarRegistry.test.ts): add ci:run-visual, ci:run-a11y or ci:run-rtl to run them.

---

_{Generated by PR Enrichment workflow | View full report}

[astracat-bot]

The touch sheet flow follows the current component:PowerSearch DEC-3 contract, but two things need changes before it can be approved. At 8,512 authored lines it needs splitting: land the formatTokenValue.ts extraction on its own, then put the sheet flow up as a stack that lands together (for example the trigger, latch and Filters sheet; Add filter with the content search; the value step), each with its tests. Separately, the Filters rows are keyed by position (PowerSearchBottomSheet.tsx:1519), so when the parent reorders the filters or removes one above the focused row, focus moves to a different filter; keying rows by filter identity, with tests for both cases, fixes it.

[Automated review]

[astracat-bot]

Keying rows by ${index}-${filter.field}-${filter.operator} remounts the focused row when the parent reorders the filters or removes one above it, and the recovery effect then focuses the row at the old index: with focus on "Author is Ada" in [Status, Author, Priority], dropping Status lands focus on "Priority is P1". Keying each row by filter identity (a per-object id from a WeakMap, falling back to filterSignature for clones), with tests for a reorder and a removal above the focused row, keeps focus on the filter the person was on.

[astracat-bot]

Recommending approval: the touch sheet flow matches the current component:PowerSearch contract (DEC-3, FR10–FR21), the stable popover presentation is unchanged, and the focused tests, typecheck and a phone-sized Chromium run all hold up. The size is accepted here because the record defines the sheet presentation as one complete flow, so it cannot land in parts without shipping an option that breaks its own requirements. The two earlier blockers are resolved: the StrictMode result-count fix is already on main, and Filters rows are now keyed by filter identity, with tests. What remains is the repository's spec-owner approval for the small record update.

[Automated review]

[imdreamrunner]

/approve-spec f8c4a15

[astracat-bot]

Changes requested. The touch flow follows the current component:PowerSearch contract (DEC-3, FR10–FR21), and the PowerSearch and Tokenizer tests, the Core typecheck and lint all pass on this head. Three things need fixing first:

• Move the presentation-swap focus hand-off in PowerSearch.tsx (the per-commit useLayoutEffect at line 651 and the swap Effects at lines 678 and 793) into callback refs, as Tokenizer.tsx now does with handOffFocusRef and wrapperCallbackRef (architecture:react-component-runtime INV2, INV6).
• Replace formatSharedList in formatFilterValue.ts with Core's shared useListFormatter, which already owns the same narrow-conjunction Intl.ListFormat policy, and delete the copy.
• Importing PowerSearch now loads about 3.1 KB more gzip JavaScript for the touch presentation, over the 2 KB touch-only budget in architecture:component-style-authoring INV6, so either move that code into the lazy chunk or the shared touch modules, or justify the cost in the description.

The size is fine as one implementation of DEC-3, and the record edits are owner-approved on this head.

[Automated review]

[astracat-bot]

This layout effect reads document.activeElement after every commit of every PowerSearch, and the Effect at line 678 then moves focus when the presentation flips. On main, Tokenizer runs the same hand-off from callback refs (handOffFocusRef and wrapperCallbackRef in Tokenizer.tsx). The detaching control notes focus while it is still in the document, which covers the pre-hydration autofocus case, and the attaching control takes it. Giving PowerSearch's root wrapper, trigger and Tokenizer handle that pattern removes both Effects (architecture:react-component-runtime INV2, INV6).

[astracat-bot]

packages/core/src/i18n/useListFormatter.ts already builds this exact narrow-conjunction Intl.ListFormat and keeps raw list formatting in one place (architecture:internationalization INV8). Passing useListFormatter()'s function from the sheet into formatTokenValueText lets this copy go.

[astracat-bot]

Non-blocking: a stray *. is left here from a removed citation. @default true reads best on its own JSDoc line (the same leftover appears at powerSearchSheetUtils.ts:167 and :194).

[imdreamrunner]

/approve-spec 796dd9d

[astracat-bot]

Changes requested. The record edits for the stacked touch flow are owner-approved on this head, so what remains is implementation and evidence work:

• Keep Core renderable from a single esbuild bundle: the lazily imported sheet graph now reaches modules that import Core barrels, so scripts/core-single-bundle.test.mjs fails and an app that bundles Core without code splitting throws before rendering List and Item; import those modules directly instead.
• Make the other two failing tests pass: document or restructure the new --_power-search-sheet-hit-* custom properties that fail derivedVarRegistry.test.ts, and rebase onto main so the Clear all confirmation test drives a full backdrop press, since a bare click no longer dismisses an info Dialog there.
• FR15a relies on component:BottomSheet FR10's same-update replace when a direct-entry creation commits from the value step, but two sheets close on that path, which FR10 excludes, so amend FR15a (or close Add filter in an earlier update) and assert focus after the sheets settle.
• Move the presentation-swap focus hand-off in PowerSearch.tsx (the per-commit useLayoutEffect and the swap Effects) into callback refs, as Tokenizer.tsx does with handOffFocusRef and wrapperCallbackRef.
• Announce and place focus after Clear all's confirmation in its action handler, as TokenizerBottomSheet.tsx does in closeClearConfirmation, instead of an Effect that waits for the dialog to close.
• Replace formatSharedList in formatFilterValue.ts with Core's shared useListFormatter and delete the copy.
• Importing PowerSearch now loads about 3.1 KB more gzip JavaScript that only the sheet presentation runs, over the 2 KB touch-only budget, so move it into the lazy chunk or the shared touch modules, or justify the cost in the description.
• Rewrite the description: it still says the flow has no new behavior, that DEC-3 is unchanged and that every existing test passes, while this head stacks the steps, adds a confirmed Clear all, reverses two rejected alternatives and has three failing test cases.

A few comments in PowerSearchBottomSheet.tsx and the prop's JSDoc still describe the replaced flow; worth refreshing while you are there.

[Automated review]

[astracat-bot]

--_power-search-sheet-hit-inset and --_power-search-sheet-hit-content fail derivedVarRegistry.test.ts ("PowerSearch: all source vars are in doc file"): document them in PowerSearch.doc.mjs or reach the coarse-pointer hit area without new custom properties.

[astracat-bot]

For a creation committed from the value step after a direct-entry Add filter, two sheets close (the value step and the covered Add filter) while Filters opens. component:BottomSheet FR10 replaces only when exactly one sheet closes and one opens, and keeps the ordinary push and pop motion and focus return otherwise, so this sentence promises a replace that does not apply on that path.

[astracat-bot]

This layout effect reads document.activeElement after every commit of every PowerSearch, and the swap Effects below move focus when the presentation flips. Tokenizer.tsx does the same hand-off from callback refs (handOffFocusRef, wrapperCallbackRef); the same shape here removes the per-commit read (architecture:react-component-runtime INV2, INV6).

[astracat-bot]

Clear all's announcement and focus are one event's work. TokenizerBottomSheet.tsx closeClearConfirmation does it in the handler: flushSync the close, then focus and announce. handleClearAll can do the same, with no Effect waiting on isClearConfirmationOpen.

[astracat-bot]

This is the narrow-conjunction Intl.ListFormat that i18n/useListFormatter.ts owns ("Raw Intl.ListFormat construction stays centralized in this hook"). Pass useListFormatter()'s function into formatTokenValueText and delete this copy.

[astracat-bot]

On the merge with main this click no longer dismisses the confirmation: main dismisses an info Dialog only on a press that starts and ends on the backdrop (family:overlay-dismissal FR10), and CI's test-ui (3/4) fails at line 1620. Drive a full pointer press on the backdrop after rebasing.

[imdreamrunner]

/approve-spec fd60b07

[astracat-bot]

Changes requested. The stacked touch flow matches the component:PowerSearch record edits an engineering owner approved on this head, and most earlier findings are fixed; two things remain:

• CI lint fails because Prettier reformats the dependency array at PowerSearch.tsx:1402–1407; running pnpm exec prettier --write packages/core/src/PowerSearch/PowerSearch.tsx fixes it.
• The popover reset on a presentation swap still runs from an Effect at PowerSearch.tsx:784–790; reset the state during render as autoFocusState does and hide the layer from the detaching root's callback-ref cleanup (:696–703), so the Effect can go.

Two small follow-ups are optional: DEC-3 records 333 elements with Filters open, while the head reads 313 because the Clear all confirmation mounts only when it opens, and a few new comments carry stray *. lines or a stale "offers Remove".

[Automated review]

[astracat-bot]

CI lint fails here: Prettier puts this dependency array on one line ([announce, handleFieldFocus, isSheetOpen, isSheetPresented]). Run pnpm exec prettier --write packages/core/src/PowerSearch/PowerSearch.tsx.

[astracat-bot]

This Effect resets popover state and hides the layer on the presentation swap, and copies popoverState into wasPopoverOpenRef after every commit of every PowerSearch. The swap is the popover root detaching, and its callback-ref cleanup at :696–703 already runs exactly then. Record wasPopoverOpenRef in setPopoverState, then do the reset and popover.hide() in that cleanup, or reset during render with the previous-value pattern autoFocusState uses. The Effect can then go (architecture:react-component-runtime INV2, INV6).

[imdreamrunner]

/approve-spec 63c355f

[astracat-bot]

Changes requested: one shared-path fix remains. An engineering owner approved this head's record edits, and both earlier blockers (the Prettier failure and the popover-reset Effect) are fixed.

• ChoiceRows in PowerSearchBottomSheet.tsx (lines 599–634) hand-rolls arrow, Home and End roving focus for the enum and date_relative radio rows, which Core already owns in useInternalListFocus (as SegmentedControl uses it): call the shared hook, check the row that takes focus from inside the group, and delete the local handler and manual tabIndex.

Non-blocking: a stray *. before @default true in PowerSearchEditPopover.tsx, and the SheetConfirmation and useDismissSearchOnTouchDrag headers name consumers that do not use them.

[Automated review]

[astracat-bot]

This hand-rolls the roving radio focus (arrows, Home, End, one tab stop) that Core already owns in useInternalListFocus (hooks/useListFocus.ts); SegmentedControl uses it for its radio group with selection following focus. Calling the shared hook here, and checking the row that takes focus from inside the group, keeps one path for fixes such as its tab-stop repair and right-to-left key mapping; the local handler and the manual tabIndex can then go.

[imdreamrunner]

/approve-spec de2e652

[astracat-bot]

Changes requested: two implementation fixes remain. An engineering owner approved this head's record edits, and ChoiceRows now uses the shared list focus.

• The content-search searchbox and suggestion rows in PowerSearchBottomSheet.tsx (lines 2174–2179 and 2226–2251) move focus with hand-written ArrowUp/ArrowDown handlers, a list-focus concern Core already owns in useInternalListFocus, which this component already calls for its choice rows: drive the searchbox and the rows through one useInternalListFocus call (extending the hook if it cannot take the searchbox) and delete the local handlers.
• The chunk preload in PowerSearch.tsx (lines 614–618) runs in an Effect, but it only fires when the sheet root attaches, and handOffFocusRef already runs on that attach: call loadPowerSearchBottomSheet() there when isSheetRoot is true and remove the Effect.

Non-blocking: the SheetConfirmation and useDismissSearchOnTouchDrag headers name consumers that do not use them, and the hasAutoFocus comment above autoFocusState could be cut to its reason.

[Automated review]

[astracat-bot]

This hand-rolls ArrowUp/ArrowDown focus across the suggestion rows (and the searchbox's ArrowDown branch at line 2174 does the same), while this component already calls useInternalListFocus for ChoiceRows. Core owns linear list focus there (architecture:react-component-runtime INV16). Could one useInternalListFocus call cover the searchbox and the rows (orientation: 'vertical', wrap: false, no roving tab index so the rows stay in the Tab order), with Enter kept in the searchbox handler?

[astracat-bot]

isSheetPresentation turns true only when the key="sheet" root attaches, and handOffFocusRef (line 761) already runs on that attach and computes isSheetRoot. Calling void loadPowerSearchBottomSheet() there when isSheetRoot is true starts the preload at attach and removes this Effect; the call is idempotent.

[astracat-bot]

Non-blocking: on main the Tokenizer sheet confirms with AlertDialog (TokenizerBottomSheet.tsx:937), and nothing here discards a draft. Suggest: "Core-internal; the PowerSearch sheets use it for Clear all. Not a public export."

[astracat-bot]

Non-blocking: only PowerSearch's Add filter sheet calls this. Suggest: "Core-internal; PowerSearch's Add filter sheet uses it. Not a public export."

[astracat-bot]

Non-blocking (architecture:knowledge-contracts INV29): 14 lines with sentences over 25 words. Suggest: "A swap remounts the field's control, and autoFocus would take focus from elsewhere on the page. Only the first control keeps autoFocus. The roots' callback refs hand over focus the field held."

[imdreamrunner]

/approve-spec 3d1186d

[astracat-bot]

Changes requested: two fixes remain. An engineering owner approved this head's record edits, and both findings from the previous round are fixed (the content search now uses the shared list focus, and the chunk preload runs in the sheet root's callback ref).

• PowerSearchBottomSheet.tsx decides whether Filters stays open beneath Add filter, and whether Add filter shows Done, from fieldPickerOriginRef.current read during render (lines 1215 and 2332) and written during render by entryStep (lines 930–938), which architecture:react-component-runtime INV4 does not allow: keep the origin in state beside step and derive isFieldPickerDirectEntry from it.
• The sheet's Clear all announces "All filters removed" from a new @astryx.powersearch.sheet.filtersCleared key (line 1637) that duplicates the existing @astryx.powersearch.allFiltersRemoved the popover uses, so locales and caller overrides can word one outcome two ways: use allFiltersRemoved and delete the new key.

Non-blocking: the handOffFocusRef comment in PowerSearch.tsx (lines 728–743) could be cut to its reason in a few short sentences.

[Automated review]

[astracat-bot]

This reads fieldPickerOriginRef.current during render to decide whether Filters stays open beneath Add filter (and, at line 2332, whether Add filter shows Done), and entryStep writes the ref during render. architecture:react-component-runtime INV4: "A ref mutation MUST NOT be the sole source for a value later read to produce React-rendered output." Keep the origin in state beside step (set together in openFieldList and the open adjustment) and derive this from it.

[astracat-bot]

@astryx.powersearch.sheet.filtersCleared has the same English and meaning as the existing @astryx.powersearch.allFiltersRemoved, which the popover's Clear all uses; with two keys, locales and caller overrides can word this outcome differently in the two presentations. Use t('@astryx.powersearch.allFiltersRemoved') here, as the line above reuses editableFiltersRemoved, and drop the new key from en.json.

[imdreamrunner]

/approve-spec 1920c3f

[astracat-bot]

Changes requested: one fix remains. An engineering owner approved this head's record edits, the touch sheet flow follows component:PowerSearch FR10–FR21, and both fixes the previous review asked for are in (the Add filter origin is now state, and Clear all speaks the shared "All filters removed" message).

• The new useLayoutEffect at PowerSearchBottomSheet.tsx:997–1001 clears the pending focus target when the flow closes without naming an external system (architecture:react-component-runtime INV2, INV3); clear the target in closeFlow and in the step Effect at :1144 when step is null, delete the Effect, and add a test that reopens the flow with a stale target pending.

Non-blocking: several new source comments run past INV29's sentence length, and the comment at PowerSearchBottomSheet.tsx:1823–1826 still says the Operator group leaves nested operators out.

[Automated review]

[astracat-bot]

This Effect does the flow's closing work and synchronizes no external system (architecture:react-component-runtime INV3: "A new or changed Effect MUST name the external system it synchronizes"). Every close already reaches code that can drop the target: closeFlow (:1003) for Done and the bottom sheet's dismissal, and the step Effect at :1144, which runs in the commit where any close sets step to null, the disabled close included. Suggest deleting this Effect, clearing pendingSheetFocusRef in closeFlow, and in the step Effect: if (step == null) { pendingSheetFocusRef.current = null; return; }. A test that reopens the flow with a target pending would pin it.

[astracat-bot]

Non-blocking: getVisibleOperators returns every operator, so the Operator group lists nested operators too, and "a nested one with no Editor override" no longer happens. Suggest: "The title names the operator when the step shows no Operator group."

[imdreamrunner]

/approve-spec c8a9d39

[astracat-bot]

Changes requested: one focus fix remains. An engineering owner approved this head's record edits, the close Effect from the previous round is gone, and the new reopen test covers that case.

• PowerSearchBottomSheet.tsx clears pendingRemovalFocusRef only for a row target (lines 1069–1073), so after the last editable filter is removed, a later Apply, Cancel or direct add in the same flow focuses the row's "Remove … filter" button instead of the row, against component:PowerSearch FR16; carry the removal intent on the pending target instead of a separate ref, and add a test for that sequence.

Non-blocking: a few added comments still run past INV29's sentence limits; see the inline suggestion.

[Automated review]

[astracat-bot]

Blocking (FR16): this is the only place pendingRemovalFocusRef is cleared. A removal whose target is manager-add (line 1553, the last editable filter removed) returns at line 1023 with the flag still set, so the next manager-filter target in the same flow (Apply at 1391, Cancel at 1701, a direct add at 1446 or 1500) focuses [data-sheet-remove] instead of the row. Reproduced: remove the only filter, add Status is Closed, open its row, Cancel → focus is on "Remove Status filter". Suggest carrying the intent on the target ({type: 'manager-filter', …, focusesRemoveAction: true} from handleRemoveFilter) and deleting the ref, plus a test for this sequence.

[astracat-bot]

Non-blocking (INV29): this is one 78-word sentence. Suggested: "Where the locale writes Latin digits and a . decimal mark, use the token's own text, String(value). Elsewhere, use the locale's digits and decimal mark, with no grouping and no rounding."

[imdreamrunner]

/approve-spec bde719c

[astracat-bot]

Recommending approval. The touch sheet flow behind experimental.presentation follows the current component:PowerSearch contract (FR10–FR21), the record edits on this head are owner-approved, and the earlier focus issue is fixed: after the last editable filter is removed, Apply, Cancel and a direct add now return focus to the filter's row rather than its remove button.

Before merging, rebase onto main: #9687 has since added PowerSearch FR24 and conflicts with this branch in PowerSearch.spec.md and PowerSearch.tsx, so the rebased head will need a fresh /approve-spec.

Two optional comment tidy-ups are noted inline.

[Automated review]

[astracat-bot]

Non-blocking (architecture:knowledge-contracts INV29): loadPowerSearchBottomSheet makes a new promise on every call, so "One import promise" is not quite true; only the module import is shared. Suggested:

// The preload and the lazy element share one module import. The sheet
// presentation preloads the chunk when it becomes active, so the first press
// does not wait for the network.

[astracat-bot]

Non-blocking (INV29): the first sentence runs to 58 words. Suggested:

// The last focused row index in the Filters or Add filter sheet. A removed
// element fires no blur, so the effect below reads this index to re-home focus.

[imdreamrunner]

/approve-spec 2584467

[astracat-bot]

Changes requested. The touch sheet flow follows the current component:PowerSearch contract, the record edits are owner-approved on this head, and the rebase onto FR24 keeps the popover token's text and accessible names unchanged. One fix remains:

• After Apply on an edited filter, or after adding a filter from Add filter opened over Filters, focus ends on the Filters sheet itself instead of the edited row or the header's Add filter that FR16 requires, because the flow focuses the sheet beneath while the closing step's modal dialog still blocks it (PowerSearchBottomSheet.tsx:1131–1147, :2350); hand that target to the closing sheet's focus return (finalFocusRef) and cover Apply and a create commit with a real-browser test, since the jsdom showModal stub never blocks the sheet beneath.

Two optional comment tidy-ups are noted inline.

[Automated review]

[astracat-bot]

Blocking (FR16). In a real browser this step's dialog is still the topmost :modal dialog during its exit, so the Effect at lines 1141–1147 cannot focus the Filters row or Add filter beneath it (focus() does not take until the exit ends). The sheet then returns focus here, to the trigger, which is outside Filters, and BottomSheet falls back to the Filters panel: after Apply and after a create commit, focus ends on div[tabindex=-1] instead of the edited row or the header's Add filter. Passing a ref the flow points at its pending target (and at the trigger only when the flow ends) lets BottomSheet's own return land there.

[astracat-bot]

Non-blocking (INV29): loadPowerSearchBottomSheet makes a new promise on every call; only the module import is shared. Suggested: "The preload and the lazy element share one module import."

[astracat-bot]

Non-blocking (INV29): this opens with a 58-word sentence. Suggested: "The last focused row index in the Filters or Add filter sheet. A removed element fires no blur, so the effect below reads this index to re-home focus."

[imdreamrunner]

/approve-spec 777edfe

[astracat-bot]

Approval recommended. The touch sheet flow behind experimental.presentation follows the current component:PowerSearch contract, the record edits are owner-approved on this head, and the focus fix now lands focus where FR16 says after Apply and after adding a filter, in a real browser as well as in the new test. Omitting experimental keeps today's field and popover.

Nothing blocks. Three optional comment rewrites are noted inline.

[Automated review]

[astracat-bot]

Optional (comment style): the first sentence runs to about 45 words, and in Chromium focus sits on the page body during the closing sheet's exit rather than staying in it. A shorter version that keeps only the reason:

// A closing modal sheet blocks focus on the sheet beneath until its exit
// ends. The closing step sheets then return focus to the control the step
// named, else to the trigger.

[astracat-bot]

Optional (comment accuracy): loadPowerSearchBottomSheet returns a new promise on every call; only the module import is shared. Suggested: "The preload and the lazy element share one module import."

[astracat-bot]

Optional (comment style): the opening sentence runs to 58 words. Suggested: "The last focused row index in the Filters or Add filter sheet. A removed element fires no blur, so the effect below reads this index to re-home focus."