Repository navigation
spec(AST-099): one shared on-screen keyboard module owns measurement and keyboard riding #8304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
b9110ed
spec(AST-099): one shared on-screen keyboard module measures the keyb…
cixzhang 90e83f3
spec(AST-099): the keyboard height stays internal; consumers apply th…
cixzhang 5c9eee7
spec(AST-099): observable contract with the mechanism in react-compon…
cixzhang d533424
spec(AST-099): layer geometry stays with AST-059; Lab conformance in …
cixzhang 18b235a
spec(AST-099): height lives only in the hook; Lab conformance agrees …
cixzhang 73e9917
spec(AST-099): FR8 in FR6 terms with Firefox for Android; INV11 bans …
cixzhang 2200b18
spec(AST-099): keyboard motion uses transform only, with one layout c…
cixzhang 40a306d
spec(AST-099): keyboard motion is one compositor animation to the pre…
cixzhang 0ed980b
spec(AST-099): one published transition every consumer rides in sync
cixzhang 94ce1d5
spec(architecture): INV11 wording for the height and transition
cixzhang 5d81b92
spec(AST-099): observable ride in FR3, transition mechanism in INV11;…
cixzhang 5e05908
spec(AST-099): name Firefox for Android in platform lines and OQ1; IN…
cixzhang b46535c
spec(AST-099): name the Core keyboard module; DEC-2 Chrome for Androi…
cixzhang 9e6c93e
spec(AST-099): Chrome on Android rides the keyboard smoothly (DEC-2 a…
cixzhang 592d352
spec(AST-099): FR8 names Chrome's keyboard report, scopes the ride to…
cixzhang 3c9ad90
spec(AST-099): FR8 covers any browser that reports the keyboard; redu…
cixzhang 1926fd9
spec(AST-099): FR1, FR3, INV11 and platform lines accept FR8 wherever…
cixzhang 986dad0
spec(AST-099): Firefox for Android row proves FR2–FR5 states
cixzhang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This no-ride rule now conflicts with
spec:AST-099FR8, which requires every keyboard-aware surface in Chrome on Android to ride; the FR2 measurement prescribed a few lines below is also switched off there by FR6. Whichever way the owner decides, the two records need to agree.