Repository navigation
spec(AST-094): only a gesture's motion springs; other motion plays the theme's tokens #9706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
a8a805b
spec(AST-094): gesture-driven motion plays a spring on every pointer
cixzhang 25af4a1
spec(AST-094): list the motion FR44 moves, by component
cixzhang 748cb56
spec(AST-094): number the gesture motion rule FR45, since FR44 is taken
cixzhang b9decfd
Merge main into spec/gesture-motion-springs; keep touch exits as they…
cixzhang 4a89431
spec(AST-094): name the two approved springs FR45 keeps, use the them…
cixzhang 22e080d
spec(AST-090, AST-094): a touch exit a tap, key or program starts pla…
cixzhang 5aa0e0f
spec(AST-094): name the animator's animate among the kept springs, an…
cixzhang c3c695b
spec(AST-094, AST-090): exempt Reduce Motion substitutions and busy l…
cixzhang 6a8960b
Merge main into spec/gesture-motion-springs; keep AlertDialog's touch…
cixzhang e540dba
spec: the animator's value mode follows its channels' timing; fix Pro…
cixzhang 11f209e
spec: INV15's check follows its channels' timing; AlertDialog and Swi…
cixzhang 47ab836
Merge main into spec/gesture-motion-springs; tap-started touch exits,…
cixzhang ebb5dbf
spec(AST-057, AST-090): a swipe row's tap or Escape close plays the t…
cixzhang 630b9f0
Merge remote-tracking branch 'origin/main' into spec/gesture-motion-s…
cixzhang 7ae648a
spec(AST-057): format
cixzhang 6ea73c7
Merge remote-tracking branch 'origin/main' into spec/gesture-motion-s…
cixzhang 3eb7fad
Merge remote-tracking branch 'origin/main' into spec/gesture-motion-s…
cixzhang 7fc3273
Merge remote-tracking branch 'origin/main' into spec/gesture-motion-s…
cixzhang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This now counts a program-started number on the theme's motion tokens, but the INV15 verification row (line 486) still fails "A value off its motion role", and theme tokens are not a motion role. Reword that failure to match, for example: "a value off its channels' timing (the theme's tokens for a program-started change, a spring only where
spec:AST-094FR45 keeps one)".