Repository navigation
docs(AST-105, AST-108): glides and tap-to-expand play the theme's motion tokens - #9964
Merged
Merged
Conversation
…ion tokens Co-authored-by: ernestt <5867373+ernestt@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
AI review status for this pull request.
|
Contributor
Author
|
/approve-spec 2a631df |
cixzhang
pushed a commit
that referenced
this pull request
Nov 4, 2026
Main's #9964 rewrote AST-108 FR1's character bullet, which the fluid rework changes too.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
People see glides (a Collapsible opening, a tree row expanding, the side nav rail collapsing) and every tap-started expand and collapse move on the theme's own timing. A theme's
tempoandcharacternow reach those motions. Records only.This supersedes #9663 by
ernestt, who wrote the glide change; this PR carries his attribution as a co-author. It takes his glide change, drops the'native'character, and adds the owner's 2026-11-04 tap-to-expand decision.Exact decision needed
None. The owner decided:
'native'character and no platform-measured opt-in;Existing authority searched
spec:AST-105FR4,component:SideNavFR6 andcomponent:AppShellFR17.spec:AST-108FR1 and FR2 (the three motion knobs and the curve tokens).spec:AST-094FR45, which states the tap rule in docs(AST-094, AST-057): motion guidance; gesture springs; swipe-row returns #9915. This PR cites FR45 rather than restating the rule.Decision
spec:AST-105FR4's glide, swap and edge reveal play--ease-moveover--duration-medium-min, following the theme'scharacterandtempo. They are curve tokens, never a spring, with no platform-measured curve. SideNav FR6's rail motion and AppShell FR17's content swap share that motion. AST-105 DEC-2 records it, rejecting the measured spring and a separate platform-measured character.'native'character:spec:AST-108FR1 keeps'crisp','standard'and'expressive'. It now says no character turns a curve into a spring or plays a platform-measured curve. Which motion springs isspec:AST-094FR45's, and tap-started expand and collapse, the glide included, plays the curve tokens.Rejected alternatives
'native'character, or any option that plays a platform-measured curve for tap-started motion.Claim scope and non-goals
spec:AST-094FR45's list of motions that keep their springs still names the layout glide. That list changes with FR45's own record, which has an open PR (docs(AST-094, AST-057): motion guidance; gesture springs; swipe-row returns #9915), so it is left alone here to avoid a conflict.Changed records
docs/specs/AST-105-animated-layout/spec.md: Intent, FR4, FR7's doc text, FR9's reversal wording, current-state impact, the FR4 verification row, and DEC-2.docs/specs/AST-108-theme-motion/spec.md: FR1'scharacterline.docs/specs/components/SideNav/SideNav.spec.md: FR6.docs/specs/components/AppShell/AppShell.spec.md: FR17.Writing rubric results
Rejected:line in AST-105 DEC-2.Scope
Validation
pnpm check:knowledge: "Knowledge templates and records are aligned."git diff --check: clean