Skip to content

docs(AST-105, AST-108): glides and tap-to-expand play the theme's motion tokens - #9964

Merged
cixzhang merged 1 commit into
mainfrom
docs/glide-tap-expand-tokens
Nov 4, 2026
Merged

cixzhang merged 1 commit into
mainfrom
docs/glide-tap-expand-tokens

Conversation

@cixzhang

@cixzhang cixzhang commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

People see glides (a Collapsible opening, a tree row expanding, the side nav rail collapsing) and every tap-started expand and collapse move on the theme's own timing. A theme's tempo and character now reach those motions. Records only.

This supersedes #9663 by ernestt, who wrote the glide change; this PR carries his attribution as a co-author. It takes his glide change, drops the 'native' character, and adds the owner's 2026-11-04 tap-to-expand decision.

Exact decision needed

None. The owner decided:

  • glides follow the theme's motion tokens;
  • no 'native' character and no platform-measured opt-in;
  • tap-started expand and collapse plays the theme's curve tokens, never a spring (2026-11-04).

Existing authority searched

Decision

  • Glides: spec:AST-105 FR4's glide, swap and edge reveal play --ease-move over --duration-medium-min, following the theme's character and tempo. They are curve tokens, never a spring, with no platform-measured curve. SideNav FR6's rail motion and AppShell FR17's content swap share that motion. AST-105 DEC-2 records it, rejecting the measured spring and a separate platform-measured character.
  • No 'native' character: spec:AST-108 FR1 keeps 'crisp', 'standard' and 'expressive'. It now says no character turns a curve into a spring or plays a platform-measured curve. Which motion springs is spec:AST-094 FR45's, and tap-started expand and collapse, the glide included, plays the curve tokens.

Rejected alternatives

  • The measured spring as every theme's glide.
  • A 'native' character, or any option that plays a platform-measured curve for tap-started motion.

Claim scope and non-goals

Changed records

  • docs/specs/AST-105-animated-layout/spec.md: Intent, FR4, FR7's doc text, FR9's reversal wording, current-state impact, the FR4 verification row, and DEC-2.
  • docs/specs/AST-108-theme-motion/spec.md: FR1's character line.
  • docs/specs/components/SideNav/SideNav.spec.md: FR6.
  • docs/specs/components/AppShell/AppShell.spec.md: FR17.

Writing rubric results

  • R1 narration: none. One current-state line names the change FR4 makes, as that section asks.
  • R2 research in the record: none.
  • R3 evidence naming a change: none.
  • R4 rejected alternatives over one line or outside a decision: one Rejected: line in AST-105 DEC-2.
  • R5 pull request or issue references remaining: none.
  • R6 ruled open questions still listing options: none.

Scope

  • Records only; no Changeset.
  • Public text contains no internal Meta context.

Validation

  • pnpm check:knowledge: "Knowledge templates and records are aligned."
  • Prettier: pass
  • git diff --check: clean

…ion tokens

Co-authored-by: ernestt <5867373+ernestt@users.noreply.github.com>
@vercel

vercel Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
astryx Ready Ready Preview Nov 4, 2026 3:12pm UTC

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 4, 2026
@astracat-bot

astracat-bot Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

AI review status for this pull request.

Review status Updated
🔄 In progress (for maintainers only) Nov 4, 2026, 3:01 PM UTC

@github-actions github-actions Bot added the needs:spec-owner-review Current knowledge records await owner approval label Nov 4, 2026
@cixzhang

cixzhang commented Nov 4, 2026

Copy link
Copy Markdown
Contributor Author

/approve-spec 2a631df

@github-actions github-actions Bot removed the needs:spec-owner-review Current knowledge records await owner approval label Nov 4, 2026
@cixzhang
cixzhang merged commit a0c48b8 into main Nov 4, 2026
55 checks passed
cixzhang pushed a commit that referenced this pull request Nov 4, 2026
Main's #9964 rewrote AST-108 FR1's character bullet, which the fluid
rework changes too.
@github-actions
github-actions Bot deleted the docs/glide-tap-expand-tokens branch November 5, 2026 06:03

This branch was successfully deployed

1 active deployment
Preview — 2a631df6 Deployed Nov 4, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant