Repository navigation
Conversation
Summary: `WorkWave` now lists its codec runs in plan order, and `WorkGroup` is gone. `Device::chooseDecodeBatches` groups the runs of a wave by kernel, and each kernel serves one transform, so the device decides every grouping. The schedule decides only which runs can start together, and it no longer reads transforms. Reviewed By: Cyan4973 Differential Revision: D128407138
|
@mmandina has exported this pull request. If you are a Meta employee, you can view the originating Diff in D128407138. |
|
This pull request has been merged in dbe20d9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
WorkWavenow lists its codec runs in plan order, andWorkGroupis gone.Device::chooseDecodeBatchesgroups the runs of a wave by kernel, and each kernel serves one transform, so the device decides every grouping. The schedule decides only which runs can start together, and it no longer reads transforms.Reviewed By: Cyan4973
Differential Revision: D128407138