[29.x]User is unable to filter the Deferral Summary-GL Report Not Filtering Totals by Global Dimensions. - #10874
Conversation
…ummary' of https://github.com/microsoft/BCApps into bugs/Bug-648519-User-is-unable-to-filter-the-Deferral-Summary
There was a problem hiding this comment.
Pull request overview
This PR fixes the Deferral Summary - G/L report so that filtering by Global Dimension 1/2 actually affects which posted deferrals (and therefore totals) are included, and adds automated coverage to prevent regressions.
Changes:
- Expose Global Dimension 1 Filter and Global Dimension 2 Filter as request filters on report 1700.
- Apply those dimension filters by skipping posted deferral headers whose linked G/L Entry doesn’t match the selected global dimension filters.
- Add new tests (across multiple test layers) validating filtering behavior for both global dimensions.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Layers/W1/BaseApp/Finance/Deferral/DeferralSummaryGL.Report.al | Adds global dimension request filters and enforces them by skipping non-matching deferral entries. |
| src/Layers/W1/Tests/ERM/TestREDSetupGenJnl.Codeunit.al | Adds tests that post deferrals with different global dimensions and verify the report output filters correctly. |
| src/Layers/NA/Tests/ERM/TestREDSetupGenJnl.Codeunit.al | Same test coverage added for NA layer. |
| src/Layers/IT/Tests/ERM/TestREDSetupGenJnl.Codeunit.al | Same test coverage added for IT layer. |
| src/Layers/GB/Tests/ERM/TestREDSetupGenJnl.Codeunit.al | Same test coverage added for GB layer. |
| src/Layers/FR/Tests/ERM/TestREDSetupGenJnl.Codeunit.al | Same test coverage added for FR layer. |
| src/Layers/ES/Tests/ERM/TestREDSetupGenJnl.Codeunit.al | Same test coverage added for ES layer. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Good Sense Reviewer - Round 1Recommendation: AcceptWhat this PR doesThe change makes Deferral Summary - G/L accept filters for both global dimensions and applies those filters to the G/L Entry behind each posted G/L deferral header before any report amounts are accumulated. This targets the root cause: the report data is driven by posted deferral headers, but the dimension values live on the related G/L entry. The skip happens before totals are updated, so both detail rows and the summary amounts are limited to entries that match the selected dimension filters. The added tests cover both global dimensions with matching and non-matching posted deferrals. Problem-solution fitFit: Strong The bug says the G/L deferral summary should only return entries that match the selected global dimension filters. The diff adds those request filters and uses the source G/L entry dimensions to decide which posted deferral headers participate, which matches the requested behavior without broadening the report scope. SuggestionsNo suggestions. Risk assessment and necessityRisk: The change is limited to report 1700 and related tests. It changes which posted G/L deferral rows are included when dimension filters are set; unfiltered report runs still take the old path. The extra lookup is by G/L Entry number, so the performance impact should be small, and no public event or procedure signature changes. Necessity: The change is needed because G/L Account flowfilters do not automatically filter the child posted deferral header records. The scope is right for the report: it adds the two filters users can choose and applies them at the point where the source entry is known.
|
|
Pull request was closed
Fixes AB#648519
Workitem : Bug 648519: [29.x][All-e][FTE][SaaS] User is unable to filter the Deferral Summary-GL Report Not Filtering Totals by Global Dimensions.