Skip to content

[29.x]User is unable to filter the Deferral Summary-GL Report Not Filtering Totals by Global Dimensions. - #10874

Open
Fixes4BC (neeleshsinghal) wants to merge 4 commits into
releases/29.xfrom
bugs/Bug-648519-User-is-unable-to-filter-the-Deferral-Summary
Open

[29.x]User is unable to filter the Deferral Summary-GL Report Not Filtering Totals by Global Dimensions.#10874
Fixes4BC (neeleshsinghal) wants to merge 4 commits into
releases/29.xfrom
bugs/Bug-648519-User-is-unable-to-filter-the-Deferral-Summary

Conversation

@neeleshsinghal

@neeleshsinghal Fixes4BC (neeleshsinghal) commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Fixes AB#648519
Workitem : Bug 648519: [29.x][All-e][FTE][SaaS] User is unable to filter the Deferral Summary-GL Report Not Filtering Totals by Global Dimensions.

@github-actions github-actions Bot added the Team: Finance GitHub request for Finance area label Sep 1, 2026
@github-actions github-actions Bot added this to the Version 29.1 milestone Sep 1, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the Deferral Summary - G/L report so that filtering by Global Dimension 1/2 actually affects which posted deferrals (and therefore totals) are included, and adds automated coverage to prevent regressions.

Changes:

  • Expose Global Dimension 1 Filter and Global Dimension 2 Filter as request filters on report 1700.
  • Apply those dimension filters by skipping posted deferral headers whose linked G/L Entry doesn’t match the selected global dimension filters.
  • Add new tests (across multiple test layers) validating filtering behavior for both global dimensions.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/Layers/W1/BaseApp/Finance/Deferral/DeferralSummaryGL.Report.al Adds global dimension request filters and enforces them by skipping non-matching deferral entries.
src/Layers/W1/Tests/ERM/TestREDSetupGenJnl.Codeunit.al Adds tests that post deferrals with different global dimensions and verify the report output filters correctly.
src/Layers/NA/Tests/ERM/TestREDSetupGenJnl.Codeunit.al Same test coverage added for NA layer.
src/Layers/IT/Tests/ERM/TestREDSetupGenJnl.Codeunit.al Same test coverage added for IT layer.
src/Layers/GB/Tests/ERM/TestREDSetupGenJnl.Codeunit.al Same test coverage added for GB layer.
src/Layers/FR/Tests/ERM/TestREDSetupGenJnl.Codeunit.al Same test coverage added for FR layer.
src/Layers/ES/Tests/ERM/TestREDSetupGenJnl.Codeunit.al Same test coverage added for ES layer.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/Layers/W1/BaseApp/Finance/Deferral/DeferralSummaryGL.Report.al
@alexei-dobriansky

Copy link
Copy Markdown
Contributor

Good Sense Reviewer - Round 1

Recommendation: Accept

What this PR does

The change makes Deferral Summary - G/L accept filters for both global dimensions and applies those filters to the G/L Entry behind each posted G/L deferral header before any report amounts are accumulated. This targets the root cause: the report data is driven by posted deferral headers, but the dimension values live on the related G/L entry. The skip happens before totals are updated, so both detail rows and the summary amounts are limited to entries that match the selected dimension filters. The added tests cover both global dimensions with matching and non-matching posted deferrals.

Problem-solution fit

Fit: Strong

The bug says the G/L deferral summary should only return entries that match the selected global dimension filters. The diff adds those request filters and uses the source G/L entry dimensions to decide which posted deferral headers participate, which matches the requested behavior without broadening the report scope.

Suggestions

No suggestions.

Risk assessment and necessity

Risk: The change is limited to report 1700 and related tests. It changes which posted G/L deferral rows are included when dimension filters are set; unfiltered report runs still take the old path. The extra lookup is by G/L Entry number, so the performance impact should be small, and no public event or procedure signature changes.

Necessity: The change is needed because G/L Account flowfilters do not automatically filter the child posted deferral header records. The scope is right for the report: it adds the two filters users can choose and applies them at the point where the source entry is known.


[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=10874 round=1 by=alexei-dobriansky at=2026-09-01T13:18:28Z lastSha=0deb1b98c6b5876f4dcdca5f43ddf5b15651ad55 reviewKey=0eb2ce69200796f4def999bd92a4c9b6d8d6c26716d2d3398e18a3f707399777 suggestions=none

@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

⚠️ Stale Status Check Deleted

The Pull Request Build workflow run for this PR was older than 72 hours and has been deleted.

📋 Why was it deleted?

Status checks that are too old may no longer reflect the current state of the target branch. To ensure this PR is validated against the latest code and passes up-to-date checks, a fresh build is required.


🔄 How to trigger a new status check:

  1. 📤 Push a new commit to the PR branch, or
  2. 🔁 Close and reopen the PR

This will automatically trigger a new Pull Request Build workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team: Finance GitHub request for Finance area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants