[29.X]-Inconsistent Validation of Non-Deductible VAT % for Purchase Lines Sharing the Same VAT Identifier - #10880
Conversation
… Lines Sharing the Same VAT Identifier- #10607 (#10609) [AB#647365](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/647365) --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: neeleshsinghal <241776335+neeleshsinghal@users.noreply.github.com> (cherry picked from commit 20c3a9a)
GitHub Actions
Inactive
Good Sense Reviewer - Round 1Recommendation: Request ChangesWhat this PR doesThis change removes the early exit for zero Non-Deductible VAT % on purchase lines, so the line check compares both entry orders for lines with the same VAT Identifier. That addresses the document-line part of the reported bug, and the added tests cover the line validation path. The fix is still incomplete because the invalid VAT Posting Setup combination can still be created before a document line is entered. Problem-solution fitFit: Partial The bug asks for consistent validation on purchase lines and prevention of the inconsistent setup. The line validation is covered, but the setup validation path still allows a zero/non-allowed setup to share a VAT Identifier with an allowed non-zero setup. SuggestionsS1 (🔴 High): Setup validation still allows invalid pairs Risk assessment and necessityRisk: This touches VAT validation on purchase documents, so a missed path can leave inconsistent VAT setup and later affect VAT amount grouping. The code change is narrow and has line-level tests, but the setup path is still a real regression surface. Necessity: The change is needed because the reported scenario can let two purchase lines with the same VAT Identifier use different Non-Deductible VAT percentages. The scope should include both the document-line validation and the VAT Posting Setup validation.
|
|
GitHub Actions
Inactive
3 participants
Fixes AB#648529