Skip to content

[29.x]-Bug 645041: Expense Agent - Rename Enable approval workflow caption and tooltip - #10919

Open
v-rohangarg20 wants to merge 1 commit into
releases/29.xfrom
bugs/648636-rename-approval-workflow-caption-29x
Open

[29.x]-Bug 645041: Expense Agent - Rename Enable approval workflow caption and tooltip#10919
v-rohangarg20 wants to merge 1 commit into
releases/29.xfrom
bugs/648636-rename-approval-workflow-caption-29x

Conversation

@v-rohangarg20

@v-rohangarg20 v-rohangarg20 commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Fixes AB#648636

Backport of #10825 for AB#645041.

Problem

On the Expense Agent Setup page, Enable approval workflow did not clearly explain that the setting switches expense reports to the traditional approval workflow instead of the Expense Agent approval experience.

Changes

  • Renamed the caption to Use traditional approval workflow.
  • Clarified the tooltip to distinguish the traditional workflow from the Expense Agent approval experience.
  • Set the workflow field and Default Approver to Importance = Additional.

Backport

Cherry-picked source commit 9c0b66e44e2144106e32581f00f2f8aab2319a3f cleanly onto releases/29.x. The change is limited to the two Expense Agent setup files.

The source PR is still open; this backport must be refreshed if #10825 changes before merge.

@alexei-dobriansky

Copy link
Copy Markdown
Contributor

Good Sense Reviewer - Round 1

Recommendation: Accept

What this PR does

This PR renames the Expense Agent Setup field caption to Use traditional approval workflow, clarifies that the setting chooses the traditional approval workflow instead of the Expense Agent approval experience, and marks that field plus Default Approver as Additional importance. The table field supplies the caption and tooltip used by the page field, so the text change reaches the setup page without changing validation, storage, or workflow behavior. The Importance changes only affect page prominence and match the same setup area.

Problem-solution fit

Fit: Strong

The bug says the old wording could be confused with another approval experience. The new caption and tooltip directly explain the traditional workflow choice, and the diff stays limited to the requested setup metadata.

Suggestions

No suggestions.

Risk assessment and necessity

Risk: The regression surface is limited to the Expense Agent Setup UI. The PR does not change validation, database schema, workflow execution, public procedures, or events; no BaseApp event contract is involved. Tests are not warranted for this metadata-only caption, tooltip, and page-importance change.

Necessity: The change is useful because the setting controls a choice between two approval experiences, and the old wording did not make that clear. The scope is right for the problem: it updates the user-facing text and related page prominence without changing business logic.


[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=10919 round=1 by=alexei-dobriansky at=2026-09-02T07:13:33Z lastSha=aa8c62ef671184c725c636933295677922248330 reviewKey=2e21ce58981d0729a7d59795d324cc04325d1091d745412e53571354897f8c80 suggestions=

}
field(DefaultApprover; Rec."Default Approver Name")
{
Importance = Additional;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

⚠️ Stale Status Check Deleted

The Pull Request Build workflow run for this PR was older than 72 hours and has been deleted.

📋 Why was it deleted?

Status checks that are too old may no longer reflect the current state of the target branch. To ensure this PR is validated against the latest code and passes up-to-date checks, a fresh build is required.


🔄 How to trigger a new status check:

  1. 📤 Push a new commit to the PR branch, or
  2. 🔁 Close and reopen the PR

This will automatically trigger a new Pull Request Build workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1 Team: Finance GitHub request for Finance area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants