Skip to content

[29.0] Promote Excise Taxes action on Item card - #10981

Merged
v-rohangarg20 merged 3 commits into
releases/29.0from
bugs/648829-290-promote-excise-taxes-action-on-item-card
Sep 7, 2026
Merged

[29.0] Promote Excise Taxes action on Item card#10981
v-rohangarg20 merged 3 commits into
releases/29.0from
bugs/648829-290-promote-excise-taxes-action-on-item-card

Conversation

@v-rohangarg20

@v-rohangarg20 v-rohangarg20 commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Description

Backport of the Item Card action promotion for Excise Taxes.

Work item

Reference

  • Bug 648829: [29.0] Promote Excise Taxes action on Item card

@v-rohangarg20
v-rohangarg20 requested a review from a team September 3, 2026 07:33
@v-rohangarg20
v-rohangarg20 requested a review from a team as a code owner September 3, 2026 07:33
@github-actions github-actions Bot added AL: Apps (W1) Add-on apps for W1 Team: Finance GitHub request for Finance area labels Sep 3, 2026
@github-actions github-actions Bot added this to the Version 29.0 milestone Sep 3, 2026
@alexei-dobriansky

Copy link
Copy Markdown
Contributor

Good Sense Reviewer - Round 1

Recommendation: Accept

What this PR does

This change promotes the Excise Taxes action on the Item Card into the Process promoted action category for the release branch. The action itself, target page, and item link are unchanged, so the behavior stays the same and only the action discoverability changes.

Problem-solution fit

Fit: Strong

The reported problem is that the Excise Taxes action is hard to find from the Item Card. Adding an �ctionref for the existing action directly matches that goal without changing excise tax setup or item data.

Suggestions

None.

Risk assessment and necessity

Risk: The change is limited to ExciseItemCardExt.PageExt.al action promotion. It does not change page execution, table data, posting, permissions, or public APIs.

Necessity: The change is needed to make the existing excise tax setup entry point visible in promoted actions. The scope is right because it reuses the existing action instead of adding a duplicate action.


[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=10981 round=1 by=alexei-dobriansky at=2026-09-03T13:13:56Z lastSha=530f428b51dda402f55e0e1ccaf81f83c710fee0 reviewKey=9cbc04555c435fed2c167db98029710bb859f3cb7fd306cfaf08137afd82dcfe suggestions=none

@alexei-dobriansky

Copy link
Copy Markdown
Contributor

Good Sense Reviewer - Round 2

Recommendation: Accept

What this PR does

This change promotes the Excise Taxes action on the Item Card into the Item promoted action group. The action still opens the same setup page for the current item, so behavior stays unchanged while discoverability improves.

The new target group matches the Item Card promoted category structure. Category_Category4 is the Item group, which is a better home than Process for item-related navigation. No code path, data write, or posting logic is changed.

Status of previous suggestions

No previous suggestions were open.

New observations (commits since round 1)

None - the new commit only moves the promoted action to the Item category.

Risk assessment and necessity

Risk: Low. The change is limited to promoted action placement in src/Apps/W1/ExciseTaxes/app/src/pageextension/ExciseItemCardExt.PageExt.al; it does not change the action target, item link, public API, or financial logic.

Necessity: The change is focused and fits the stated discoverability problem. Promoting the existing action is enough to make the setup easier to find without broadening behavior.


[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=10981 round=2 by=alexei-dobriansky at=2026-09-04T10:39:15Z lastSha=73b0f826ee286ee85f494b7f3d02cc45bcca0bcf reviewKey=89a0fa3d96a2d2eebbafdd336d8d15dde03a005d3c0d593750dfd56aa15c5b7f suggestions=none parentRound=1

@v-rohangarg20
v-rohangarg20 enabled auto-merge (squash) September 7, 2026 12:15
@v-rohangarg20
v-rohangarg20 merged commit 64e5167 into releases/29.0 Sep 7, 2026
330 of 332 checks passed
@v-rohangarg20
v-rohangarg20 deleted the bugs/648829-290-promote-excise-taxes-action-on-item-card branch September 7, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1 Team: Finance GitHub request for Finance area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants