Skip to content

[Main]Cannot Rename User Due to Financial Report Audit Log Permissions - Copy - #10991

Open
sanjmaurya wants to merge 2 commits into
mainfrom
bugs/Bug-648875-Main-CannotRenameUserDueFinancialReportAuditLogPermissions
Open

[Main]Cannot Rename User Due to Financial Report Audit Log Permissions - Copy#10991
sanjmaurya wants to merge 2 commits into
mainfrom
bugs/Bug-648875-Main-CannotRenameUserDueFinancialReportAuditLogPermissions

Conversation

@sanjmaurya

@sanjmaurya sanjmaurya commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Bug 648875: [Master][All-e][FTE][SaaS] Cannot Rename User Due to Financial Report Audit Log Permissions - Copy

Fixes AB#648875

Issue:
When a user was renamed, existing Financial Report Audit Log entries continued to reference the old user name.

Cause:
The Financial Report Audit Log table was missing from the Base Application’s user-renaming logic and required permissions.

Solution:
Added the table to the user-renaming handler and granted the required modify/rename permissions. Added a test verifying that audit-log entries are updated with the new user name.

@github-actions github-actions Bot added the Team: Integrations GitHub request for Integrations area label Sep 3, 2026
@github-actions github-actions Bot added this to the Version 30.0 milestone Sep 3, 2026
@sanjmaurya
sanjmaurya marked this pull request as ready for review September 3, 2026 10:57
@sanjmaurya
sanjmaurya requested a review from a team September 3, 2026 10:57
@sanjmaurya
sanjmaurya requested a review from a team as a code owner September 3, 2026 10:57
@alexei-dobriansky

Copy link
Copy Markdown
Contributor

Good Sense Reviewer - Round 1

Recommendation: Accept

What this PR does

This change adds Financial Report Audit Log to the user rename permission list and to the existing BaseApp-specific rename handler in both W1 and RU.

The event publisher was verified in the User codeunit. It runs before the generic rename path, and this table's User field is not part of the primary key, so the existing RenameField path updates matching rows with RecRef.Modify() and avoids the missing-permission failure.

Problem-solution fit

Fit: Strong

The reported scenario is clear: audit log rows with the old user name must not block a later user rename. The diff targets that exact table and uses the same established handler used for other User-related BaseApp tables.

Suggestions

None.

Risk assessment and necessity

Risk: Low. The change adds one table to existing user rename handling and adds matching indirect permissions in both W1 and RU. The existing generic user-rename test should exercise this relation table, and the relevant build and test checks are green.

Necessity: Necessary. Without this change, a user with Financial Report Audit Log rows can fail user rename or leave rows under the old user name. The scope is tight and matches the missing table.


[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=10991 round=1 by=alexei-dobriansky at=2026-09-04T08:45:55.9985938Z lastSha=36971a5d5af47fa2b16d334c63a4130558e7daad reviewKey=eae55391174e90d5668fc3cae6544e6a6bf486e6db3aadf8957463b47ac9f8fe suggestions=none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team: Integrations GitHub request for Integrations area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants