Backport #10990: [29.0] Add Expense VAT settings to Contoso demo tool - #10995
Backport #10990: [29.0] Add Expense VAT settings to Contoso demo tool#10995Alexander Yakunin (Alexander-Ya) wants to merge 1 commit into
Conversation
Good Sense Reviewer - Round 1Recommendation: Request ChangesWhat this PR doesThe change wires Expense VAT rate creation into the Contoso demo module for the 29.0 branch. This should let demo data create VAT product posting groups, VAT posting setup, and default VAT settings for Expense Agent categories. The new call is not enough to create a complete setup. The VAT rate code depends on the Expense Agent setup already having a default VAT business posting group. In this branch, the setup data does not set that field before the new direct call creates VAT posting setup. Problem-solution fitFit: Partial The change adds VAT rates to demo master data, but it does not apply the full setup state that the VAT flow needs. A demo company can still be left without the default VAT business posting group used by agent-created VAT specifications. SuggestionsS1 (🔴 High): Set the VAT business default before rates Risk assessment and necessityRisk: This affects Contoso Expense Agent demo setup and VAT posting setup. If the default VAT business group is missing or the rates are created against a blank group, demo expenses can fail VAT specification insertion or use incomplete VAT setup. Necessity: The change is needed so demo data includes the VAT settings used by Expense Agent. The scope is right, but it needs to create a complete VAT configuration, not only the rate rows.
|
Backport of #10990 to
releases/29.0.Original change: Add Expense VAT settings to the Contoso demo tool.
Bug AB#648895