Skip to content

Backport #10990: [29.0] Add Expense VAT settings to Contoso demo tool - #10995

Open
Alexander Yakunin (Alexander-Ya) wants to merge 1 commit into
releases/29.0from
backport/releases/29.0/10990/20260903114117
Open

Backport #10990: [29.0] Add Expense VAT settings to Contoso demo tool#10995
Alexander Yakunin (Alexander-Ya) wants to merge 1 commit into
releases/29.0from
backport/releases/29.0/10990/20260903114117

Conversation

@Alexander-Ya

@Alexander-Ya Alexander Yakunin (Alexander-Ya) commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Backport of #10990 to releases/29.0.

Original change: Add Expense VAT settings to the Contoso demo tool.

Bug AB#648895

@alexei-dobriansky

Copy link
Copy Markdown
Contributor

Good Sense Reviewer - Round 1

Recommendation: Request Changes

What this PR does

The change wires Expense VAT rate creation into the Contoso demo module for the 29.0 branch. This should let demo data create VAT product posting groups, VAT posting setup, and default VAT settings for Expense Agent categories.

The new call is not enough to create a complete setup. The VAT rate code depends on the Expense Agent setup already having a default VAT business posting group. In this branch, the setup data does not set that field before the new direct call creates VAT posting setup.

Problem-solution fit

Fit: Partial

The change adds VAT rates to demo master data, but it does not apply the full setup state that the VAT flow needs. A demo company can still be left without the default VAT business posting group used by agent-created VAT specifications.

Suggestions

S1 (🔴 High): Set the VAT business default before rates
The new Codeunit.Run(Codeunit::"Create Expense VAT Rates") call can run while Default VAT Bus. Posting Group is still blank. Then the rates are created for the wrong VAT business group, and later agent VAT specifications can fail because the setup default is missing. Please set the default VAT business posting group before creating the rates, and keep the applied flag in sync with that setup step.

Risk assessment and necessity

Risk: This affects Contoso Expense Agent demo setup and VAT posting setup. If the default VAT business group is missing or the rates are created against a blank group, demo expenses can fail VAT specification insertion or use incomplete VAT setup.

Necessity: The change is needed so demo data includes the VAT settings used by Expense Agent. The scope is right, but it needs to create a complete VAT configuration, not only the rate rows.


[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=10995 round=1 by=alexei-dobriansky at=2026-09-03T13:21:39Z lastSha=ba46bfa5fdc58fb34f33f6d30d1735ca2949a7d6 reviewKey=58c9436227293107be55bc1b2cabe80ee295a3cba6f5f882292b30a7aeb5232a suggestions=S1@43fb032b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1 ExpenseManagement Team: Finance GitHub request for Finance area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants