Fix Expense Report Reimbursement Currency Code - #11004
Conversation
Good Sense Reviewer - Round 1Recommendation: AcceptWhat this PR doesThis stops the new expense-report flow from copying the expense currency into the report header reimbursement currency. The report header now gets its reimbursement currency from the expense user setup, which keeps local currency blank when no employee reimbursement currency is configured, while the expense report line still keeps the original expense currency. Problem-solution fitFit: Strong The reported problem is that a foreign expense currency was being used as the report reimbursement currency when a new report was created. The diff removes that incorrect assignment and adds a focused regression test for a foreign-currency expense. SuggestionsNone. Risk assessment and necessityRisk: The changed code is narrow and affects only creation of a new expense report from selected expenses. It does not change existing-report selection, posting, upgrade data, or public APIs; the financial risk is reduced because reimbursement currency now follows the header setup instead of the expense line currency. Necessity: The change is required because expense currency and reimbursement currency are different concepts. The added test covers the important foreign-currency scenario and keeps the scope limited to the faulty assignment.
|
What & why
Linked work
Fixes AB#647169
How I validated this
What I tested and the outcome (required — be specific: scenarios, commands, screenshots for UI changes)
Risk & compatibility