Skip to content

Fix Expense Report Reimbursement Currency Code - #11004

Merged
Prangshuman Das (t-prda) merged 1 commit into
mainfrom
bugs/Bug647169-Fix-Expense-Report-Reimbursement-Currency-Code
Sep 4, 2026
Merged

Fix Expense Report Reimbursement Currency Code#11004
Prangshuman Das (t-prda) merged 1 commit into
mainfrom
bugs/Bug647169-Fix-Expense-Report-Reimbursement-Currency-Code

Conversation

@Alexander-Ya

@Alexander-Ya Alexander Yakunin (Alexander-Ya) commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

What & why

Linked work

Fixes AB#647169

How I validated this

  • I read the full diff and it contains only changes I intended.
  • I built the affected app(s) locally with no new analyzer warnings.
  • I ran the change in Business Central and confirmed it behaves as expected.
  • I added or updated tests for the new behavior, or explained below why none are needed.

What I tested and the outcome (required — be specific: scenarios, commands, screenshots for UI changes)

Risk & compatibility

@github-actions github-actions Bot added AL: Apps (W1) Add-on apps for W1 Team: Finance GitHub request for Finance area labels Sep 3, 2026
@github-actions github-actions Bot added this to the Version 30.0 milestone Sep 3, 2026
@alexei-dobriansky

Copy link
Copy Markdown
Contributor

Good Sense Reviewer - Round 1

Recommendation: Accept

What this PR does

This stops the new expense-report flow from copying the expense currency into the report header reimbursement currency. The report header now gets its reimbursement currency from the expense user setup, which keeps local currency blank when no employee reimbursement currency is configured, while the expense report line still keeps the original expense currency.

Problem-solution fit

Fit: Strong

The reported problem is that a foreign expense currency was being used as the report reimbursement currency when a new report was created. The diff removes that incorrect assignment and adds a focused regression test for a foreign-currency expense.

Suggestions

None.

Risk assessment and necessity

Risk: The changed code is narrow and affects only creation of a new expense report from selected expenses. It does not change existing-report selection, posting, upgrade data, or public APIs; the financial risk is reduced because reimbursement currency now follows the header setup instead of the expense line currency.

Necessity: The change is required because expense currency and reimbursement currency are different concepts. The added test covers the important foreign-currency scenario and keeps the scope limited to the faulty assignment.


[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=11004 round=1 by=alexei-dobriansky at=2026-09-03T13:27:44.9515802Z lastSha=c9fe1930e62e05c15889184cbf7ece72580da8e6 reviewKey=a8cfcf19cf4d54f7240818651ecbc1a709e49787f3f109b729521ecaf19bb74d suggestions=none

@t-prda
Prangshuman Das (t-prda) added this pull request to the merge queue Sep 4, 2026
Merged via the queue into main with commit 23952d0 Sep 4, 2026
175 checks passed
@t-prda
Prangshuman Das (t-prda) deleted the bugs/Bug647169-Fix-Expense-Report-Reimbursement-Currency-Code branch September 4, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1 Team: Finance GitHub request for Finance area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants