Expense Agent: align legacy submit cleanup with 29.0

[Prangshuman Das (t-prda)]

Summary

Align the legacy Expense Agent submit action's cleanup lifecycle on main with the 29.0 release where the obsoletion was introduced.

This changes the preprocessor guard from CLEAN30 to CLEAN29 and the obsolete tag from 30.0 to 29.0. The compatibility action and its forwarding behavior are unchanged.

Work item

AB#633685

Related PRs

• Original feature: Expense Agent: add approval conversation to expense reports #10570
• releases/29.x backport: [29.x][Expense Agent] Backport approval conversation from #10570 #10829
• releases/29.0 backport: [29.0][Expense Agent] Backport approval conversation from #10570 #10830

Both release backports are merged and establish the CLEAN29 / 29.0 lifecycle below main.

[alexei-dobriansky]

Good Sense Reviewer - Round 1

Recommendation: Request Changes

What this PR does

This change moves the legacy Expense Agent submit API cleanup metadata from the 30.0 cleanup wave to the 29.0 cleanup wave. The forwarding behavior itself is unchanged, but the branch still enforces the 30.0 obsolete tag for this method, so the change does not currently build in the default app build.

Problem-solution fit

Fit: Partial

The requested lifecycle alignment is clear, and the release branches already use the 29.0 cleanup metadata. On this branch, however, the analyzer expects this legacy API to stay in the 30.0 cleanup wave, so the same metadata change is not valid here.

Suggestions

S1 (🔴 High): Keep main cleanup metadata at 30.0
This branch still expects the legacy API cleanup to be guarded by CLEAN30 with obsolete tag 30.0. Changing it to CLEAN29 and 29.0 makes the default app build fail with AS0072. Please keep the main-branch cleanup metadata at CLEAN30 and 30.0.

Risk assessment and necessity

Risk: The touched surface is a public service-enabled compatibility API. The direct risk is high because the default app build rejects the new obsolete tag, so the branch cannot be merged in this state.

Necessity: Keeping release-branch cleanup metadata aligned is useful, but this branch has a different expected cleanup wave. No extra tests are needed for this metadata-only change; the blocker is the failed branch validation.

---

[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=11021 round=1 by=alexei-dobriansky at=2026-09-04T10:39:16Z lastSha=d2f58df2cc69865fc87227eb6e20a14274255bed reviewKey=962ed3673b29d4ceae23d33b799c79dd4d7e31ce624156b54712415f486e8eb6 suggestions=S1@f5cd9d11