Skip to content

[Master]-Bug 648538: Add mileage setup to Expense Agent wizard - #11027

Open
v-rohangarg20 wants to merge 1 commit into
mainfrom
bugs/Bug648538-mileage-setup-wizard
Open

[Master]-Bug 648538: Add mileage setup to Expense Agent wizard#11027
v-rohangarg20 wants to merge 1 commit into
mainfrom
bugs/Bug648538-mileage-setup-wizard

Conversation

@v-rohangarg20

@v-rohangarg20 v-rohangarg20 commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Fixes AB#648538

Adds mileage configuration to the Expense Agent setup wizard and warns users when they close Mileage Rate Setup without configuring any mileage rates.

Changes are limited to:

  • Expense Agent setup wizard mileage configuration link
  • Mileage Rate Setup empty-configuration confirmation

AL build completed successfully.

Add a mileage-rate configuration link below the default mileage unit and warn when closing mileage setup without configured rates.
@v-rohangarg20
v-rohangarg20 requested a review from a team September 3, 2026 18:29
@v-rohangarg20
v-rohangarg20 requested a review from a team as a code owner September 3, 2026 18:29
@github-actions github-actions Bot added AL: Apps (W1) Add-on apps for W1 Team: Finance GitHub request for Finance area labels Sep 3, 2026
@github-actions github-actions Bot added this to the Version 30.0 milestone Sep 3, 2026
}
}

trigger OnQueryClosePage(CloseAction: Action): Boolean

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$\textbf{🟡\ Medium\ Severity\ —\ Agent}$

The new OnQueryClosePage trigger on page 7128 "Mileage Rate Setup" prompts "No mileage rates have been configured. The standard mileage rate will be used. Do you want to continue?" every time the page is closed with an empty table. This page has UsageCategory = Lists, so it is reachable directly from the Lists menu/search, not only from the Expense Agent Setup Wizard drill-down added in this PR. A user who opens the list independently (e.g., just to check whether rates exist) and closes it without adding a rate will see a setup-wizard-flavored confirmation that is confusing outside the wizard flow, and answering No leaves the page open with no clear indication of what action is expected. Consider moving this confirmation into the wizard's own close/validation flow, or scoping it so it only prompts when the page was opened modally from the wizard.

👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.36.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1 Team: Finance GitHub request for Finance area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant