Skip to content

29.x: Allow bank rec. duplicated transactions surfaced in UI #11056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Joshua (mynjj) merged 4 commits into from
Sep 9, 2026
Merged

29.x: Allow bank rec. duplicated transactions surfaced in UI #11056

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
084b364
w1 changes
Sep 4, 2026
ecce51e
miapp
Sep 4, 2026
7414119
Rename action caption to 'Allow Duplicated Transactions'
Sep 7, 2026
0d0a96e
also include the unsurfaced "Import Posted Transactions"
Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 57 additions & 0 deletions src/Layers/CH/BaseApp/Bank/Reconciliation/PaymentReconciliationJournal.Page.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,6 +573,59 @@ page 1290 "Payment Reconciliation Journal"
end;
end;
}
action(AllowDuplicatedTransactions)
{
ApplicationArea = Basic, Suite;
Caption = 'Allow Duplicated Transactions';
Image = ChangeStatus;
ToolTip = 'Toggle whether transactions that have the same transaction ID can be imported into this journal.';

trigger OnAction()
var
ConfirmManagement: Codeunit "Confirm Management";
ChangeSettingQst: Text;
begin
InitializeBankAccRecon();

if BankAccReconciliation."Allow Duplicated Transactions" then
ChangeSettingQst := SkipDuplicatedTransactionsQst
else
ChangeSettingQst := AllowDuplicatedTransactionsQst;
if not ConfirmManagement.GetResponseOrDefault(ChangeSettingQst, false) then
exit;

BankAccReconciliation.Validate("Allow Duplicated Transactions", not BankAccReconciliation."Allow Duplicated Transactions");
BankAccReconciliation.Modify(true);
end;
}
action(ImportPostedTransactions)
{
ApplicationArea = Basic, Suite;
Caption = 'Import Posted Transactions';
Image = ChangeStatus;
ToolTip = 'Toggle whether transactions that are already applied, but whose related bank account ledger entries are not closed, can be imported into this journal.';

trigger OnAction()
var
ConfirmManagement: Codeunit "Confirm Management";
ChangeSettingQst: Text;
begin
InitializeBankAccRecon();

if BankAccReconciliation."Import Posted Transactions" = BankAccReconciliation."Import Posted Transactions"::Yes then
ChangeSettingQst := SkipPostedTransactionsQst
else
ChangeSettingQst := ImportPostedTransactionsQst;
if not ConfirmManagement.GetResponseOrDefault(ChangeSettingQst, false) then
exit;

if BankAccReconciliation."Import Posted Transactions" = BankAccReconciliation."Import Posted Transactions"::Yes then
BankAccReconciliation.Validate("Import Posted Transactions", BankAccReconciliation."Import Posted Transactions"::No)
else
BankAccReconciliation.Validate("Import Posted Transactions", BankAccReconciliation."Import Posted Transactions"::Yes);
BankAccReconciliation.Modify(true);
end;
}
action(ApplyAutomatically)
{
ApplicationArea = Basic, Suite;
Expand Down Expand Up @@ -1287,6 +1340,10 @@ page 1290 "Payment Reconciliation Journal"
ShowDetailsTxt: Label 'Open bank account card';
DisableNotificationTxt: Label 'Don''t show this again';
WouldYouLikeToRunMapTexttoAccountAgainQst: Label 'Do you want to re-apply the text to account mapping rules to all lines in the bank statement?';
AllowDuplicatedTransactionsQst: Label 'Transactions that have the same transaction ID are currently skipped when you import a bank statement into this journal. Do you want to import them?';
SkipDuplicatedTransactionsQst: Label 'Transactions that have the same transaction ID are currently considered when importing into this journal. Do you want to skip them instead?';
ImportPostedTransactionsQst: Label 'Transactions that are already applied, but whose related bank account ledger entries are not closed, are currently skipped when you import a bank statement into this journal. Do you want to import them?';
SkipPostedTransactionsQst: Label 'Transactions that are already applied, but whose related bank account ledger entries are not closed, are currently imported into this journal. Do you want to skip them instead?';
StatementEndingBalance: Text;

protected var
Expand Down
12 changes: 12 additions & 0 deletions src/Layers/NA/BaseApp/Bank/Reconciliation/BankAccReconciliation.Page.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,18 @@ page 379 "Bank Acc. Reconciliation"
ApplicationArea = Basic, Suite;
Caption = 'Statement Ending Balance';
}
field(AllowDuplicatedTransactions; Rec."Allow Duplicated Transactions")
{
ApplicationArea = Basic, Suite;
Caption = 'Import Duplicated Transactions';
Visible = false;
}
field(ImportPostedTransactions; Rec."Import Posted Transactions")
{
ApplicationArea = Basic, Suite;
Caption = 'Import Posted Transactions';
Visible = false;
}
}
group(Control8)
{
Expand Down
5 changes: 3 additions & 2 deletions src/Layers/NA/BaseApp/Bank/Reconciliation/BankAccReconciliation.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,7 @@ table 273 "Bank Acc. Reconciliation"
field(24; "Import Posted Transactions"; Option)
{
Caption = 'Import Posted Transactions';
ToolTip = 'Specifies whether to import bank transactions that are already applied but whose related bank account ledger entries are not yet closed.';
OptionCaption = ' ,Yes,No';
OptionMembers = " ",Yes,No;
}
Expand Down Expand Up @@ -413,8 +414,8 @@ table 273 "Bank Acc. Reconciliation"
/// </summary>
field(51; "Allow Duplicated Transactions"; Boolean)
{
Caption = 'Allow Duplicated Transactions';
ToolTip = 'Specifies whether to allow bank account reconciliation lines to have the same transaction ID. Although it’s rare, this is useful when your bank statement file contains transactions with duplicate IDs. Most businesses leave this toggle turned off.';
Caption = 'Import Duplicated Transactions';
ToolTip = 'Specifies whether to allow bank account reconciliation lines to have the same transaction ID.';
}
/// <summary>
/// Dimension set identifier linking this reconciliation to its dimension values.
Expand Down
12 changes: 12 additions & 0 deletions src/Layers/W1/BaseApp/Bank/Reconciliation/BankAccReconciliation.Page.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,18 @@ page 379 "Bank Acc. Reconciliation"
ApplicationArea = Basic, Suite;
Caption = 'Statement Ending Balance';
}
field(AllowDuplicatedTransactions; Rec."Allow Duplicated Transactions")
{
ApplicationArea = Basic, Suite;
Caption = 'Import Duplicated Transactions';
Visible = false;
}
field(ImportPostedTransactions; Rec."Import Posted Transactions")
{
ApplicationArea = Basic, Suite;
Caption = 'Import Posted Transactions';
Visible = false;
}
}
group(Control8)
{
Expand Down
5 changes: 3 additions & 2 deletions src/Layers/W1/BaseApp/Bank/Reconciliation/BankAccReconciliation.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,7 @@ table 273 "Bank Acc. Reconciliation"
field(24; "Import Posted Transactions"; Option)
{
Caption = 'Import Posted Transactions';
ToolTip = 'Specifies whether to import bank transactions that are already applied but whose related bank account ledger entries are not yet closed.';
OptionCaption = ' ,Yes,No';
OptionMembers = " ",Yes,No;
}
Expand Down Expand Up @@ -410,8 +411,8 @@ table 273 "Bank Acc. Reconciliation"
/// </summary>
field(51; "Allow Duplicated Transactions"; Boolean)
{
Caption = 'Allow Duplicated Transactions';
ToolTip = 'Specifies whether to allow bank account reconciliation lines to have the same transaction ID. Although it’s rare, this is useful when your bank statement file contains transactions with duplicate IDs. Most businesses leave this toggle turned off.';
Caption = 'Import Duplicated Transactions';
ToolTip = 'Specifies whether to allow bank account reconciliation lines to have the same transaction ID.';
}
/// <summary>
/// Dimension set identifier linking this reconciliation to its dimension values.
Expand Down
57 changes: 57 additions & 0 deletions src/Layers/W1/BaseApp/Bank/Reconciliation/PaymentReconciliationJournal.Page.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,6 +565,59 @@ page 1290 "Payment Reconciliation Journal"
end;
end;
}
action(AllowDuplicatedTransactions)
{
ApplicationArea = Basic, Suite;
Caption = 'Allow Duplicated Transactions';
Image = ChangeStatus;
ToolTip = 'Toggle whether transactions that have the same transaction ID can be imported into this journal.';

trigger OnAction()
var
ConfirmManagement: Codeunit "Confirm Management";
ChangeSettingQst: Text;
begin
InitializeBankAccRecon();

if BankAccReconciliation."Allow Duplicated Transactions" then
ChangeSettingQst := SkipDuplicatedTransactionsQst
else
ChangeSettingQst := AllowDuplicatedTransactionsQst;
if not ConfirmManagement.GetResponseOrDefault(ChangeSettingQst, false) then
exit;

BankAccReconciliation.Validate("Allow Duplicated Transactions", not BankAccReconciliation."Allow Duplicated Transactions");
BankAccReconciliation.Modify(true);
end;
}
action(ImportPostedTransactions)
{
ApplicationArea = Basic, Suite;
Caption = 'Import Posted Transactions';
Image = ChangeStatus;
ToolTip = 'Toggle whether transactions that are already applied, but whose related bank account ledger entries are not closed, can be imported into this journal.';

trigger OnAction()
var
ConfirmManagement: Codeunit "Confirm Management";
ChangeSettingQst: Text;
begin
InitializeBankAccRecon();

if BankAccReconciliation."Import Posted Transactions" = BankAccReconciliation."Import Posted Transactions"::Yes then
ChangeSettingQst := SkipPostedTransactionsQst
else
ChangeSettingQst := ImportPostedTransactionsQst;
if not ConfirmManagement.GetResponseOrDefault(ChangeSettingQst, false) then
exit;

if BankAccReconciliation."Import Posted Transactions" = BankAccReconciliation."Import Posted Transactions"::Yes then
BankAccReconciliation.Validate("Import Posted Transactions", BankAccReconciliation."Import Posted Transactions"::No)
else
BankAccReconciliation.Validate("Import Posted Transactions", BankAccReconciliation."Import Posted Transactions"::Yes);
BankAccReconciliation.Modify(true);
end;
}
action(ApplyAutomatically)
{
ApplicationArea = Basic, Suite;
Expand Down Expand Up @@ -1279,6 +1332,10 @@ page 1290 "Payment Reconciliation Journal"
ShowDetailsTxt: Label 'Open bank account card';
DisableNotificationTxt: Label 'Don''t show this again';
WouldYouLikeToRunMapTexttoAccountAgainQst: Label 'Do you want to re-apply the text to account mapping rules to all lines in the bank statement?';
AllowDuplicatedTransactionsQst: Label 'Transactions that have the same transaction ID are currently skipped when you import a bank statement into this journal. Do you want to import them?';
SkipDuplicatedTransactionsQst: Label 'Transactions that have the same transaction ID are currently considered when importing into this journal. Do you want to skip them instead?';
ImportPostedTransactionsQst: Label 'Transactions that are already applied, but whose related bank account ledger entries are not closed, are currently skipped when you import a bank statement into this journal. Do you want to import them?';
SkipPostedTransactionsQst: Label 'Transactions that are already applied, but whose related bank account ledger entries are not closed, are currently imported into this journal. Do you want to skip them instead?';
StatementEndingBalance: Text;

protected var
Expand Down
Loading