[FS] Prevent duplicate Field Service customer assets during item synchronization #11094
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -58,6 +58,13 @@ codeunit 139205 "FS Integration Test Library" | |
| FSIntTableSubscriber.UpdateQuantities(FSBookableResourceBooking, ServiceLine); | ||
| end; | ||
|
|
||
| procedure GetCustomerAssetConversion(ItemIsManaged: Boolean): Boolean | ||
| var | ||
| FSIntTableSubscriber: Codeunit "FS Int. Table Subscriber"; | ||
| begin | ||
| exit(FSIntTableSubscriber.GetCustomerAssetConversion(ItemIsManaged)); | ||
| end; | ||
|
|
||
| procedure IgnorePostedJobJournalLinesOnQueryPostFilterIgnoreRecord(SourceRecordRef: RecordRef; var IgnoreRecord: Boolean) | ||
| var | ||
| FSIntTableSubscriber: Codeunit "FS Int. Table Subscriber"; | ||
|
|
@@ -79,12 +86,17 @@ codeunit 139205 "FS Integration Test Library" | |
| FSIntTableSubscriber.IgnoreArchievedCRMWorkOrdersOnQueryPostFilterIgnoreRecord(SourceRecordRef, IgnoreRecord); | ||
| end; | ||
|
|
||
| /// <summary> | ||
| /// Retained for compatibility. Service items are now always synchronized to Field Service customer assets, so this procedure leaves the synchronization decision unchanged. | ||
| /// </summary> | ||
| /// <param name="SourceRecordRef">A reference to the service item to evaluate.</param> | ||
| /// <param name="IgnoreRecord">The existing synchronization decision, which is left unchanged.</param> | ||
| #pragma warning disable AS0105 | ||
| [Obsolete('Remove calls to this procedure. Service items are always synchronized to Field Service customer assets; item-product synchronization disables customer asset conversion.', '30.0')] | ||
|
tomasevicst marked this conversation as resolved.
tomasevicst marked this conversation as resolved.
Contributor
There was a problem hiding this comment. The public test-library procedure IgnoreServiceItemsByConvertToCustomerAssetFlag is newly marked [Obsolete(...,'30.0')], but its body was simultaneously replaced with a no-op instead of continuing to delegate to the prior logic. Any dependent app or test still calling this procedure during the deprecation window (before 30.0 removal) will silently stop having IgnoreRecord evaluated/set, changing observable runtime behavior while the symbol still compiles. Staged-obsoletion guidance expects the procedure to keep working during the deprecation window and only become an empty/removed stub at or after the tagged removal version. Suggested fix (apply manually — could not be anchored as a one-click suggestion): procedure IgnoreServiceItemsByConvertToCustomerAssetFlag(SourceRecordRef: RecordRef; var IgnoreRecord: Boolean)
var
FSIntTableSubscriber: Codeunit "FS Int. Table Subscriber";
begin
FSIntTableSubscriber.IgnoreServiceItemsByConvertToCustomerAssetFlag(SourceRecordRef, IgnoreRecord);
end;Knowledge:
👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.39.6
Contributor
There was a problem hiding this comment. The public procedure IgnoreServiceItemsByConvertToCustomerAssetFlag on the FS Integration Test Library codeunit was kept and marked [Obsolete(...,'30.0')], but its implementation was emptied instead of preserved. Emptying the body changes the procedure's observable behavior (IgnoreRecord is now always left unchanged) immediately for any remaining caller, rather than preserving prior behavior through the deprecation window until the tag's removal version. Prefer keeping the forwarding call to FSIntTableSubscriber.IgnoreServiceItemsByConvertToCustomerAssetFlag until the obsolete procedure is actually removed. Suggested fix (apply manually — could not be anchored as a one-click suggestion): procedure IgnoreServiceItemsByConvertToCustomerAssetFlag(SourceRecordRef: RecordRef; var IgnoreRecord: Boolean)
var
FSIntTableSubscriber: Codeunit "FS Int. Table Subscriber";
begin
FSIntTableSubscriber.IgnoreServiceItemsByConvertToCustomerAssetFlag(SourceRecordRef, IgnoreRecord);
end;Knowledge: 👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.40.6
Contributor
There was a problem hiding this comment.
Suggested fix (apply manually — could not be anchored as a one-click suggestion): procedure IgnoreServiceItemsByConvertToCustomerAssetFlag(SourceRecordRef: RecordRef; var IgnoreRecord: Boolean)
var
FSIntTableSubscriber: Codeunit "FS Int. Table Subscriber";
begin
FSIntTableSubscriber.IgnoreServiceItemsByConvertToCustomerAssetFlag(SourceRecordRef, IgnoreRecord);
end;Knowledge:
👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.41.6 |
||
| procedure IgnoreServiceItemsByConvertToCustomerAssetFlag(SourceRecordRef: RecordRef; var IgnoreRecord: Boolean) | ||
| begin | ||
| end; | ||
| #pragma warning restore AS0105 | ||
|
|
||
| procedure MarkArchivedServiceOrder(ServiceHeader: Record "Service Header") | ||
| var | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,7 +23,6 @@ using Microsoft.Purchases.Vendor; | |
| using Microsoft.Sales.Customer; | ||
| using Microsoft.Service.Archive; | ||
| using Microsoft.Service.Document; | ||
| using Microsoft.Service.Setup; | ||
| using Microsoft.Service.Test; | ||
| using Microsoft.TestLibraries.DynamicsFieldService; | ||
|
|
@@ -1578,109 +1577,79 @@ codeunit 139204 "FS Integration Test" | |
| end; | ||
|
|
||
| [Test] | ||
| [TransactionModel(TransactionModel::AutoCommit)] | ||
| procedure ItemSynchronizationDisablesCustomerAssetConversion() | ||
|
tomasevicst marked this conversation as resolved.
|
||
| var | ||
| Item: Record Item; | ||
| CRMProduct: Record "CRM Product"; | ||
|
tomasevicst marked this conversation as resolved.
|
||
| IntegrationTableMapping: Record "Integration Table Mapping"; | ||
| CRMIntegrationTableSynch: Codeunit "CRM Integration Table Synch."; | ||
| CRMSetupDefaults: Codeunit "CRM Setup Defaults"; | ||
| begin | ||
| // [FEATURE] [Item-Product Mapping] | ||
| // [SCENARIO] Synchronizing an item disables native Field Service customer asset creation. | ||
| Initialize(); | ||
| LibraryCRMIntegration.CreateCRMConnectionSetup('', '@@test@@', true); | ||
| InitSetup(true, ''); | ||
|
|
||
| // [GIVEN] A coupled item and product where Convert to Customer Asset is Yes. | ||
| CRMSetupDefaults.ResetItemProductMapping('ITEM-PRODUCT', false); | ||
|
Contributor
There was a problem hiding this comment. The new Item-to-CRM Product sync test ( Agent judgement — not directly backed by a BCQuality knowledge article. 👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.41.6 |
||
| LibraryCRMIntegration.CreateCoupledItemAndProduct(Item, CRMProduct); | ||
| CRMProduct.ConvertToCustomerAsset := true; | ||
| CRMProduct.Modify(); | ||
|
|
||
| IntegrationTableMapping.Get('ITEM-PRODUCT'); | ||
| Item.CalcFields("Coupled to Dataverse"); | ||
| Assert.IsTrue(Item."Coupled to Dataverse", 'The item should be identified as managed by its Dataverse coupling.'); | ||
|
|
||
| // [WHEN] The item is synchronized to the Field Service product. | ||
| CRMIntegrationTableSynch.SynchRecord(IntegrationTableMapping, Item.RecordId(), true, false); | ||
|
|
||
| // [THEN] Native Field Service customer asset creation is disabled. | ||
| CRMProduct.Get(CRMProduct.ProductId); | ||
| Assert.IsFalse(CRMProduct.ConvertToCustomerAsset, 'Convert to Customer Asset should be disabled.'); | ||
| end; | ||
|
|
||
| [Test] | ||
| [TransactionModel(TransactionModel::AutoRollback)] | ||
| procedure CustomerAssetConversionReflectsItemManagement() | ||
| begin | ||
| // [FEATURE] [Item-Product Mapping] | ||
| // [SCENARIO] Customer asset conversion is disabled only for items managed through synchronization. | ||
|
|
||
| // [WHEN] An item is not managed through synchronization. | ||
| // [THEN] Native Field Service customer asset conversion remains enabled. | ||
| Assert.IsTrue(FSIntegrationTestLibrary.GetCustomerAssetConversion(false), 'An unmanaged item should allow customer asset conversion.'); | ||
|
|
||
| // [WHEN] An item is managed through synchronization. | ||
| // [THEN] Native Field Service customer asset conversion is disabled. | ||
| Assert.IsFalse(FSIntegrationTestLibrary.GetCustomerAssetConversion(true), 'A managed item should disable customer asset conversion.'); | ||
| end; | ||
|
|
||
| [Test] | ||
| [TransactionModel(TransactionModel::AutoCommit)] | ||
|
tomasevicst marked this conversation as resolved.
|
||
| procedure ItemProductMappingDisablesCustomerAssetConversion() | ||
| var | ||
| Item: Record Item; | ||
| CRMProduct: Record "CRM Product"; | ||
| IntegrationFieldMapping: Record "Integration Field Mapping"; | ||
| CRMSetupDefaults: Codeunit "CRM Setup Defaults"; | ||
| begin | ||
| // [FEATURE] [Item-Product Mapping] | ||
| // [SCENARIO] The item-product mapping derives native Field Service customer asset creation from item management. | ||
| Initialize(); | ||
| InitSetup(true, ''); | ||
|
|
||
| // [WHEN] The default item-product mapping is reset. | ||
| CRMSetupDefaults.ResetItemProductMapping('ITEM-PRODUCT', false); | ||
|
|
||
| // [THEN] Convert to Customer Asset is mapped from the item's Dataverse coupling state in the outbound direction. | ||
| IntegrationFieldMapping.SetRange("Integration Table Mapping Name", 'ITEM-PRODUCT'); | ||
| IntegrationFieldMapping.SetRange("Integration Table Field No.", CRMProduct.FieldNo(ConvertToCustomerAsset)); | ||
| Assert.IsTrue(IntegrationFieldMapping.FindFirst(), 'The Convert to Customer Asset mapping should exist.'); | ||
| Assert.AreEqual(Item.FieldNo("Coupled to Dataverse"), IntegrationFieldMapping."Field No.", 'The mapping should use the item coupling state.'); | ||
| Assert.AreEqual(IntegrationFieldMapping.Direction::ToIntegrationTable, IntegrationFieldMapping.Direction, 'The mapping should be outbound.'); | ||
| Assert.AreEqual('', IntegrationFieldMapping."Constant Value", 'The mapping should not use a constant value.'); | ||
| end; | ||
|
|
||
| local procedure Initialize() | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The obsolete public test-library procedure
IgnoreServiceItemsByConvertToCustomerAssetFlag(Microsoft.TestLibraries.DynamicsFieldService, FSIntegrationTestLibrary.Codeunit.al) is correctly marked[Obsolete('...', '30.0')], but its body was replaced with an empty no-op instead of continuing to forward to the previous implementation. During the deprecation window, existing external callers who still invoke this public procedure expectingIgnoreRecordto be set now silently receive unchanged behavior. Guidance on deprecating public members with the Obsolete lifecycle recommends preserving the prior behavior (e.g., keep forwarding to the codeunit's still-present implementation, or otherwise retain the previous decision) until the procedure is actually removed in a later release, rather than emptying it immediately upon obsoletion.Knowledge:
👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.41.6