[29.x]Adjustment Amount is not accurate in the Exch. Rate Adjmt. Ledger Entries page if an Unrealized Gain gest registered and a second adjustment turns into a Loss. - #11163
Conversation
Good Sense Reviewer - Round 1Recommendation: AcceptWhat this PR doesThis PR fixes exchange rate adjustment ledger entries so customer, vendor, and employee rows store the amount from their own linked detailed ledger entry. That fits the bug where a second adjustment reverses an unrealized gain and records a higher loss, because the page now shows each detailed entry amount instead of the running adjustment amount. It also improves the ledger entries page formatting for the currency factor, register number caption, and detailed ledger entry number. The added vendor test covers the reversal-to-higher-loss case and checks every adjustment ledger entry against its linked detailed vendor ledger entry. Review observationsNone - I found no blocking or non-blocking suggestions. Two independent analysis passes agreed that the production change matches the linked detailed-entry data and the test covers the reported money-sensitive path. Risk assessment and necessityRisk: This is a financial reporting and audit trail path, so an incorrect amount can mislead users when they reconcile exchange rate adjustments. The change is narrow: it only changes the stored adjustment amount on the temporary adjustment ledger rows for customer, vendor, and employee entries, and it keeps the bank account path on the existing calculated amount because there is no linked detailed CV/employee entry. Necessity: The fix is needed because the ledger entry page must show the amount of the specific detailed ledger entry that each row references. The scope is appropriate for a bug fix, and the analogous customer, vendor, and employee paths are kept consistent in W1 and RU.
|
Workitem: Bug 649336: [29.x][all-e]Adjustment Amount is not accurate in the Exch. Rate Adjmt. Ledger Entries page if an Unrealized Gain gest registered and a second adjustment turns into a Loss.
Fixes AB#649336
Issue: Exch. Rate Adjmt. Ledger Entry "Adjustment Amount" is wrong when an unrealized gain reverses into a higher loss.
Cause: Codeunit 699 wrote the accumulated CurrAdjAmount into every per-detail row instead of the amount of the detailed entry that row is linked to.
Solution: Set "Adjustment Amount" from each row's own linked detailed entry Amount (LCY), plus page 186 decimal/caption fixes.