Skip to content

[29.x]Adjustment Amount is not accurate in the Exch. Rate Adjmt. Ledger Entries page if an Unrealized Gain gest registered and a second adjustment turns into a Loss. - #11163

Open
Fixes4BC (neeleshsinghal) wants to merge 2 commits into
releases/29.xfrom
bugs/Bug-649336-Adjustment-Amount-is-not-accurate-in-the-Exch-Rate-Adjmt
Open

[29.x]Adjustment Amount is not accurate in the Exch. Rate Adjmt. Ledger Entries page if an Unrealized Gain gest registered and a second adjustment turns into a Loss.#11163
Fixes4BC (neeleshsinghal) wants to merge 2 commits into
releases/29.xfrom
bugs/Bug-649336-Adjustment-Amount-is-not-accurate-in-the-Exch-Rate-Adjmt

Conversation

@neeleshsinghal

@neeleshsinghal Fixes4BC (neeleshsinghal) commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Workitem: Bug 649336: [29.x][all-e]Adjustment Amount is not accurate in the Exch. Rate Adjmt. Ledger Entries page if an Unrealized Gain gest registered and a second adjustment turns into a Loss.

Fixes AB#649336

Issue: Exch. Rate Adjmt. Ledger Entry "Adjustment Amount" is wrong when an unrealized gain reverses into a higher loss.

Cause: Codeunit 699 wrote the accumulated CurrAdjAmount into every per-detail row instead of the amount of the detailed entry that row is linked to.

Solution: Set "Adjustment Amount" from each row's own linked detailed entry Amount (LCY), plus page 186 decimal/caption fixes.

@neeleshsinghal
Fixes4BC (neeleshsinghal) requested a review from a team September 7, 2026 17:00
@neeleshsinghal
Fixes4BC (neeleshsinghal) requested a review from a team as a code owner September 7, 2026 17:00
@github-actions github-actions Bot added the Team: Finance GitHub request for Finance area label Sep 7, 2026
@github-actions github-actions Bot added this to the Version 29.1 milestone Sep 7, 2026
@alexei-dobriansky

Copy link
Copy Markdown
Contributor

Good Sense Reviewer - Round 1

Recommendation: Accept

What this PR does

This PR fixes exchange rate adjustment ledger entries so customer, vendor, and employee rows store the amount from their own linked detailed ledger entry. That fits the bug where a second adjustment reverses an unrealized gain and records a higher loss, because the page now shows each detailed entry amount instead of the running adjustment amount.

It also improves the ledger entries page formatting for the currency factor, register number caption, and detailed ledger entry number. The added vendor test covers the reversal-to-higher-loss case and checks every adjustment ledger entry against its linked detailed vendor ledger entry.

Review observations

None - I found no blocking or non-blocking suggestions. Two independent analysis passes agreed that the production change matches the linked detailed-entry data and the test covers the reported money-sensitive path.

Risk assessment and necessity

Risk: This is a financial reporting and audit trail path, so an incorrect amount can mislead users when they reconcile exchange rate adjustments. The change is narrow: it only changes the stored adjustment amount on the temporary adjustment ledger rows for customer, vendor, and employee entries, and it keeps the bank account path on the existing calculated amount because there is no linked detailed CV/employee entry.

Necessity: The fix is needed because the ledger entry page must show the amount of the specific detailed ledger entry that each row references. The scope is appropriate for a bug fix, and the analogous customer, vendor, and employee paths are kept consistent in W1 and RU.


[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=11163 round=1 by=alexei-dobriansky at=2026-09-07T19:41:29Z lastSha=81fa8efddafccc447f3120def3d526a0315a2e4b reviewKey=e294bf50f90b54756c7e1ea3719211fad33f57c17cadf0547a3f41eed75a44a6 suggestions=

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team: Finance GitHub request for Finance area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants