Skip to content

[29.x][All-e][SaaS] Last name of the employee relative is not editable when customized using “Profile (Role)” - #11214

Open
sanjmaurya wants to merge 3 commits into
releases/29.xfrom
bugs/Bug-649427-29x-LastnameTheemployeeRelativeIsNoteditable
Open

[29.x][All-e][SaaS] Last name of the employee relative is not editable when customized using “Profile (Role)”#11214
sanjmaurya wants to merge 3 commits into
releases/29.xfrom
bugs/Bug-649427-29x-LastnameTheemployeeRelativeIsNoteditable

Conversation

@sanjmaurya

@sanjmaurya sanjmaurya commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Bug 649427: [29.x][All-e][SaaS] Last name of the employee relative is not editable when customized using “Profile (Role)”.

Fixes AB#649427

Issue:
The Last Name field is not available on the Employee Relatives page, so users cannot view or edit an employee relative’s last name.

Cause:
The Employee Relative table contains the Last Name field, but the field was not included in the page layout.

Solution:
Added the Last Name field to the Employee Relatives page and added an automated UI test to verify that the value can be edited and saved successfully.

@github-actions github-actions Bot added the Team: SCM GitHub request for SCM area label Sep 8, 2026
@github-actions github-actions Bot added this to the Version 29.1 milestone Sep 8, 2026
@sanjmaurya
sanjmaurya marked this pull request as ready for review September 9, 2026 11:33
@sanjmaurya
sanjmaurya requested a review from a team September 9, 2026 11:33
@sanjmaurya
sanjmaurya requested a review from a team as a code owner September 9, 2026 11:33
@alexei-dobriansky

Copy link
Copy Markdown
Contributor

Good Sense Reviewer - Round 1

Recommendation: Accept

What this PR does

This change makes the employee relative surname field editable from the Employee Relatives page. In W1 the page now includes the existing Last Name table field, and in ES the equivalent First Family Name control now uses the BasicHR application area so it is available with the rest of the HR fields.

The fix matches the reported UI gap. The page fields bind directly to the existing table fields, the controls are editable by default, and the added UI tests edit the value through the page and verify that it is saved. The W1 and ES page/table variants were checked; no event publisher or subscriber dependency is involved.

Problem-solution fit

Fit: Strong

The reported scenario is that the surname value exists on the employee relative record but cannot be edited from the page/profile flow. The change exposes the exact field in W1 and fixes the application-area mismatch for the equivalent ES field, so the code change matches the problem without broad side effects.

Suggestions

No suggestions.

Risk assessment and necessity

Risk: Low. The change is limited to page controls, table tooltips, and focused test coverage for employee relatives. It does not change posting, amounts, ledger entries, public APIs, events, or data upgrade behavior.

Necessity: The change is needed because users need to edit an existing surname field in the affected UI flow. The scope is targeted to the W1 and ES page/table variants and the matching tests for W1, ES, CZ, and RU.


[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=11214 round=1 by=alexei-dobriansky at=2026-09-09T12:27:16.6351419Z lastSha=ebf34e4b474b0a31d7475f44ff10279ebb9d0409 reviewKey=003aad1ad69027d46ef620263c33eb135f88e8ed1e9e11f8d067b8390a67123e suggestions=

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team: SCM GitHub request for SCM area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants