refactor(client): make compatibility choices explicit by WillieHabi · Pull Request #28025 · microsoft/FluidFramework

WillieHabi · 2026-08-20T03:47:09Z

Description

Moves in-repo runtime callers to explicit compatibility choices while the customer-facing APIs are still optional.

Generic test infrastructure uses a shared historical-default constant, preserving the behavior callers received when they omitted the property.
Examples use 3.0.0 unless a test or feature requires a documented older floor. Packages that
already depend on @fluid-example/example-utils share a common constant; other packages retain
the literal rather than adding a dependency solely for that constant.
ContainerRuntimeFactoryWithDefaultDataStoreProps additively exposes the optional compatibility properties already supported by its base factory.
Back-compat test helpers model the canonical and deprecated constructor overloads separately.

This is a nonbreaking, mechanical preparation for PR #27971. It intentionally contains no snapshot-comparison changes, compatibility-validation changes, or removal of the historical default. AB#42061

Jason Hartman (jason-ha)

This is just a partial review.
There are lots of literal versions without clarity on how they are chosen or managed.

Jason Hartman (jason-ha) · 2026-08-20T07:51:25Z

 	const tableDocumentFactory = TableDocument.getFactory();
 	const runtimeFactory = new ContainerRuntimeFactoryWithDefaultDataStore({
 		defaultFactory: tableDocumentFactory,
+		oldestSupportedClient: "3.0.0",


exampleOldestSupportedClient?

So, every bump should update this?
Isn't that what pkgVersion is for?

added its own generated pkgVersion and now use that for oldestSupportedClient so future version bumps will update this automatically.

Jason Hartman (jason-ha) · 2026-08-20T08:08:58Z

 			const runtime = await loadContainerRuntime({
 				context,
 				existing,
+				oldestSupportedClient: "2.40.0",


Should be commented

// createBlobPayloadPending requires runtime 2.40 or later.

Can you say a little more? Why isn't a more recent value chosen?

Added comment:

// 2.40 is the oldest runtime that understands the document format written when // createBlobPayloadPending is enabled; choosing a newer version would unnecessarily // reduce the clients that this stress test can interoperate with.

Jason Hartman (jason-ha) · 2026-08-20T08:41:54Z

 ): IRuntimeFactory => {
 	try {
-		return new ctor(ctorProps);
+		const currentCtor = ctor as new (


questionable cast.?

Added a comment

This cast is needed because this back-compat helper receives constructors loaded from multiple package versions with different signatures, and ts can't narrow that constructor union at runtime. comment explains that we first try current object shape, then retain the existing positional fallback for older constructors.

No version needs minVersionForCollab (for some back-compat cases)?
Because it never had proper support and only now does?

Right sorry no historical constructuor requires minVersionForCollab. it looks like constructors before 2.0.0-internal.7.0.0 use the positional shape and arity 3. and then up to 2.116 use object props (arity 1). we verify this against all installed compat packages.

the helper now selects the constructor shape before calling it and rejects unknown arities.

Jason Hartman (jason-ha) · 2026-08-21T10:27:37Z

 ): IRuntimeFactory => {
 	try {
-		return new ctor(ctorProps);
+		const currentCtor = ctor as new (


No version needs minVersionForCollab (for some back-compat cases)?
Because it never had proper support and only now does?

github-actions · 2026-08-21T19:05:54Z

Hi! Thank you for opening this PR. Want me to review it?

Based on the diff (572 lines, 95 files), I've queued these reviewers:

Correctness — logic errors, race conditions, lifecycle issues
Security — vulnerabilities, secret exposure, injection
API Compatibility — breaking changes, release tags, type design
Performance — algorithmic regressions, memory leaks
Testing — coverage gaps, hollow tests

How this works

Adjust the reviewer set by ticking/unticking boxes above. Reviewer toggles alone don't trigger anything.
Tick Start review below to dispatch the review fleet.
After review finishes, tick Start review again to request another run — it auto-resets after each dispatch.
This comment updates as new commits land; your reviewer selections are preserved.
Start review

Copilot

Pull request overview

This PR refactors in-repo runtime construction to make compatibility choices explicit (primarily via oldestSupportedClient), while preserving historical default behavior for generic test and example infrastructure. It also updates Aqueduct’s legacy beta default-data-store factory props to surface the base factory’s compatibility options and wires new shared constants through tests/examples.

Changes:

Centralize and apply historical-default compatibility constants (defaultTestOldestSupportedClient, exampleOldestSupportedClient) across tests, tools, and examples.
Update various runtime factory call sites to pass explicit oldestSupportedClient / minVersionForCollab with documented floors where required (e.g., 2.40.0, 2.80).
Add/adjust back-compat helper logic and tests for ContainerRuntimeFactoryWithDefaultDataStore constructor shapes; update Aqueduct legacy beta API surface + changeset.

Reviewed changes

Copilot reviewed 80 out of 81 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
pnpm-lock.yaml	Workspace dependency updates
packages/tools/fluid-runner/src/test/sampleCodeLoaders/sampleCodeLoader.ts	Explicit historical default floor
packages/test/test-utils/src/testContainerRuntimeFactoryWithDefaultDataStore.ts	Back-compat ctor selection logic
packages/test/test-utils/src/testContainerRuntimeFactory.ts	Default compatibility constant usage
packages/test/test-utils/src/test/testContainerRuntimeFactoryWithDefaultDataStore.spec.ts	New tests for ctor-shape helper
packages/test/test-utils/src/index.ts	Export defaultTestOldestSupportedClient
packages/test/test-utils/src/containerRuntimeFactories.ts	Centralize defaultTestOldestSupportedClient
packages/test/test-service-load/src/loadTestDataStore.ts	Conditional compatibility floor (2.40)
packages/test/test-end-to-end-tests/src/test/summarization/summarizeWithSearch.spec.ts	Explicit oldestSupportedClient in tests
packages/test/test-end-to-end-tests/src/test/summarization/summarizeWithLocalChanges.spec.ts	Explicit oldestSupportedClient in tests
packages/test/test-end-to-end-tests/src/test/summarization/summarizeIncrementallySubDds.spec.ts	Explicit oldestSupportedClient in tests
packages/test/test-end-to-end-tests/src/test/summarization/summaries.spec.ts	Explicit oldestSupportedClient in tests
packages/test/test-end-to-end-tests/src/test/stagingMode.spec.ts	Explicit oldestSupportedClient in tests
packages/test/test-end-to-end-tests/src/test/pointInTime/pointInTimeTestUtils.ts	Explicit oldestSupportedClient in helpers
packages/test/test-end-to-end-tests/src/test/opBunching.spec.ts	Explicit oldestSupportedClient in tests
packages/test/test-end-to-end-tests/src/test/offline/stashedOps.spec.ts	Explicit minVersionForCollab (2.40)
packages/test/test-end-to-end-tests/src/test/migration-shim/storingHandlesDetached.spec.ts	Explicit oldestSupportedClient in tests
packages/test/test-end-to-end-tests/src/test/migration-shim/storingHandles.spec.ts	Explicit oldestSupportedClient in tests
packages/test/test-end-to-end-tests/src/test/migration-shim/stampedV2Ops.spec.ts	Explicit oldestSupportedClient in tests
packages/test/test-end-to-end-tests/src/test/migration-shim/sharedTreeShim.spec.ts	Explicit oldestSupportedClient in tests
packages/test/test-end-to-end-tests/src/test/migration-shim/reconnect.spec.ts	Explicit oldestSupportedClient in tests
packages/test/test-end-to-end-tests/src/test/migration-shim/migrationShim.spec.ts	Explicit oldestSupportedClient in tests
packages/test/test-end-to-end-tests/src/test/migration-shim/dataMigration.spec.ts	Explicit oldestSupportedClient in tests
packages/test/test-end-to-end-tests/src/test/localLoader.spec.ts	Explicit oldestSupportedClient in tests
packages/test/test-end-to-end-tests/src/test/loadModes.spec.ts	Explicit oldestSupportedClient in tests
packages/test/test-end-to-end-tests/src/test/entryPointCompat.spec.ts	Explicit oldestSupportedClient in tests
packages/test/test-end-to-end-tests/src/test/deRehydrateContainerTests.spec.ts	Explicit oldestSupportedClient in tests
packages/test/test-end-to-end-tests/src/test/deltaManagerProxy.spec.ts	Explicit oldestSupportedClient in tests
packages/test/test-end-to-end-tests/src/test/dataStoresNested.spec.ts	Explicit oldestSupportedClient in tests
packages/test/test-end-to-end-tests/src/test/data-virtualization/noGroupIdOfflineFlow.spec.ts	Explicit oldestSupportedClient in tests
packages/test/test-end-to-end-tests/src/test/data-virtualization/loadNewerGroupIdSnapshot.spec.ts	Explicit oldestSupportedClient in tests
packages/test/test-end-to-end-tests/src/test/data-virtualization/groupIdOffline.spec.ts	Explicit oldestSupportedClient in tests
packages/test/test-end-to-end-tests/src/test/data-virtualization/groupIdInSummary.spec.ts	Explicit oldestSupportedClient in tests
packages/test/test-end-to-end-tests/src/test/benchmark/DocumentMultipleDataStores.ts	Explicit oldestSupportedClient in benchmarks
packages/test/test-end-to-end-tests/src/test/benchmark/DocumentMatrixPlain.ts	Explicit oldestSupportedClient in benchmarks
packages/test/test-end-to-end-tests/src/test/benchmark/DocumentMatrix.ts	Explicit oldestSupportedClient in benchmarks
packages/test/test-end-to-end-tests/src/test/benchmark/DocumentMap.ts	Explicit oldestSupportedClient in benchmarks
packages/test/test-end-to-end-tests/src/test/attachLegacyTree.spec.ts	Explicit oldestSupportedClient in tests
packages/test/test-end-to-end-tests/src/test/aliasWithProps.spec.ts	Explicit oldestSupportedClient in tests
packages/test/local-server-tests/src/test/utils.ts	Explicit oldestSupportedClient in loader
packages/test/local-server-tests/src/test/synchronousDataStoreCreation.spec.ts	Explicit oldestSupportedClient in tests
packages/test/local-server-tests/src/test/stagingMode.spec.ts	Explicit oldestSupportedClient in tests
packages/test/local-server-tests/src/test/sharedTreeConstraints.spec.ts	Align DDS/runtime floors (2.80)
packages/test/local-server-tests/src/test/readonly.spec.ts	Explicit oldestSupportedClient in tests
packages/test/local-server-tests/src/test/opsOnReconnect.spec.ts	Explicit oldestSupportedClient in tests
packages/test/local-server-tests/src/test/loadFrozenContainerFromPendingState.spec.ts	Conditional compatibility floor (2.40)
packages/test/local-server-tests/src/test/documentStagedChanges.spec.ts	Explicit oldestSupportedClient in tests
packages/test/local-server-tests/src/test/documentDirty.spec.ts	Explicit oldestSupportedClient in tests
packages/test/local-server-tests/src/test/data-migration/oldCode.ts	Explicit oldestSupportedClient in test code
packages/test/local-server-tests/src/test/data-migration/newCode.ts	Explicit oldestSupportedClient in test code
packages/test/local-server-tests/src/test/data-migration/basicMigration.spec.ts	Explicit oldestSupportedClient in tests
packages/test/local-server-tests/src/test/connectionMode.spec.ts	Explicit oldestSupportedClient in tests
packages/test/local-server-tests/src/test/audience.spec.ts	Explicit oldestSupportedClient in tests
packages/test/local-server-stress-tests/src/test/stressDataObject.ts	Explicit oldestSupportedClient (2.40)
packages/test/functional-tests/src/test/containerRuntime.spec.ts	Explicit oldestSupportedClient in unit tests
packages/test/functional-tests/package.json	Add runtime-utils dependency
packages/framework/fluid-static/src/rootDataObject.ts	Use oldestSupportedClient explicitly
packages/framework/aqueduct/src/container-runtime-factories/containerRuntimeFactoryWithDefaultDataStore.ts	Extend base props + compat props
packages/framework/aqueduct/api-report/aqueduct.legacy.beta.api.md	Generated API surface update
packages/drivers/local-driver/src/ephemeralService.ts	Map minVersionForCollab to oldestSupportedClient
examples/view-integration/external-views/src/container/runtimeFactory.ts	Use exampleOldestSupportedClient
examples/view-integration/external-views/package.json	Depend on example-utils
examples/utils/migration-tools/src/compositeRuntime/loadCompositeRuntime.ts	Use exampleOldestSupportedClient
examples/utils/migration-tools/package.json	Depend on example-utils
examples/utils/example-utils/src/modelLoader/modelContainerRuntimeFactory.ts	Use exampleOldestSupportedClient
examples/utils/example-utils/src/index.ts	Export exampleOldestSupportedClient
examples/utils/example-utils/src/exampleCompatibility.ts	New shared example compat constant
examples/utils/example-utils/src/containerViewRuntimeFactory.ts	Use exampleOldestSupportedClient
examples/utils/bundle-size-tests/src/aqueduct.ts	Use exampleOldestSupportedClient
examples/utils/bundle-size-tests/package.json	Depend on example-utils
examples/data-objects/table-document/src/test/localServerTestUtils.ts	Explicit oldestSupportedClient (3.0.0)
examples/data-objects/smde/src/index.ts	Use exampleOldestSupportedClient
examples/data-objects/prosemirror/src/index.ts	Use exampleOldestSupportedClient
examples/data-objects/multiview/container/src/container.tsx	Use exampleOldestSupportedClient
examples/data-objects/codemirror/src/index.ts	Use exampleOldestSupportedClient
examples/apps/staging/src/container/runtimeFactory.ts	Use exampleOldestSupportedClient
examples/apps/claims-example/src/container/runtimeFactory.ts	Use exampleOldestSupportedClient
examples/apps/claims-example/package.json	Depend on example-utils
examples/apps/blobs/src/container/runtimeFactory.ts	Use exampleOldestSupportedClient
examples/apps/blobs/package.json	Depend on example-utils
.changeset/jolly-shoes-smile.md	Changeset for Aqueduct API update

Files not reviewed (1)

pnpm-lock.yaml: Generated file

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Jason Hartman (jason-ha) · 2026-08-23T16:23:48Z

 	const tableDocumentFactory = TableDocument.getFactory();
 	const runtimeFactory = new ContainerRuntimeFactoryWithDefaultDataStore({
 		defaultFactory: tableDocumentFactory,
+		oldestSupportedClient: "3.0.0",


So, every bump should update this?
Isn't that what pkgVersion is for?

Jason Hartman (jason-ha) · 2026-08-23T16:35:35Z

 			const runtime = await loadContainerRuntime({
 				context,
 				existing,
+				oldestSupportedClient: "2.40.0",


Can you say a little more? Why isn't a more recent value chosen?

Jason Hartman (jason-ha) · 2026-08-23T16:40:13Z

+ * Compatibility value for generic tests that previously relied on the runtime's implicit default.
+ * Keeping it centralized preserves existing test behavior and simplifies future replacement.


nit: this comment is written just a bit in the context of change and not in the context of anyone reading the code as it is.

I moved the constant rewrote the comment in more steady terms:

/** * Canonical compatibility setting for generic tests that exercise the runtime's historical * implicit defaults. Tests for a specific feature should instead use that feature's minimum * supported client version. * * @internal */

Jason Hartman (jason-ha) · 2026-08-23T18:09:32Z

+						oldestSupportedClient: options.createBlobPayloadPending
+							? "2.40.0"
+							: defaultTestOldestSupportedClient,


To confirm what was happening here before, there was no version set so the minimum was effectively 2.40 from the option (when set) but that was never explicit in document storage?
OR was the minimum computed from the options and set in document?
Worth a note or guard for the future that when default is 2.40 or higher this can be removed?

The runtime was not computing 2.40 from the option. With no explicit value it used 2.0.0-defaults (option-floor validation is intentionally skipped). The document stored 2.0.0-defaults as its informational minimum and separately stored createBlobPayloadPending: true in the runtime schema.

The pending-payload case now explicitly uses 2.40, while the legacy case retains 2.0.0-defaults. I added that comment beside the conditional.

Jason Hartman (jason-ha) · 2026-08-23T18:35:41Z

 	 *
 	 * @remarks
 	 * The property name is retained while the cross-layer dual-property migration in
 	 * {@link https://github.com/microsoft/FluidFramework/issues/27851} is completed.
 	 */
 	readonly minVersionForCollab?: OldestSupportedClientVersion;
 }

 /**
 * A ContainerRuntimeFactory that initializes Containers with a single default data store, which can be requested from
 * the container with an empty URL.
 *
 * @deprecated
 * Do not reference this type directly. It will be removed in the future.
 * E.g. use {@link IRuntimeFactory} instead.
 */
 export class ContainerRuntimeFactoryWithDefaultDataStore


Joshua Smithrud (@Josmithr), what is the story for this class? It was deprecated 17 months ago. It looks like it was put into use twice in the PR with deprecation.
(WillieHabi, might be better to have your default in a different file since the suggestion is that this whole file goes away when class is not longer needed.)

I moved it to testCompatibility.ts and left removal of the deprecated factory itself as a separate cleanup.

Jason Hartman (jason-ha) · 2026-08-23T18:39:26Z

+	  ) => IRuntimeFactory)
+	| (new (
+			props: ContainerRuntimeFactoryWithDefaultDataStoreProps & {
+				readonly oldestSupportedClient: OldestSupportedClientVersion;


oldestSupportedClient shouldn't just be a part of ContainerRuntimeFactoryWithDefaultDataStoreProps?
There may be comments lacking here and/or for ContainerRuntimeFactoryWithDefaultDataStoreProps.

Ok yes, that is now part of ContainerRuntimeFactoryWithDefaultDataStoreProps and documented there. Callers pass defaultTestOldestSupportedClient explicitly and object constructors receive the props directly. The helper restricts the value to the historical test default.

Jason Hartman (jason-ha) · 2026-08-23T18:49:22Z

+export type ContainerRuntimeFactoryWithDefaultDataStoreConstructor = (
+	| (new (
+			props: ContainerRuntimeFactoryWithDefaultDataStoreProps,
+	  ) => IRuntimeFactory)
+	| (new (
+			props: ContainerRuntimeFactoryWithDefaultDataStoreProps & {
+				readonly oldestSupportedClient: OldestSupportedClientVersion;
+			},
+	  ) => IRuntimeFactory)
+	| (new (
+			defaultFactory: IFluidDataStoreFactory,
+			registryEntries: NamedFluidDataStoreRegistryEntries,
+			dependencyContainer?: never,
+			// eslint-disable-next-line import-x/no-deprecated
+			requestHandlers?: RuntimeRequestHandler[],
+			runtimeOptions?: IContainerRuntimeOptions,
+			provideEntryPoint?: (runtime: IContainerRuntime) => Promise<FluidObject>,
+	  ) => IRuntimeFactory)
+) & { readonly length: number };


I see a lot of duplication. Is that to avoid exporting the two sub-types?
Either just export the two-subtypes or use type filtering to extract them where needed.

Maybe these just need better specified. Associate readonly length: 1 with object versions and readonly length : 6 with the other? (I didn't know these would have a length property. Is 6 right? Or 2| 3 | 4 | 5 | 6? Where does arity 3 come from required plus first optional?)

I simplified this so the constructor union is defined once, then derive the object + positional shapes with Extract and Exclude . Also added type guards narrow them to arity 1 or 3 so the casts are no longer needed.

The positional constructor has arity 3 because JavaScript’s Function.length stops counting at the first parameter with a default value, and requestHandlers = [] is the fourth parameter: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/length (weird)
Every installed compatibility constructor reports either 1 or 3.

Jason Hartman (jason-ha) · 2026-08-23T18:54:02Z

+	it("constructs historical object-shaped factories", () => {
+		let receivedProps: ContainerRuntimeFactoryWithDefaultDataStoreProps | undefined;
+		class HistoricalObjectFactory extends TestRuntimeFactory {


This seems useless.
See other comment wondering why there is no oldestSuportedClient property

I collapsed the two object-shaped tests into one that verifies the explicit compatibility setting.

Migrate in-repo runtime factories before requiredness changes, preserve historical test behavior through shared constants, and use the current Client version consistently in examples. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1ea3a180-8445-43b1-9fc0-78bbc399b8d3

Model overloaded Aqueduct constructors in compatibility test helpers and document canonical calls where the deprecated overload marks the shared symbol. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1ea3a180-8445-43b1-9fc0-78bbc399b8d3

Place lint suppressions on the overloaded import specifiers so canonical calls remain clean once the deprecated compatibility overload is introduced. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1ea3a180-8445-43b1-9fc0-78bbc399b8d3

Remove suppressions that should not be required by the preferred API and preserve the historical defaults in generic fluid-runner test collateral. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1ea3a180-8445-43b1-9fc0-78bbc399b8d3

Use the 2.40 compatibility floor only for option combinations that enable createBlobPayloadPending and preserve historical defaults otherwise. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1ea3a180-8445-43b1-9fc0-78bbc399b8d3

Use a maintained example baseline, document intentional feature floors and test defaults, and clarify the versioned constructor compatibility cast. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1ea3a180-8445-43b1-9fc0-78bbc399b8d3

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1ea3a180-8445-43b1-9fc0-78bbc399b8d3

github-actions · 2026-08-24T20:48:50Z

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output

$ start-server-and-test "npm run serve -- --host 127.0.0.1 --no-open" http://127.0.0.1:3000 check-links
1: starting server using command "npm run serve -- --host 127.0.0.1 --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> fluid-framework-website@0.0.0 serve
> docusaurus serve --host 127.0.0.1 --no-open

[SUCCESS] Serving "build" directory at: http://127.0.0.1:3000/

> fluid-framework-website@0.0.0 check-links
> linkcheck http://127.0.0.1:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  338440 links
    2041 destination URLs
    2297 URLs ignored
       0 warnings
       0 errors

github-actions · 2026-08-24T21:19:30Z

Bundle size comparison

Base commit: f8bcc56859fc51957d45453bcf59ce154a2e0c18
Head commit: 5160c192f3ca3e5ce9012f4189edf262b2854c9d

Pending — Build - client packages is running. Results will appear here when the build completes.

WillieHabi requested review from a team as code owners August 20, 2026 03:47

WillieHabi force-pushed the test/client/3.0/prepare-oldest-supported-client-plumbing branch from 3a4b842 to 4be180a Compare August 20, 2026 14:49

WillieHabi force-pushed the test/client/3.0/prepare-oldest-supported-client-callers branch from 93cf143 to c7f882a Compare August 20, 2026 14:49

Jason Hartman (jason-ha) reviewed Aug 20, 2026

View reviewed changes

WillieHabi requested a review from Jason Hartman (jason-ha) August 20, 2026 18:03

Jason Hartman (jason-ha) reviewed Aug 21, 2026

View reviewed changes

WillieHabi force-pushed the test/client/3.0/prepare-oldest-supported-client-callers branch from e58641c to 8334b1d Compare August 21, 2026 16:21

WillieHabi force-pushed the test/client/3.0/prepare-oldest-supported-client-plumbing branch from e349f88 to 755bc3c Compare August 21, 2026 16:25

WillieHabi force-pushed the test/client/3.0/prepare-oldest-supported-client-callers branch 2 times, most recently from 205d72e to d2c51b3 Compare August 21, 2026 16:37

WillieHabi force-pushed the test/client/3.0/prepare-oldest-supported-client-plumbing branch from 36c163d to 251022a Compare August 21, 2026 16:56

WillieHabi force-pushed the test/client/3.0/prepare-oldest-supported-client-callers branch from d2c51b3 to c542c64 Compare August 21, 2026 16:57

WillieHabi mentioned this pull request Aug 21, 2026

Require oldestSupportedClient (formerly minVersionForCollab) in Client 3.0 #27180

Open

WillieHabi force-pushed the test/client/3.0/prepare-oldest-supported-client-callers branch 2 times, most recently from fa69b50 to e515d4a Compare August 21, 2026 18:05

Base automatically changed from test/client/3.0/prepare-oldest-supported-client-plumbing to main August 21, 2026 18:45

WillieHabi force-pushed the test/client/3.0/prepare-oldest-supported-client-callers branch from e515d4a to aaaaefe Compare August 21, 2026 19:04

Copilot AI lite review requested due to automatic review settings August 21, 2026 19:23

Copilot started reviewing on behalf of WillieHabi August 21, 2026 19:24 View session

Copilot AI reviewed Aug 21, 2026

View reviewed changes

Comment thread packages/test/test-utils/src/testContainerRuntimeFactoryWithDefaultDataStore.ts Outdated

WillieHabi requested a review from Jason Hartman (jason-ha) August 21, 2026 20:39

Jason Hartman (jason-ha) reviewed Aug 23, 2026

View reviewed changes

WillieHabi and others added 11 commits August 24, 2026 13:18

docs(test): clarify compatibility default comment

04ded11

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1ea3a180-8445-43b1-9fc0-78bbc399b8d3

fix(client): address caller migration review feedback

22a79e6

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1ea3a180-8445-43b1-9fc0-78bbc399b8d3

fix(test): select backcompat runtime factory signature explicitly

4359ce5

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1ea3a180-8445-43b1-9fc0-78bbc399b8d3

refactor(examples): share current compatibility value

7078b4b

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1ea3a180-8445-43b1-9fc0-78bbc399b8d3

fix(test): address compatibility review feedback

069113d

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1ea3a180-8445-43b1-9fc0-78bbc399b8d3

WillieHabi force-pushed the test/client/3.0/prepare-oldest-supported-client-callers branch from 1f5caa2 to 069113d Compare August 24, 2026 20:21

WillieHabi and others added 2 commits August 24, 2026 13:32

style(test): apply constructor type formatting

a4534ed

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1ea3a180-8445-43b1-9fc0-78bbc399b8d3

docs(test): clarify blob compatibility comment

5160c19

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1ea3a180-8445-43b1-9fc0-78bbc399b8d3

WillieHabi requested a review from Jason Hartman (jason-ha) August 24, 2026 21:24

		* Compatibility value for generic tests that previously relied on the runtime's implicit default.
		* Keeping it centralized preserves existing test behavior and simplifies future replacement.

Uh oh!

Conversation

WillieHabi commented Aug 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

Jason Hartman (jason-ha) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Aug 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

WillieHabi commented Aug 20, 2026 •

edited

Loading

github-actions Bot commented Aug 21, 2026 •

edited

Loading