Skip to content

build(eslint-config-fluid): Bump eslint dependencies - #28035

Open
Joshua Smithrud (Josmithr) wants to merge 20 commits into
microsoft:mainfrom
Josmithr:eslint-config-fluid/bump-deps
Open

build(eslint-config-fluid): Bump eslint dependencies#28035
Joshua Smithrud (Josmithr) wants to merge 20 commits into
microsoft:mainfrom
Josmithr:eslint-config-fluid/bump-deps

Conversation

@Josmithr

@Josmithr Joshua Smithrud (Josmithr) commented Aug 21, 2026

Copy link
Copy Markdown
Contributor
  • @rushstack/eslint-plugin: ~0.23.2 -> ~0.23.3
  • @typescript-eslint/eslint-plugin: ~8.58.0 -> ~8.67.0
  • @typescript-eslint/parser: ~8.58.0 -> ~8.67.0
  • @typescript-eslint/utils: ~8.58.0 -> ~8.67.0
  • eslint-import-resolver-typescript: ~4.4.4 -> ~4.4.5
  • eslint-plugin-depend: ~1.4.0 -> ~1.5.0
  • eslint-plugin-import-x: ~4.16.1 -> ~4.17.1
  • eslint-plugin-jsdoc: ~61.4.1 -> ~64.2.1
  • eslint-plugin-no-only-tests: ~3.3.0 -> ~3.4.0
  • eslint-plugin-promise: ~7.2.1 -> ~7.3.0
  • eslint-plugin-react-hooks: ~7.0.1 -> ~7.1.1
  • eslint-plugin-unused-imports: ~4.3.0 -> ~4.4.1
  • typescript-eslint: ~8.58.0 -> ~8.67.0

Copilot AI lite review requested due to automatic review settings August 21, 2026 01:22
@github-actions github-actions Bot added area: tools area: build Build related issues area: repo Repo related work area: website base: main PRs targeted against main branch labels Aug 21, 2026
@github-actions

github-actions Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Hi! Thank you for opening this PR. Want me to review it?

Based on the diff (870 lines, 9 files), I've queued these reviewers:

  • Correctness — logic errors, race conditions, lifecycle issues
  • Security — vulnerabilities, secret exposure, injection
  • API Compatibility — breaking changes, release tags, type design
  • Performance — algorithmic regressions, memory leaks
  • Testing — coverage gaps, hollow tests

How this works

  • Adjust the reviewer set by ticking/unticking boxes above. Reviewer toggles alone don't trigger anything.

  • Tick Start review below to dispatch the review fleet.

  • After review finishes, tick Start review again to request another run — it auto-resets after each dispatch.

  • This comment updates as new commits land; your reviewer selections are preserved.

  • Start review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates eslint-config-fluid ESLint dependencies and regenerates resolved configurations.

Changes:

  • Bumps ESLint, TypeScript ESLint, React, and related plugins.
  • Updates the lockfile and package version to 14.1.1.
  • Removes the deprecated react-hooks/component-hook-factories rule and documents the change.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
common/build/eslint-config-fluid/printed-configs/test.json Regenerated ESLint configuration
common/build/eslint-config-fluid/printed-configs/strict.json Regenerated ESLint configuration
common/build/eslint-config-fluid/printed-configs/strict-biome.json Regenerated ESLint configuration
common/build/eslint-config-fluid/printed-configs/recommended.json Regenerated ESLint configuration
common/build/eslint-config-fluid/printed-configs/react.json Regenerated ESLint configuration
common/build/eslint-config-fluid/printed-configs/default.json Regenerated ESLint configuration
common/build/eslint-config-fluid/pnpm-lock.yaml Updated locked dependency resolutions
common/build/eslint-config-fluid/package.json Updated dependencies and package version
common/build/eslint-config-fluid/CHANGELOG.md Documented the release and rule change
Files not reviewed (1)
  • common/build/eslint-config-fluid/pnpm-lock.yaml: Generated file

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@jason-ha Jason Hartman (jason-ha) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some install failures in CI. Be sure to use pnpm install-no-frozen when trying updates.
Assuming AI selected updates it is best to have the age limit in place (in the config) but we haven't move the workaround to the pipelines yet. So all commands that look to registry need to use the config override (like pnpm install-no-frozen) or pnpm-workspace.yaml needs altered temporarily.

Comment thread common/build/eslint-config-fluid/CHANGELOG.md Outdated
@github-actions

Copy link
Copy Markdown
Contributor

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output

$ start-server-and-test "npm run serve -- --host 127.0.0.1 --no-open" http://127.0.0.1:3000 check-links
1: starting server using command "npm run serve -- --host 127.0.0.1 --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> fluid-framework-website@0.0.0 serve
> docusaurus serve --host 127.0.0.1 --no-open

[SUCCESS] Serving "build" directory at: http://127.0.0.1:3000/

> fluid-framework-website@0.0.0 check-links
> linkcheck http://127.0.0.1:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  338440 links
    2041 destination URLs
    2297 URLs ignored
       0 warnings
       0 errors


@github-actions

Copy link
Copy Markdown
Contributor

Bundle size comparison

Base commit: unresolved
Head commit: 19653b90d2eeb2fb3f986abcacc4879f9be9aaf3

⚠️ Comparison unavailable.

The PR's CI build failed — fix the build and the comment will update once the next run succeeds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: build Build related issues area: repo Repo related work area: tools area: website base: main PRs targeted against main branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants