ci: Share package publish-order generation - #28061
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b5e23e23-c8bd-4fdf-80da-d79507700085
github-actions
Bot
added
area: tools
area: build
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (40 lines, 3 files), I've queued these reviewers:
How this works
|
There was a problem hiding this comment.
Pull request overview
Extracts package publish-order generation into a shared script so both standard npm package builds and Docker service builds produce consistent publish-order files (now containing canonical npm package names, aligned with flub publish tarballs’ expected default format).
Changes:
- Add
scripts/generate-package-publish-order.shto generate per-feed publish-order files usingflub list(package names, not tarball names). - Update
scripts/pack-packages.shto delegate publish-order generation to the shared script. - Update
tools/pipelines/templates/build-docker-service.ymlto call the shared script from the host checkout while keeping packing inside the built container.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/pipelines/templates/build-docker-service.yml | Switch “Generate package lists” to invoke the shared publish-order generation script. |
| scripts/pack-packages.sh | Delegate publish-order generation to the new shared script. |
| scripts/generate-package-publish-order.sh | New shared helper that writes per-feed package-name publish-order files to the staging directory. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Alex Villarreal (alexvy86)
left a comment
Alex Villarreal (alexvy86)
left a comment
There was a problem hiding this comment.
I did a collaborative review with an agent asking for historical context, at what point things broke in the past, etc., and the fix seems good. It also called out that ff_publishing docs talk about "tarball path" when the pipelines there seem to strictly expect package names, so we probably want to update that.
Bundle size comparisonBase commit: Notable changesNo bundles changed by ≥ 500 bytes parsed. Per-bundle deltas
|
Description
Extracts package publish-order generation into a shared script used by both standard npm package builds and Docker service builds. The generated order files now consistently contain canonical npm package names, matching the current publishing pipeline's expected format.
Docker service packages continue to be packed inside the built container. This preserves the generated
lib/distcontent and avoids repeating the regression from PR #22072, where running the complete host-side packing script produced tarballs without built output.