Repository navigation
FIX Stop Copilot and A2A targets from silently losing conversation history - #3078
Open
Utkarsh Bahuguna (u7k4rs6) wants to merge 6 commits into
Open
Utkarsh Bahuguna (u7k4rs6) wants to merge 6 commits into
Utkarsh Bahuguna (u7k4rs6) wants to merge 6 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3077.
Three parts, one commit each:
submit_asyncnow rejects count > 1 when the target lacks editable history and the conversation already has turns, so it fails up front instead of answering each copy blind. Repeat-send on a new conversation still works.Checked against the real flows (mocked Copilot SDK, real MessageSendService, in-process a2a-sdk server):
Tests: Copilot restart case plus system-prompt-only case, A2A own-context and agent-context cases, and the repeat-send reject and new-conversation cases. The new ones fail on main. tests/unit/prompt_target, backend and prompt_normalizer: 3939 passed (4 MCP/tool test files didn't collect locally because
httpx2isn't installed here; they don't touch this code).