Repository navigation
FIX: validate token, repetition count, and mode in RepeatTokenConverter - #3151
Merged
Roman Lutz (romanlutz) merged 4 commits intoOct 13, 2026
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 65ffc210-9edc-46cc-9750-7614f1613efb
Reject non-string insertion modes before set membership and cover empty lists, dictionaries, and lists containing a valid mode. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 65ffc210-9edc-46cc-9750-7614f1613efb
Roman Lutz (romanlutz)
approved these changes
Oct 13, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 65ffc210-9edc-46cc-9750-7614f1613efb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR hardens
RepeatTokenConverterby validating its initialization parameters (token_to_repeat,times_to_repeat, andtoken_insert_mode) and preventing runtime exceptions or silent unexpected transformations.Root Cause
token_insert_moderesulted inmatch mode:falling through without settingself.insert. Whenconvert_asyncwas subsequently invoked, it failed withAttributeError: 'RepeatTokenConverter' object has no attribute 'insert'.boolis a subclass ofintin Python) led to unhandled behavior such as repeating 0 times, creating empty outputs, or failing multiplications.Changes
token_to_repeatto ensure it is a non-empty string.times_to_repeatto ensure it is a positive integer (intand notbool, >= 1).token_insert_modeagainst valid modes ("split","prepend","append","repeat"), raising a descriptiveValueErroron unrecognized values while defaulting cleanly to"split"whenNone.tests/unit/converter/test_repeat_token_converter.pycovering invalid tokens, invalid repetition counts, invalid insertion modes, default mode resolution, and identifier generation.Test Output
python -m pytest tests/unit/converter/test_repeat_token_converter.py -q(27 passed in 0.28s)python -m ruff check pyrit/converter/repeat_token_converter.py tests/unit/converter/test_repeat_token_converter.py(Clean)python -m ruff format --check(Clean)