Repository navigation
FIX: add a request timeout to remote dataset downloads - #3154
Open
Mamidala Som Praneeth Babu (praann07) wants to merge 1 commit into
Open
Mamidala Som Praneeth Babu (praann07) wants to merge 1 commit into
Mamidala Som Praneeth Babu (praann07) wants to merge 1 commit into
Conversation
_RemoteDatasetLoader._fetch_from_public_url and _fetch_zip_from_url_async called requests.get without a timeout, so a stalled server could hang dataset loading forever. The sibling loaders (odin, promptintel) already pass one. Add REQUEST_TIMEOUT_SECONDS (60) and use it at both call sites, with tests.
Mamidala Som Praneeth Babu (praann07)
force-pushed
the
fix/remote-dataset-request-timeout
branch
from
October 12, 2026 13:03
79a3df1 to
4da9c11
Compare
Author
|
@microsoft-github-policy-service agree |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
REQUEST_TIMEOUT_SECONDS = 60to_RemoteDatasetLoaderand passes it to bothrequests.getcalls (_fetch_from_public_urland_fetch_zip_from_url_async). Without it, a stalled server hangs dataset loading forever. The odin and promptintel loaders already set a timeout.Closes #3153.
Tests and Documentation
Two new unit tests in
tests/unit/datasets/test_remote_dataset_loader.pyassert the timeout is passed; they fail without the fix and pass with it. The 40 tests in that file pass andruff check/ruff format --checkare clean. I did not run the full suite or JupyText. No documentation change is needed.