Repository navigation
FIX: record UNDETERMINED when the objective scorer returns no score - #3169
Open
Utkarsh Bahuguna (u7k4rs6) wants to merge 1 commit into
Open
Utkarsh Bahuguna (u7k4rs6) wants to merge 1 commit into
Utkarsh Bahuguna (u7k4rs6) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3112.
When an objective scorer is set and there's a response but the scorer returns no score, the outcome is now UNDETERMINED with "Objective scorer returned no score", instead of FAILURE. That applies to PromptSendingAttack, MultiPromptSendingAttack, RedTeamingAttack and ChunkedRequestAttack.
What doesn't change:
New test goes through
execute_asyncwith a real text-only SubStringScorer and reads the stored result back:The 4 unscored cases fail on main, and the 7 text/blocked ones pass on both, as guards. Three existing tests pinned the old FAILURE for "scorer returned nothing", so I updated them. tests/unit/executor, scenario, analytics and backend: 6275 passed.