Repository navigation
FIX: count attacks without converters as no_converters in analytics - #3170
Open
Utkarsh Bahuguna (u7k4rs6) wants to merge 1 commit into
Open
Utkarsh Bahuguna (u7k4rs6) wants to merge 1 commit into
Utkarsh Bahuguna (u7k4rs6) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3088.
Identifiers leave out an empty converter list, so a real attack with no converters had no list and no edges, and its converter array came out NULL, which is "missing". The converter source now falls back to
[]when the attack identifier is recorded (the joined attack hash is there), which is "no_converters". Results with no attack identifier stay missing, and a retained list or edges still win first.Both arrays (with and without the embedded list) get the fallback, so grouping, filters, facets and drill-downs all agree.
Test runs real PromptSendingAttacks, one plain and one with Base64 on request and response, plus a result with no identifier, for both directions:
get_attack_results_async(has_converters=False)agreesIt fails on main. tests/unit/memory, analytics, backend and models: 6476 passed.