Repository navigation
MAINT: Add dataset context to dataset fetch errors - #3175
Open
Aizen__28 (Yudeeswaran) wants to merge 1 commit into
Open
Aizen__28 (Yudeeswaran) wants to merge 1 commit into
Aizen__28 (Yudeeswaran) wants to merge 1 commit into
Conversation
Author
|
@microsoft-github-policy-service agree |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements P311-08 from #3166. When a dataset provider fetch fails, the original exception receives a diagnostic note identifying the dataset and provider, then is re-raised unchanged.
Adds a regression test verifying that the original exception is preserved and that the note contains the expected context.
Tests and Documentation
uv run --frozen --extra all python -m pytest tests/unit/datasets/test_seed_dataset_provider.py -q --basetemp <workspace-temp-dir>— 181 passed.uv run pre-commit run --files pyrit/datasets/seed_datasets/seed_dataset_provider.py tests/unit/datasets/test_seed_dataset_provider.py— passed.