Repository navigation
MAINT: Bound WebSocket initialization receive time - #3239
Open
Aizen__28 (Yudeeswaran) wants to merge 3 commits into
Open
Aizen__28 (Yudeeswaran) wants to merge 3 commits into
Aizen__28 (Yudeeswaran) wants to merge 3 commits into
Conversation
2 of 25 tasks
|
|
||
|
|
||
| async def test_initialize_connection_async_uses_one_timeout_for_discarded_messages( | ||
| response_parser: Callable[[str | bytes], str | None], |
Contributor
There was a problem hiding this comment.
couple of test nits:
wait_for_message on line 731 is annotated -> str but never returns — asyncio.Event().wait() isn't NoReturn, so ty flags invalid-return-type and make ty fails in CI. Same fix as wait_forever above it: add return "unreachable".
And the shared-budget test is a bit tight — 0.5s budget with two 0.35s sleeps only tolerates 150ms of overshoot before await_count drops to 1. On loaded CI runners that could flake. Maybe assert a timeout happens and await_count < n instead of an exact count?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue and claim
Validation