Skip to content

fix: factor execution env crashes when no conda environment is active #1462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrisbatso wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: factor execution env crashes when no conda environment is active #1462

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion rdagent/components/coder/factor_coder/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,18 @@ def get_factor_env(
enable_cache: Optional[bool] = None,
) -> Env:
conf = FactorCoSTEERSettings()
if hasattr(conf, "python_bin"):
if os.environ.get("CONDA_DEFAULT_ENV"):
env = LocalEnv(conf=(CondaConf(conda_env_name=os.environ.get("CONDA_DEFAULT_ENV"))))
else:
# No conda on this host: run factor code with the current interpreter's env.
# (upstream: hasattr(conf, "python_bin") is always True, so the conda branch
# crashed with CONDA_DEFAULT_ENV unset)
import sys
from pathlib import Path as _Path

from rdagent.utils.env import LocalConf

env = LocalEnv(conf=LocalConf(bin_path=str(_Path(sys.executable).parent), default_entry="python main.py"))
env.conf.extra_volumes = extra_volumes.copy()
env.conf.running_timeout_period = running_timeout_period
if enable_cache is not None:
Expand Down
Loading