fix: handle nullable evaluator diagnostics - #1480
Open
Letian Liu (0x90000) wants to merge 1 commit into
Open
Letian Liu (0x90000) wants to merge 1 commit into
Letian Liu (0x90000) wants to merge 1 commit into
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1458.
CoSTEERSingleFeedback.return_checkingis nullable, but the data-science workflow and pipeline evaluators append validation diagnostics with+=. When model feedback leaves this field asNone, a failed deterministic check raisesTypeErrorinstead of returning structured negative feedback.This change adds a shared null-safe append helper and uses it for all workflow/pipeline validation diagnostics. Existing text is preserved and
Noneis initialized to the same diagnostic format as before.Tests
Noneand existingreturn_checkingvalues.dilldependency is not installed; a direct helper behavior check passes.馃摎 Documentation preview 馃摎: https://RDAgent--1480.org.readthedocs.build/en/1480/