Skip to content

fix: handle nullable evaluator diagnostics - #1480

Open
Letian Liu (0x90000) wants to merge 1 commit into
microsoft:mainfrom
0x90000:fix/nullable-return-checking-1458
Open

Letian Liu (0x90000) wants to merge 1 commit into
microsoft:mainfrom
0x90000:fix/nullable-return-checking-1458

Conversation

@0x90000

@0x90000 Letian Liu (0x90000) commented Sep 9, 2026 •

Copy link
Copy Markdown

Summary

Fixes #1458.

CoSTEERSingleFeedback.return_checking is nullable, but the data-science workflow and pipeline evaluators append validation diagnostics with +=. When model feedback leaves this field as None, a failed deterministic check raises TypeError instead of returning structured negative feedback.

This change adds a shared null-safe append helper and uses it for all workflow/pipeline validation diagnostics. Existing text is preserved and None is initialized to the same diagnostic format as before.

Tests

  • Added regression tests for both None and existing return_checking values.
  • Python compilation passes for all changed files.
  • Ruff import sorting and formatting pass for the new test; the repository's existing evaluator files contain unrelated baseline lint violations.
  • Full pytest collection is blocked in this Windows environment because the optional dill dependency is not installed; a direct helper behavior check passes.

馃摎 Documentation preview 馃摎: https://RDAgent--1480.org.readthedocs.build/en/1480/

@0x90000

Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Evaluators crash when return_checking is None while appending diagnostics

1 participant