Preserve evaluator feedback for undecodable score files - #1483
Open
Sylvester Kaczmarek (sylvesterkaczmarek) wants to merge 1 commit into
Open
Sylvester Kaczmarek (sylvesterkaczmarek) wants to merge 1 commit into
Sylvester Kaczmarek (sylvesterkaczmarek) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1457.
Read the diagnostic preview of
scores.csvas UTF-8 with replacement for undecodable bytes in the workflow, pipeline, and runner evaluators. CSV parsing remains strict, and corrupt output still produces negative feedback instead of a second decoding exception.Adds 15 parameterized cases covering invalid/truncated UTF-8, empty files, malformed Unicode CSV, and valid scores across all three evaluators. The six UTF-8 corruption cases fail against the original code. Tests also verify that existing feedback and file contents are preserved.
Validation on macOS arm64, Python 3.11:
git diff --checkpasses.Model calls, execution environments, and submission checks are mocked. Full research/training workflows were not run.
馃摎 Documentation preview 馃摎: https://RDAgent--1483.org.readthedocs.build/en/1483/