Skip to content

fix(doc-intel): include HTML in the default DocumentIntelligenceConverter file types #2350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tai An (Anai-Guo) wants to merge 1 commit into
base: main
Choose a base branch
from
+23 −0
Open

fix(doc-intel): include HTML in the default DocumentIntelligenceConverter file types #2350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/markitdown/src/markitdown/converters/_doc_intel_converter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ def __init__(
DocumentIntelligenceFileType.DOCX,
DocumentIntelligenceFileType.PPTX,
DocumentIntelligenceFileType.XLSX,
DocumentIntelligenceFileType.HTML,
DocumentIntelligenceFileType.PDF,
DocumentIntelligenceFileType.JPEG,
DocumentIntelligenceFileType.PNG,
Expand Down
22 changes: 22 additions & 0 deletions packages/markitdown/tests/test_docintel_html.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import inspect
import io
from markitdown.converters._doc_intel_converter import (
DocumentIntelligenceConverter,
Expand All @@ -6,6 +7,11 @@
from markitdown._stream_info import StreamInfo


def _default_file_types():
params = inspect.signature(DocumentIntelligenceConverter.__init__).parameters
return params["file_types"].default


def _make_converter(file_types):
conv = DocumentIntelligenceConverter.__new__(DocumentIntelligenceConverter)
conv._file_types = file_types
Expand All @@ -24,3 +30,19 @@ def test_docintel_accepts_html_mimetype():
assert conv.accepts(io.BytesIO(b""), stream_info)
stream_info = StreamInfo(mimetype="application/xhtml+xml", extension=None)
assert conv.accepts(io.BytesIO(b""), stream_info)


def test_docintel_default_file_types_cover_every_supported_type():
# The file_types docstring promises "Defaults to all supported file types",
# so the default must stay in sync with the enum.
assert set(_default_file_types()) == set(DocumentIntelligenceFileType)


def test_docintel_default_accepts_html():
conv = _make_converter(_default_file_types())
for stream_info in (
StreamInfo(mimetype=None, extension=".html"),
StreamInfo(mimetype="text/html", extension=None),
StreamInfo(mimetype="application/xhtml+xml", extension=None),
):
assert conv.accepts(io.BytesIO(b""), stream_info)