Skip to content

Facebook JS SDK loaded but not used? #27

Description

@pbinkley

The Facebook JS SDK is loaded at

ed/_layouts/default.html

Lines 70 to 86 in c62010e

<!-- Facebook SDK for JavaScript -->
<script>
window.fbAsyncInit = function() {
FB.init({
appId : '589495744558280',
xfbml : true,
version : 'v2.6'
});
};
(function(d, s, id){
var js, fjs = d.getElementsByTagName(s)[0];
if (d.getElementById(id)) {return;}
js = d.createElement(s); js.id = id;
js.src = "//connect.facebook.net/en_US/sdk.js";
fjs.parentNode.insertBefore(js, fjs);
}(document, 'script', 'facebook-jssdk'));
, but as far as I can tell it's only referenced in some meta tags
<meta property="fb:admins" content="elotroalex" />
(though I'm not sure whether those are related to the sdk or general Facebook tagging). The wiki mentions moving its config into _config.yml https://github.com/minicomp/ed/wiki/Version-Roadmap#_configyml , but there's nothing there in the out-of-the-box config.

Is it safe to remove it? Or could its inclusion be made conditional on having the config present in _config.yml?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions