Repository navigation
fix(scanner): constrain generic cache marker evidence - #4
Merged
farhan-syah merged 2 commits intoOct 11, 2026
Merged
Conversation
Require the conventional target basename before treating CACHEDIR.TAG as Cargo evidence. Preserve generic caches while retaining configured output paths and rustc markers. Cover direct classification and recursive cleanup planning.
farhan-syah
approved these changes
Oct 11, 2026
farhan-syah
left a comment
farhan-syah
left a comment
Member
There was a problem hiding this comment.
No findings. Generic cache markers now require the conventional target name. Configured paths and .rustc_info.json retain precedence. Formatting, Clippy with warnings denied, 540 serial tests, and diff whitespace checks pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any directory containing CACHEDIR.TAG is currently classified as a Cargo target, regardless of its name or whether it belongs to a Rust project. A non-Cargo cache containing release/deps files can consequently produce deletion candidates under the balanced policy.
Require the conventional target basename before accepting generic CACHEDIR.TAG evidence, matching the existing source comment. Explicitly configured Cargo output directories and directories containing .rustc_info.json remain supported. Tests cover direct classification and recursive planning, preserving an unrelated cache fixture.
Validation
Base: b81f7ce
Branch: fix/require-cargo-cache-evidence
Commit: 8784480