fix(dts-plugin): mark typescript peer dependency optional - #5022
Open
jonahsnider wants to merge 1 commit into
Open
fix(dts-plugin): mark typescript peer dependency optional#5022jonahsnider wants to merge 1 commit into
jonahsnider wants to merge 1 commit into
Conversation
Signed-off-by: Jonah Snider <jonah@jonahsnider.com>
🦋 Changeset detectedLatest commit: 5a2d90c The changes in this PR will be included in the next version bump. This PR includes changesets to release 48 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
@module-federation/dts-plugindefinestypescriptas a peer dependency, but not an optional one. For users of@module-federation/vite,dts-pluginis always installed along with the 30MBtscbinary (or 50MB for WASM/platform-agnostic).https://github.com/module-federation/vite/blob/8c58d47c8ef4706e98e9fd12b000242c09d74d34/src/index.ts#L964-L970
The Vite plugin already ignores importing
dts-pluginwhen disabled, buttypescriptis still installed.This PR marks
typescriptas an optional peer dependency, so that users of the Vite plugin don't need to havetypescriptinstalled even when they aren't using it for anything.Related Issue
Types of changes
Checklist