Skip to content

fix: preserve moduleParseTimeout 0 - #1222

Merged
gioboa merged 2 commits into
module-federation:mainfrom
dmchoi77:fix/module-parse-timeout-0-fix
Sep 7, 2026
Merged

fix: preserve moduleParseTimeout 0#1222
gioboa merged 2 commits into
module-federation:mainfrom
dmchoi77:fix/module-parse-timeout-0-fix

Conversation

@dmchoi77

@dmchoi77 dmchoi77 commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixed an issue where moduleParseTimeout: 0 was normalized to the default value of 10.

  • Replaced || with ?? to preserve 0
  • Added a regression test for moduleParseTimeout: 0

@pkg-pr-new

pkg-pr-new Bot commented Sep 6, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@module-federation/vite@1222

commit: 010291d

@gioboa gioboa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch 👀 @dmchoi77 👍

@gioboa
gioboa merged commit 48069d8 into module-federation:main Sep 7, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants