fix(tests): EIP-6780, EIP-7702, fork inheritance, chain_id - #44
Merged
Conversation
The monad access and storage repricing overran the hardcoded 100k, so the CREATE2 deployments ran out of gas and the scenarios degraded silently. Co-Authored-By: Claude <claude-opus-5>
Monad counts the gas limit towards the block gas used, so the automatic gas limits fill block 1 and raise the base fee past the default fee cap. Co-Authored-By: Claude <claude-opus-5>
MONAD_NINE reported only Prague's EIPs, so the EIP-7883 tests priced modexp with the pre-Osaka formula the spec no longer charges. Co-Authored-By: Claude <claude-opus-5>
Port the upstream chain identifier check, which the monad forks never had: typed transactions went unvalidated and legacy ones failed as a bad signature. Co-Authored-By: Claude <claude-opus-5>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some fixes from upstream #42 missed initially, 4 independent commits with respective desciptions
Greptile Summary
The PR aligns Monad transaction validation with explicit chain-ID extraction, fixes multiple-fork EIP inheritance, and adjusts EIP-6780/EIP-7702 tests.
Confidence Score: 4/5
The oversized legacy chain-ID conversion should be fixed before merging because it can abort transition processing instead of rejecting the transaction normally.
The new extraction path accepts a U256 transaction field but narrows the derived chain ID to U64 without mapping overflow into the transaction-validation exception hierarchy.
Files Needing Attention: src/ethereum/forks/monad_eight/transactions.py, src/ethereum/forks/monad_next/transactions.py, src/ethereum/forks/monad_nine/transactions.py, src/ethereum/forks/monad_ten/transactions.py
Important Files Changed
Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "fix(monad): reject transactions carrying..." | Re-trigger Greptile