Skip to content

[Certora] SettlementFeeSpread: Fix flakiness by replacing non-linear reasoning by axioms - #1237

Merged
QGarchery merged 2 commits into
mainfrom
certora-settlementfeeaxiomatic
Oct 21, 2026
Merged

QGarchery merged 2 commits into
mainfrom
certora-settlementfeeaxiomatic

Conversation

@jhoenicke

Copy link
Copy Markdown
Collaborator

The rule was timing out recently and was always a bit slow. This uses the mulDivAxioms to avoid relying on non-linear reasoning.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T15:58:03.476287Z cdd6a07 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jhoenicke
jhoenicke requested a review from QGarchery October 20, 2026 16:10

@aehyvari aehyvari left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread certora/specs/SettlementFeeSpread.spec
Comment thread certora/specs/SettlementFeeSpread.spec
@QGarchery
QGarchery merged commit 2ded92d into main Oct 21, 2026
65 checks passed
@QGarchery
QGarchery deleted the certora-settlementfeeaxiomatic branch October 21, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants