Repository navigation
[midnight adapter] Arbitrary enterGateFactory per adapter - #1183
Closed
devin-ai-integration[bot] wants to merge 2 commits into
Closed
devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
MathisGD
approved these changes
Oct 20, 2026
…nto devin/1792485600-arbitrary-gate-factory
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
A Midnight adapter checks that a gated market's gate comes from its trusted gate factory, so it can always admit shareholders on force deallocation. In #1136 the adapter factory fixes that gate factory at deployment and each adapter only chooses whether to use it. This PR lets each adapter be created with any gate factory, and leaves the trust decision to registries and curators, which can read the adapter's
enterGateFactory(). Adapter factories no longer need to know the gate factory's address at deployment.Context
enterGateFactory, and check the gate factory in the registry instead.Impact of merging
MidnightAdapterFactorydrops theenterGateFactoryimmutable; its constructor takes onlymidnight, andCreateMidnightAdapterFactoryonly emitsmidnight.createMidnightAdapter,midnightAdapterandCreateMidnightAdaptertake anaddress enterGateFactorywhere they tookbool useGateFactory. The CREATE2 salt iskeccak256(abi.encode(enterGateFactory, salt)).enterGateFactoryis a trustedVaultV2CompatibleEnterGateFactory. A registry accepting Midnight adapters must check it; this PR adds no registry.Changes
MidnightAdapterFactoryandIMidnightAdapterFactorytake the gate factory per adapter.MidnightAdapterNatSpec: what a zero or non-trustedenterGateFactoryimplies.Evidence
forge test --match-path "test/{MidnightAdapterTest,integration/MidnightAdapterIntegrationTest}.sol": 305 passed.Open questions