Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
albert-llimos
left a comment
There was a problem hiding this comment.
This is much better than #1215 imo.
|
Noticed a slight concern with PA compatibility when thinking about the certora spec. Could be ignored if we assume vaults allocating to Blue and midnight don't support Blue PA. Before with withdrawToVault: After this PR: |
…Vault # Conflicts: # src/adapters/MidnightAdapter.sol # test/MidnightAdapterTest.sol
|
if needed we can add back a public refreshAllocations() that calls withdrawtovault(0) & deallocates |
…Vault # Conflicts: # src/adapters/MidnightAdapter.sol
Preserve internal withdrawal and self-funded allocation accounting across the adapter callback identifier renames.
withdraw to vault works through deallocate, alternative to #1215
can't withdraw through forceDeallocate but it's not really needed
Addresses Sherlock #18, Sherlock #21 and Sherlock #32.