Repository navigation
[midnight adapter] cantina minor issues (finding #4) #1286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
50aee0b
[midnight adapter] cantina minor issues (finding #4)
adhusson 78e4fff
Merge remote-tracking branch 'origin/main' into minor-findings-addressed
adhusson 4f161eb
Merge main into Cantina minor findings branch
adhusson b195c6e
Remove extra blank line between transient fields
adhusson b5074e8
Simplify allocate selector documentation
adhusson 4e8ac80
Merge remote-tracking branch 'origin/main' into minor-findings-addressed
adhusson b2b97fc
Remove VaultV2 provenance check from MidnightAdapterFactory
adhusson 5e10a81
Merge main into Cantina minor findings branch
adhusson 4d0b5c2
Remove redundant allocate selector comment
adhusson a7300ee
Merge main into Cantina minor findings branch
adhusson 39b3c2d
Merge main into Cantina minor findings branch
adhusson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.