Remove the unused getOutputLength method from the ColorSpace classes (PR 21637 follow-up) - #21837
Open
Snuffleupagus wants to merge 1 commit into
Open
Remove the unused getOutputLength method from the ColorSpace classes (PR 21637 follow-up)#21837Snuffleupagus wants to merge 1 commit into
getOutputLength method from the ColorSpace classes (PR 21637 follow-up)#21837Snuffleupagus wants to merge 1 commit into
Conversation
…ses (PR 21637 follow-up) The only actual `getOutputLength` call-site, outside of the unit-tests, was removed in PR 21637 and these methods are now unused. This code can always be easily re-instated if needed, thanks to version control, so let's avoid shipping dead code in the builds.
Snuffleupagus
temporarily deployed
to
code-coverage
August 28, 2026 21:10 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 28, 2026 21:10 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 28, 2026 21:10 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 28, 2026 21:10 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 28, 2026 21:10 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 28, 2026 21:10 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 28, 2026 21:10 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 28, 2026 21:10 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 28, 2026 21:10 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 28, 2026 21:10 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 28, 2026 21:10 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 28, 2026 21:10 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 28, 2026 21:10 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 28, 2026 21:10 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 28, 2026 21:10 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21837 +/- ##
==========================================
+ Coverage 90.23% 90.25% +0.01%
==========================================
Files 264 264
Lines 67297 67286 -11
==========================================
+ Hits 60724 60727 +3
+ Misses 6573 6559 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
/botio browsertest |
Collaborator
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/cc7477f893b5556/output.txt |
Collaborator
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/39210f491b4cd51/output.txt |
Collaborator
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/cc7477f893b5556/output.txt Total script time: 19.09 mins
Image differences available at: http://54.241.84.105:8877/cc7477f893b5556/reftest-analyzer.html#web=eq.log |
Collaborator
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/39210f491b4cd51/output.txt Total script time: 24.16 mins
Image differences available at: http://54.193.163.58:8877/39210f491b4cd51/reftest-analyzer.html#web=eq.log |
Collaborator
Author
|
The ref-test "failures" are, most likely, caused by the Firefox 157 update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only actual
getOutputLengthcall-site, outside of the unit-tests, was removed in PR #21637 and these methods are now unused.This code can always be easily re-instated if needed, thanks to version control, so let's avoid shipping dead code in the builds.