Repository navigation
Feature/recorder logic in dashboard - #28
Merged
Merged
Conversation
mikesndrs
marked this pull request as ready for review
August 10, 2026 06:49
mikesndrs
requested review from
DaanVanVugt and
maarten-ic
and removed request for
DaanVanVugt and
maarten-ic
August 10, 2026 07:15
SBlokhuizen
reviewed
Aug 10, 2026
SBlokhuizen
left a comment
SBlokhuizen
left a comment
There was a problem hiding this comment.
I haven't looked at the copied files from the imas-muscle3, or the tests. If you need me to look into it with more detail, let me know.
|
|
||
| def _read_settings(run_folder: Path) -> dict[str, object]: | ||
| """Flat settings from the run's ``configuration.ymmsl`` (empty if | ||
| unavailable — e.g. the optional ymmsl dependency is not installed).""" |
There was a problem hiding this comment.
ymmsl is not an optional dependency, right? It is a dependency of muscle3.
Collaborator
Author
There was a problem hiding this comment.
muscle3 is currently an optional dependency
There was a problem hiding this comment.
Is there a reason to use the dashboard if you don't have muscle available?
Collaborator
Author
There was a problem hiding this comment.
muscle dependency is currently only needed by the visualization
Comment on lines
+89
to
+92
| try: | ||
| import zarr | ||
| except ImportError: | ||
| return None |
Collaborator
Author
There was a problem hiding this comment.
if optional dependencies are not available it should just skip and return None every time imo
SBlokhuizen
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.