Implement matching timelines - #421
Merged
Merged
Conversation
IrisvdWerf
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates MUSCLE3 to the recent changes in timeline handling and adds support to the hammer for processing matching timelines. Best reviewed per commit:
macro:microas the component timeline of themicromodel, rather than having the component timeline be the parent timelinemacro. Also removes absolute timelines, since we don't have those anymore.make test_examplesworks againFinally there's a small cleanup, and the tester is now broken. Fixing it is better left to another PR though, so I've temporarily disabled the test for it.
This needs multiscale/ymmsl-python#73 to be merged for the tests to work, and addresses #417.