[AndrewNolte]

I kept getting editor warnings that "definitions" was deprecated.
I also added a "$comment" option, so we could put descriptions like @generated by ...

[gemini-code-assist]

Summary of Changes

Hello @AndrewNolte, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the JSON schema generation capabilities to align with modern JSON Schema specifications. It transitions from using the deprecated definitions keyword to the current $defs for schema component references and introduces a new feature that allows for the inclusion of a $comment field in the generated schema, enhancing both compliance and descriptive power.

Highlights

• JSON Schema Standard Compliance: The generated JSON schemas now utilize the non-deprecated $defs keyword for defining reusable schema components, replacing the older definitions keyword.
• Add $comment Option: A new optional comment parameter has been introduced to the to_schema function, allowing users to include a $comment field at the root of the generated JSON schema for additional descriptive text.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly updates the JSON schema generation to use the non-deprecated $defs keyword instead of definitions and adds support for a $comment at the root of the schema. The changes are consistent and well-implemented. I have a couple of suggestions to improve performance by avoiding unnecessary string copies when handling the new comment parameter.

[AndrewNolte]

/gemini please fix the tests, and commit your previous suggestion

[gemini-code-assist]

Hi @AndrewNolte, I appreciate you reaching out! However, I am an AI assistant and cannot directly fix tests or commit code. My capabilities are limited to providing code reviews, summaries, and responding to comments with suggestions. If you'd like to see the available commands, please use /gemini help.

[liuzicheng1987]

@AndrewNolte thanks for the contribution!

[liuzicheng1987]

@AndrewNolte , if you want a coding assistant based on Gemini, you can try Jules.

https://jules.google/

They give you 15 free sessions a day, which is crazy.