Fix containing face not being found - #103
Merged
Merged
Conversation
Member
|
At first glance, doing a small limited search is definitely an optimization over just returning an error. I'll have a look at it soon. |
amock
approved these changes
Jul 28, 2026
Member
|
Nice addition! I tested it with the tutorials and from my point of view it only improve things. Note that the optimal solution to this problem is sketched in #104 and will probably replace this one as soon as it is implemented. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MeshMap::searchContainingFace()only checked the faces directly adjacent to the single nearest vertex found viagetNearestVertexHandle(). For the (irregular) mesh that I was using, this sometimes caused the problem that the function would fail to find the containing face, as it was not connected to the nearest vertex. Here is a visualization of the specific issue I had:To solve this, I replaced the single-ring face check with a best-first search:
getNeighboursOfVertex(), visiting the next-closest unvisited vertex to the query point firstmax_distAlso potentially related to #31