Repository navigation
Update from update/networkservicemesh/sdk - #575
Merged
Merged
Conversation
…k@main PR link: networkservicemesh/sdk#1761 Commit: 8c8366a Author: Laszlo Kiraly Date: 2026-09-02 15:32:01 +0200 Message: - Migrate golangci-lint config to v2 and bump linter to v2.13.2 (#1761) golangci-lint v1.64.2 (built with go1.24) fails on this repository under Go 1.25: it errors on the "go 1.25" config target and exhibits pathological memory use (>16GB, never completing) that causes the CI runner to be killed. A release built with go1.25+ resolves both problems (completes in ~40s at ~1.5GB). - Migrate .golangci.yml from the v1 to the v2 format and set run.go to "1.25". - Bump linter-version in ci.yaml from v1.64.2 to v2.13.2 (built with go1.27) so CI runs the v2 linter against the v2 config atomically. - Suppress noise introduced by v2's newer/stricter analyzers so the effective policy matches v1 behavior: * goconst: min-occurrences 2 -> 3; exclude test and testutil helpers * gosec: exclude G304/G702/G703 (file-inclusion and taint-analysis rules on process-controlled paths, not external input) * staticcheck: disable SA4023 (interface nil-comparison false positive) and QF1001/QF1003/QF1008/QF1012 (quickfix style suggestions) * govet: disable the new go1.27 "inline" analyzer Result: golangci-lint run reports 0 issues. Assisted-by: Kiro (AI assistant) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Sep 2, 2026
…d-nsmgr-proxy@main PR link: networkservicemesh/cmd-nsmgr-proxy#575 Commit: b0aa64a Author: Network Service Mesh Bot Date: 2026-09-02 08:46:35 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#575) PR link: networkservicemesh/sdk#1761 Commit: 8c8366a Author: Laszlo Kiraly Date: 2026-09-02 15:32:01 +0200 Message: - Migrate golangci-lint config to v2 and bump linter to v2.13.2 (#1761) golangci-lint v1.64.2 (built with go1.24) fails on this repository under Go 1.25: it errors on the "go 1.25" config target and exhibits pathological memory use (>16GB, never completing) that causes the CI runner to be killed. A release built with go1.25+ resolves both problems (completes in ~40s at ~1.5GB). - Migrate .golangci.yml from the v1 to the v2 format and set run.go to "1.25". - Bump linter-version in ci.yaml from v1.64.2 to v2.13.2 (built with go1.27) so CI runs the v2 linter against the v2 config atomically. - Suppress noise introduced by v2's newer/stricter analyzers so the effective policy matches v1 behavior: * goconst: min-occurrences 2 -> 3; exclude test and testutil helpers * gosec: exclude G304/G702/G703 (file-inclusion and taint-analysis rules on process-controlled paths, not external input) * staticcheck: disable SA4023 (interface nil-comparison false positive) and QF1001/QF1003/QF1008/QF1012 (quickfix style suggestions) * govet: disable the new go1.27 "inline" analyzer Result: golangci-lint run reports 0 issues. Assisted-by: Kiro (AI assistant) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update go.mod and go.sum to latest version from networkservicemesh/sdk@main PR link: networkservicemesh/sdk#1761
Commit: 38d7d38
Author: NSMBot
Date: Wed Sep 2 13:37:39 2026 +0000