legrand-hid: fix beeper.disable to disable, not mute - #3639
Merged
jimklimov merged 5 commits intoSep 14, 2026
Merged
Conversation
AudibleAlarmControl value 3 means "muted" (silences only the current alarm) per NUT's beeper_info table; value 1 means "disabled". The subdriver used 3 for beeper.disable, so the buzzer re-armed after every alarm and the command had no lasting effect. Map beeper.disable to 1, add beeper.mute for 3, and add the ups.beeper.status reading so the state is observable. Tested in Docker with a clean Ubuntu 24.04 build of usbhid-ups. Hardware validation was performed on a Legrand KEOR PDU 800 (1cb0:0038). Fixes: networkupstools#3638 Signed-off-by: Anton Popov <anton.a.popov@gmail.com>
|
A ZIP file with standard source tarball and another tarball with pre-built docs for commit 2b6e891 is temporarily available: NUT-tarballs-PR-3639.zip. |
The Legrand entry is already present in alphabetical order, but the personal dictionary header was one word short. Update the declared count to keep make spellcheck and distribution checks consistent. Signed-off-by: Anton Popov <anton.a.popov@gmail.com>
|
❌ Build nut 2.8.5.5275-master failed (commit 70e334d34a by @antonpopov) |
Aspell reports the brand name from NEWS.adoc as lowercase during spellcheck. Add the lowercase form alongside the existing proper-noun entry and keep the dictionary count synchronized. Signed-off-by: Anton Popov <anton.a.popov@gmail.com>
…pstools#3639] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
|
✅ Build nut 2.8.5.5277-master completed (commit 74ced352c3 by @antonpopov)
|
|
✅ Build nut 2.8.5.5277-master completed (commit 74ced352c3 by @antonpopov) |
|
✅ Build nut 2.8.5.5278-master completed (commit c9e51d9ec0 by @jimklimov)
|
jimklimov
added
USB
Legrand
jimklimov
added
the
AI
jimklimov
added a commit
that referenced
this pull request
Sep 14, 2026
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3638
beeper.disablein the Legrand HID subdriver wroteAudibleAlarmControl = 3, which NUT defines asmuted(current alarm only), rather than1(disabled). The buzzer could re-arm on every alarm.Changes:
beeper.disableto1; keepbeeper.enableat2.beeper.mutefor3.ups.beeper.statusread mapping.0.3to0.4.NEWS.adoc.Testing
Built successfully in a clean Ubuntu 24.04 Docker container with:
Hardware validation was performed on a Legrand KEOR PDU 800 (
1cb0:0038) with NUT 2.8.1.Notes
The same mapping table also serves the Keor SP (
1cb0:0032), which was not tested.AI assistance: GitHub Copilot was used during preparation of this contribution. The human contributor reviewed and takes responsibility for the submitted changes.